jtao15 commented on a change in pull request #6682:
URL: https://github.com/apache/incubator-pinot/pull/6682#discussion_r594793769
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
##########
@@ -128,9 +131,9 @@ private TableConfig createTableConfig()
return JsonUtils.stringToObject(_tableConfigJson, TableConfig.class);
}
- private RealtimeTableDataManager createTableDataManager() {
+ private RealtimeTableDataManager createTableDataManager(TableConfig
tableConfig) {
Review comment:
Updated the test to check the executor is not removed when
tableDataManager is removed. Checked manually that the executor is removed
before the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
