apucher commented on a change in pull request #6613:
URL: https://github.com/apache/incubator-pinot/pull/6613#discussion_r594764360
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -168,11 +185,19 @@ public static URI getRetrieveSchemaURI(String protocol,
String host, int port, S
return getURI(protocol, host, port, SCHEMA_PATH + "/" + schemaName);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
Review comment:
added
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -139,25 +140,41 @@ private static URI getURI(String protocol, String host,
int port, String path)
return new URI(protocol, null, host, port, path, null, null);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
public static URI getRetrieveTableConfigHttpURI(String host, int port,
String rawTableName)
throws URISyntaxException {
return getURI(HTTP, host, port, TABLES_PATH + "/" + rawTableName);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
public static URI getDeleteSegmentHttpUri(String host, int port, String
rawTableName, String segmentName,
String tableType)
throws URISyntaxException {
return new URI(StringUtil.join("/", StringUtils.chomp(HTTP + "://" + host
+ ":" + port, "/"), OLD_SEGMENT_PATH,
rawTableName + "/" + URIUtils.encode(segmentName) + TYPE_DELIMITER +
tableType));
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
public static URI getRetrieveAllSegmentWithTableTypeHttpUri(String host, int
port, String rawTableName,
String tableType)
throws URISyntaxException {
return new URI(StringUtil.join("/", StringUtils.chomp(HTTP + "://" + host
+ ":" + port, "/"), OLD_SEGMENT_PATH,
rawTableName + TYPE_DELIMITER + tableType));
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
Review comment:
added
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -139,25 +140,41 @@ private static URI getURI(String protocol, String host,
int port, String path)
return new URI(protocol, null, host, port, path, null, null);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
public static URI getRetrieveTableConfigHttpURI(String host, int port,
String rawTableName)
throws URISyntaxException {
return getURI(HTTP, host, port, TABLES_PATH + "/" + rawTableName);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
public static URI getDeleteSegmentHttpUri(String host, int port, String
rawTableName, String segmentName,
String tableType)
throws URISyntaxException {
return new URI(StringUtil.join("/", StringUtils.chomp(HTTP + "://" + host
+ ":" + port, "/"), OLD_SEGMENT_PATH,
rawTableName + "/" + URIUtils.encode(segmentName) + TYPE_DELIMITER +
tableType));
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
Review comment:
added
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -139,25 +140,41 @@ private static URI getURI(String protocol, String host,
int port, String path)
return new URI(protocol, null, host, port, path, null, null);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
public static URI getRetrieveTableConfigHttpURI(String host, int port,
String rawTableName)
throws URISyntaxException {
return getURI(HTTP, host, port, TABLES_PATH + "/" + rawTableName);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
Review comment:
added
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -139,25 +140,41 @@ private static URI getURI(String protocol, String host,
int port, String path)
return new URI(protocol, null, host, port, path, null, null);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
+ */
+ @Deprecated
public static URI getRetrieveTableConfigHttpURI(String host, int port,
String rawTableName)
throws URISyntaxException {
return getURI(HTTP, host, port, TABLES_PATH + "/" + rawTableName);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
Review comment:
added
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -139,25 +140,41 @@ private static URI getURI(String protocol, String host,
int port, String path)
return new URI(protocol, null, host, port, path, null, null);
}
+ /**
+ * Deprecated due to lack of protocol/scheme support. May break for
deployments with TLS/SSL enabled
Review comment:
added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
