[GitHub] [incubator-pinot] buchireddy commented on pull request #5892: Expose ResultSetStats in the Pinot client's ResultSetGroup

buchireddy commented on pull request #5892: URL: https://github.com/apache/incubator-pinot/pull/5892#issuecomment-677262648 > @npawar @KKcorps can you please review this PR and make sure if handles both pql and sql path and jdbc Although I'm not fully convinced, it's fair enough ask.

[GitHub] [incubator-pinot] buchireddy commented on a change in pull request #5892: Expose ResultSetStats in the Pinot client's ResultSetGroup

buchireddy commented on a change in pull request #5892: URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r473638573 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java ## @@ -96,6 +96,18 @@ public ResultSetGrou

[incubator-pinot] branch add-counter-for-detecting-schema-mismatch updated (1cf73d1 -> 0fb58c0)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-counter-for-detecting-schema-mismatch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 1cf73d1 Add SchemaValidator add 0fb58c0 Add SchemaValidator This up

[incubator-pinot] branch add-counter-for-detecting-schema-mismatch updated (d638096 -> 1cf73d1)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-counter-for-detecting-schema-mismatch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard d638096 Add SchemaValidator add 1cf73d1 Add SchemaValidator This up

[GitHub] [incubator-pinot] jackjlli commented on pull request #5873: Add Hadoop counters for detecting schema mismatch

jackjlli commented on pull request #5873: URL: https://github.com/apache/incubator-pinot/pull/5873#issuecomment-677030837 > Most of these are already tracked in transformers. Invalid columns etc Correct, but it's encapsulated in RecordRecorder and it will dirty the `RecordRecorder` i

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5873: Add Hadoop counters for detecting schema mismatch

jackjlli commented on a change in pull request #5873: URL: https://github.com/apache/incubator-pinot/pull/5873#discussion_r473581080 ## File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentCreationMapper.jav

[incubator-pinot] branch add-counter-for-detecting-schema-mismatch updated (8b0b778 -> d638096)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch add-counter-for-detecting-schema-mismatch in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8b0b778 Add Hadoop counter for detecting schema mismatch add 2cfaed3

[GitHub] [incubator-pinot] mayankshriv commented on pull request #5872: Support for exact distinct count for non int data types

mayankshriv commented on pull request #5872: URL: https://github.com/apache/incubator-pinot/pull/5872#issuecomment-676999527 > @mayankshriv Currently the `DistinctCount` is not having the expected behavior of returning the exact distinct count because it is storing the `hashCode()` of the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5872: Support for exact distinct count for non int data types

Jackie-Jiang commented on a change in pull request #5872: URL: https://github.com/apache/incubator-pinot/pull/5872#discussion_r473548121 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -111,6 +131,19 @@ public static ObjectType g

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5872: Support for exact distinct count for non int data types

fx19880617 commented on a change in pull request #5872: URL: https://github.com/apache/incubator-pinot/pull/5872#discussion_r473493705 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -111,6 +131,19 @@ public static ObjectType get

[GitHub] [incubator-pinot] mcvsubbu commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

mcvsubbu commented on issue #4484: URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-676836660 Helix provides us a view of "good " vs "bad" instances. IMO if we are adding algorithms on the broker, it should be based on response time of servers. If a server is respon

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5902: Instance API to directly updateTags

Jackie-Jiang commented on a change in pull request #5902: URL: https://github.com/apache/incubator-pinot/pull/5902#discussion_r473459274 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java ## @@ -196,4 +197,2

[incubator-pinot] branch master updated: Fixing the race condition that segment finished before ControllerLeaderLocator created. (#5864)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new c5a8b02 Fixing the race condition tha

[GitHub] [incubator-pinot] fx19880617 merged pull request #5864: Fixing the race condition that segment finished before ControllerLeaderLocator created.

fx19880617 merged pull request #5864: URL: https://github.com/apache/incubator-pinot/pull/5864 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5872: Support for exact distinct count for non int data types

Jackie-Jiang commented on a change in pull request #5872: URL: https://github.com/apache/incubator-pinot/pull/5872#discussion_r473453456 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java ## @@ -452,6 +476,139 @@ public IntSet deserialize

[incubator-pinot] branch exact-distinct-count updated (8f2dff4 -> 1810550)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch exact-distinct-count in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8f2dff4 addressing review comments discard e5fd3a0 Removing code from another PR discard 3

[incubator-pinot] 01/01: [TE] anomalies page - fix feedback is not populated if retrived by the method findByIds

This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch anomalies-feedback-findbyid in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 7fab639475863086fc9fb8b44249656c94701996 Author: Jihao Zhang AuthorDate: Wed Aug 19 16:34:1

[incubator-pinot] branch anomalies-feedback-findbyid created (now 7fab639)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch anomalies-feedback-findbyid in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 7fab639 [TE] anomalies page - fix feedback is not populated if retrived by the method

[GitHub] [incubator-pinot] npawar opened a new pull request #5902: Instance API to directly updateTags

npawar opened a new pull request #5902: URL: https://github.com/apache/incubator-pinot/pull/5902 ## Description New API for updating instance tags. ``` curl -i -X PUT "localhost:9000/instances/Server_10.20.30.40_8000/updateTags?tags=server_OFFLINE,server_REALTIME" HTTP/1.1 200 O

[GitHub] [incubator-pinot] buchireddy commented on a change in pull request #5892: Expose response stats in the Pinot client's BrokerResponse.

buchireddy commented on a change in pull request #5892: URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r473392543 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java ## @@ -24,11 +24,12 @@ /** * Reimpl

[GitHub] [incubator-pinot] buchireddy commented on a change in pull request #5892: Expose response stats in the Pinot client's BrokerResponse.

buchireddy commented on a change in pull request #5892: URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r473389458 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PreparedStatement.java ## @@ -72,6 +72,15 @@ public Result

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #5875: Config recommender patch

codecov-commenter commented on pull request #5875: URL: https://github.com/apache/incubator-pinot/pull/5875#issuecomment-676757756 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5875?src=pr&el=h1) Report > Merging [#5875](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5866: [TE] add anomaly detection as a service - new table for storing ad-hoc data

jasonyanwenl commented on a change in pull request #5866: URL: https://github.com/apache/incubator-pinot/pull/5866#discussion_r473375909 ## File path: thirdeye/thirdeye-pinot/src/main/resources/schema/create-schema.sql ## @@ -437,3 +437,15 @@ create index rootcause_template_id_

[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #5875: Config recommender patch

jasperjiaguo commented on a change in pull request #5875: URL: https://github.com/apache/incubator-pinot/pull/5875#discussion_r473318904 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/io/params/RecommenderConstants.java ## @@ -32,7 +

[GitHub] [incubator-pinot] npawar commented on issue #5900: Cannot use ingestion transform columns in indexes

npawar commented on issue #5900: URL: https://github.com/apache/incubator-pinot/issues/5900#issuecomment-676692376 Column name in ingestionCOnfigs should match the column name in the schema. Schema will contain the final names of the columns, post the transformation. In your example abo

[GitHub] [incubator-pinot] npawar opened a new issue #5901: Fix instance APIs

npawar opened a new issue #5901: URL: https://github.com/apache/incubator-pinot/issues/5901 It seems using the instance APIs is getting users into some erroneous state. Check all the APIs This is an automated message from

[incubator-pinot] branch master updated (3e794ca -> 4fd70fe)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 3e794ca Fixing segment push uri ingestion jobs (#5897) add 4fd70fe Add RANGE FilterKind to support me

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5898: Add RANGE FilterKind to support merging ranges for SQL

Jackie-Jiang merged pull request #5898: URL: https://github.com/apache/incubator-pinot/pull/5898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #5875: Config recommender patch

jackjlli commented on a change in pull request #5875: URL: https://github.com/apache/incubator-pinot/pull/5875#discussion_r473276920 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/rules/utils/QueryInvertedSortedIndexRecommender.java ## @@

[GitHub] [incubator-pinot] lgo opened a new issue #5900: Cannot use ingestion transform columns in indexes

lgo opened a new issue #5900: URL: https://github.com/apache/incubator-pinot/issues/5900 (also non-critical, mostly just usability for being able to flexibility configure Pinot) While experimenting with some schemas, I tried setting up a star-index to use an ingest transform created

[GitHub] [incubator-pinot] kishoreg commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

kishoreg commented on issue #4484: URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-676603896 There was another issue recently where a host was unreachable and the entire query would fail. High-level design sounds good. With Jackie changes to computing routing

[GitHub] [incubator-pinot] icefury71 edited a comment on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

icefury71 edited a comment on issue #4484: URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-676597798 Thanks for the comments Subbu and Ting. Based on what @mcvsubbu mentioned, I'm thinking of adding a failure detector capability in the Pinot broker so that it can p

[GitHub] [incubator-pinot] icefury71 commented on issue #4484: Pinot query timeout due to the broker waiting for a single non-responsive server

icefury71 commented on issue #4484: URL: https://github.com/apache/incubator-pinot/issues/4484#issuecomment-676597798 Thanks for the comments Subbu and Ting. Based on what @mcvsubbu mentioned, I'm thinking of adding a failure detector capability in the Pinot broker so that it can proactiv

[GitHub] [incubator-pinot] lgo opened a new issue #5899: NullPointerException when star-tree index configuration refers to invalid column

lgo opened a new issue #5899: URL: https://github.com/apache/incubator-pinot/issues/5899 Just a usability thing: when writing out some configuration, there was a typo in a schema's field name so the star tree configuration did not have a list of all valid columns. It took a bit of poking t

[GitHub] [incubator-pinot] fx19880617 commented on issue #5877: Standalone ingestion using SegmentUriPush to S3 does not work

fx19880617 commented on issue #5877: URL: https://github.com/apache/incubator-pinot/issues/5877#issuecomment-676569119 I've updated the ingestion uri push job in: https://github.com/apache/incubator-pinot/pull/5897 So users don't need to set `segmentUriPrefix` for push jobs --

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5866: [TE] add anomaly detection as a service - new table for storing ad-hoc data

jasonyanwenl commented on a change in pull request #5866: URL: https://github.com/apache/incubator-pinot/pull/5866#discussion_r473202402 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java ## @@ -511,24 +499

[incubator-pinot] branch release-0.5.0-rc updated: Fix gcsFS copyToLocal to precreate local destination directory (#5890)

This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch release-0.5.0-rc in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/release-0.5.0-rc by this push: new 94b36b6 Fix gcsF

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5892: Expose response stats in the Pinot client's BrokerResponse.

KKcorps commented on a change in pull request #5892: URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r472427252 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/PreparedStatement.java ## @@ -72,6 +72,15 @@ public ResultSet

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5892: Expose response stats in the Pinot client's BrokerResponse.

KKcorps commented on a change in pull request #5892: URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r473161253 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java ## @@ -96,6 +96,18 @@ public ResultSetGroup e

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #5892: Expose response stats in the Pinot client's BrokerResponse.

KKcorps commented on a change in pull request #5892: URL: https://github.com/apache/incubator-pinot/pull/5892#discussion_r473161253 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java ## @@ -96,6 +96,18 @@ public ResultSetGroup e

[GitHub] [incubator-pinot] cyrilou242 edited a comment on pull request #5868: [TE] Added support for BigQuery as data source

cyrilou242 edited a comment on pull request #5868: URL: https://github.com/apache/incubator-pinot/pull/5868#issuecomment-676488023 Hello, I've added a change to make integration with google apis easier. A recent commit (https://github.com/apache/incubator-pinot/commit/0c4a6733c79782d

[GitHub] [incubator-pinot] cyrilou242 commented on pull request #5868: [TE] Added support for BigQuery as data source

cyrilou242 commented on pull request #5868: URL: https://github.com/apache/incubator-pinot/pull/5868#issuecomment-676488023 Hello, I've added a change to make integration with google apis easier. A recent commit (https://github.com/apache/incubator-pinot/commit/0c4a6733c79782d193167a

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5866: [TE] add anomaly detection as a service - new table for storing ad-hoc data

jasonyanwenl commented on a change in pull request #5866: URL: https://github.com/apache/incubator-pinot/pull/5866#discussion_r473093021 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java ## @@ -464,6 +420,

[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5866: [TE] add anomaly detection as a service - new table for storing ad-hoc data

jasonyanwenl commented on a change in pull request #5866: URL: https://github.com/apache/incubator-pinot/pull/5866#discussion_r473085145 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java ## @@ -345,18 +323

[GitHub] [incubator-pinot] fx19880617 merged pull request #5897: Fixing segment push uri ingestion jobs

fx19880617 merged pull request #5897: URL: https://github.com/apache/incubator-pinot/pull/5897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-pinot] branch master updated: Fixing segment push uri ingestion jobs (#5897)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3e794ca Fixing segment push uri inges