Jackie-Jiang commented on a change in pull request #5872:
URL: https://github.com/apache/incubator-pinot/pull/5872#discussion_r473548121
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/ObjectSerDeUtils.java
##########
@@ -111,6 +131,19 @@ public static ObjectType getObjectType(Object value) {
return ObjectType.Geometry;
} else if (value instanceof RoaringBitmap) {
return ObjectType.RoaringBitmap;
+ } else if (value instanceof LongSet) {
+ return ObjectType.LongSet;
+ } else if (value instanceof FloatSet) {
+ return ObjectType.FloatSet;
+ } else if (value instanceof DoubleSet) {
+ return ObjectType.DoubleSet;
+ } else if (value instanceof ObjectSet) {
+ ObjectSet objectSet = (ObjectSet) value;
+ if (objectSet.isEmpty() || objectSet.iterator().next() instanceof
String) {
Review comment:
It is fine for empty set as empty string set and empty bytes set are the
same (both are empty ObjectOpenHashSet)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
