[GitHub] [incubator-pinot] jasonyanwenl commented on a change in pull request #5866: [TE] add anomaly detection as a service - new table for storing ad-hoc data

[GitBox]

jasonyanwenl commented on a change in pull request #5866:
URL: https://github.com/apache/incubator-pinot/pull/5866#discussion_r473085145



##########
File path: 
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/api/detection/AnomalyDetectionResource.java
##########
@@ -345,18 +323,15 @@ DatasetConfigDTO generateDatasetConfig(JsonNode 
payloadNode, String suffix) {
     return datasetConfigDTO;
   }
 
-  MetricConfigDTO generateMetricConfig(JsonNode payloadNode, String suffix,
-        DatasetConfigDTO datasetConfigDTO)
-      throws JsonProcessingException {
+  MetricConfigDTO generateMetricConfig(JsonNode payloadNode, String suffix) {
     MetricConfigDTO metricConfigDTO = new MetricConfigDTO();
-    JsonNode dataNode = payloadNode.get(DATA_FIELD);
 
     // Default configuration
-    metricConfigDTO.setName(DEFAULT_METRIC_NAME + suffix);
+    metricConfigDTO.setName(DEFAULT_METRIC_NAME);

Review comment:
       This is the default name of the metric. We firstly set the metric name 
to be the default one. Then we check if the user provides a metric 
configuration. If so, we will use the customized metric name given by the user.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org