cyrilou242 commented on pull request #5868: URL: https://github.com/apache/incubator-pinot/pull/5868#issuecomment-676488023
Hello, I've added a change to make integration with google apis easier. A recent commit (https://github.com/apache/incubator-pinot/commit/0c4a6733c79782d193167a76d94efa6a206b7631) introduced an implicit dependency to "google-http-client library" < 1.28.0 due to the following import in RootCauseTemplateResource: ` import com.google.api.client.repackaged.com.google.common.base.Strings;` https://github.com/apache/incubator-pinot/blob/master/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/RootCauseTemplateResource.java#L23 The Strings class is being used from guava repackaged in google-http-client library, instead of the expected one from com.google.guava. This makes very difficult to introduce other google-related libraries that bring newer version of `com.google.api-client:google-api-client` : newer version of this library depend on version '1.28.0' of the 'google-http-client' library which does not repackage guava anymore. This PR adds the `google-auth-library-oauth2-http` dependency (for profile bigquery only), which requires google-http-client:jar:1.28.0, so we get at build a NoClassDefFoundError when calling Strings. Given that this Strings dependency is only used 2 times to check if some strings are empty, I replaced it by some vanilla java. This proposition is inspired by the same problem described here: https://issues.apache.org/jira/browse/CAMEL-14292 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
