Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-05 Thread via GitHub
zhangstar333 merged PR #35477: URL: https://github.com/apache/doris/pull/35477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-04 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2148872475 ClickBench: Total hot run time: 30.39 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-04 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2148867232 TPC-DS: Total hot run time: 172716 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-04 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2148867009 TeamCity be ut coverage result: Function Coverage: 36.41% (8985/24676) Line Coverage: 27.93% (73401/262845) Region Coverage: 27.36% (38005/138919) Branch Coverage: 23.9

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-04 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2148856672 TPC-H: Total hot run time: 41425 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-04 Thread via GitHub
github-actions[bot] commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r1626874272 ## be/src/vec/runtime/vdatetime_value.cpp: ## @@ -2933,14 +2937,17 @@ bool DateV2Value::get_date_from_daynr(uint64_t daynr) { } } -set_

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-04 Thread via GitHub
zhangstar333 commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2148788615 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-03 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2145649007 TeamCity be ut coverage result: Function Coverage: 36.24% (9242/25501) Line Coverage: 27.58% (75893/275180) Region Coverage: 26.81% (39297/146556) Branch Coverage: 23.5

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-03 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2145636102 ClickBench: Total hot run time: 30.59 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-03 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2145625034 TPC-DS: Total hot run time: 170586 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-03 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2145599901 TPC-H: Total hot run time: 40688 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-03 Thread via GitHub
zclllyybb commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2145406525 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-03 Thread via GitHub
github-actions[bot] commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r1624208438 ## be/src/vec/runtime/vdatetime_value.cpp: ## @@ -2933,14 +2937,17 @@ bool DateV2Value::get_date_from_daynr(uint64_t daynr) { } } -set_

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-06-03 Thread via GitHub
github-actions[bot] commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2144434624 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-31 Thread via GitHub
zclllyybb commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r1621912729 ## be/src/vec/functions/function.h: ## @@ -54,6 +54,11 @@ namespace doris::vectorized { return is_nullable || !is_datev2 ? make_nullable(std::make_shared())

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-31 Thread via GitHub
zclllyybb commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r1621911699 ## regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_floor_ceil.groovy: ## @@ -32,5 +32,20 @@ suite("test_date_floor_ceil") { qt_sql9 ""

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-31 Thread via GitHub
github-actions[bot] commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2141421780 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-31 Thread via GitHub
zhiqiang- commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r1621902359 ## be/src/vec/functions/function.h: ## @@ -54,6 +54,11 @@ namespace doris::vectorized { return is_nullable || !is_datev2 ? make_nullable(std::make_shared())

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2141189049 ClickBench: Total hot run time: 30.34 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2141185003 TPC-DS: Total hot run time: 169179 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2141184423 TeamCity be ut coverage result: Function Coverage: 36.28% (9232/25444) Line Coverage: 27.64% (75740/274053) Region Coverage: 26.84% (39202/146047) Branch Coverage: 23.6

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2141177639 TPC-H: Total hot run time: 42111 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
zclllyybb commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2141119180 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2140706327 TeamCity be ut coverage result: Function Coverage: 36.27% (9229/25442) Line Coverage: 27.62% (75706/274054) Region Coverage: 26.83% (39189/146043) Branch Coverage: 23.5

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2140700576 ClickBench: Total hot run time: 30.32 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2140688290 TPC-DS: Total hot run time: 169042 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2140663009 TPC-H: Total hot run time: 40196 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
github-actions[bot] commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r1621201324 ## be/src/vec/functions/function_datetime_floor_ceil.cpp: ## @@ -647,7 +673,7 @@ struct TimeRound { static constexpr uint64_t MASK_YEAR_MONTH_DAY_HOUR_

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-30 Thread via GitHub
zclllyybb commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2140417098 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2135870384 ClickBench: Total hot run time: 30.78 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2135861596 TPC-DS: Total hot run time: 170031 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-28 Thread via GitHub
doris-robot commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2135844339 TPC-H: Total hot run time: 40176 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-28 Thread via GitHub
zclllyybb commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2135816726 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-28 Thread via GitHub
github-actions[bot] commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r161761 ## be/src/vec/runtime/vdatetime_value.cpp: ## @@ -3010,7 +3018,9 @@ template bool DateV2Value::date_add_interval(const TimeInterval& interval) { Review

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-28 Thread via GitHub
zclllyybb commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2135698173 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](datetime) Fix date floor functions overflow [doris]

2024-05-28 Thread via GitHub
zclllyybb commented on PR #35477: URL: https://github.com/apache/doris/pull/35477#issuecomment-2135692545 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un