zclllyybb commented on code in PR #35477:
URL: https://github.com/apache/doris/pull/35477#discussion_r1621912729


##########
be/src/vec/functions/function.h:
##########
@@ -54,6 +54,11 @@ namespace doris::vectorized {
     return is_nullable || !is_datev2 ? make_nullable(std::make_shared<TYPE>()) 
          \
                                      : std::make_shared<TYPE>();
 
+#define SET_NULLMAP_IF_FALSE(EXPR) \

Review Comment:
   yes for now. but it's useful and could be used to refactor many code in 
future. so I leave them in `function.h`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to