zclllyybb commented on code in PR #35477: URL: https://github.com/apache/doris/pull/35477#discussion_r1621911699
########## regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_floor_ceil.groovy: ########## @@ -32,5 +32,20 @@ suite("test_date_floor_ceil") { qt_sql9 """select date_ceil("2023-07-14 10:51:00",interval 5 hour); """ qt_sql10 """select date_ceil("2023-07-14 10:51:00",interval 5 day); """ qt_sql11 """select date_ceil("2023-07-14 10:51:00",interval 5 month); """ - qt_sql12 """select date_ceil("2023-07-14 10:51:00",interval 5 year); """ + qt_sql12 """select date_ceil("2023-07-14 10:51:00",interval 5 year); """ + + qt_x1 """ select date_floor('9999-12-31 23:59:59.999999', interval 5 minute); """ + qt_x2 """ select date_floor('9999-12-31 23:59:59.999999', interval 33333 year); """ + qt_x3 """ select date_floor('9999-12-31 23:59:59.999999', interval -10 year); """ + qt_x4 """ select date_floor('1923-12-31 23:59:59.999999', interval -10 year); """ + // qt_x5 """ select date_floor('0000-01-01 00:00:00', interval 7 minute); """//wrong Review Comment: these two cases will be fixed in next pr. leave them here now to reminder to fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org