zhiqiang-hhhh commented on code in PR #35477:
URL: https://github.com/apache/doris/pull/35477#discussion_r1621902359
##########
be/src/vec/functions/function.h:
##########
@@ -54,6 +54,11 @@ namespace doris::vectorized {
return is_nullable || !is_datev2 ? make_nullable(std::make_shared<TYPE>())
\
: std::make_shared<TYPE>();
+#define SET_NULLMAP_IF_FALSE(EXPR) \
Review Comment:
This marco is overly specialized, it can even just be used in this pr.
##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_floor_ceil.groovy:
##########
@@ -32,5 +32,20 @@ suite("test_date_floor_ceil") {
qt_sql9 """select date_ceil("2023-07-14 10:51:00",interval 5 hour); """
qt_sql10 """select date_ceil("2023-07-14 10:51:00",interval 5 day); """
qt_sql11 """select date_ceil("2023-07-14 10:51:00",interval 5 month); """
- qt_sql12 """select date_ceil("2023-07-14 10:51:00",interval 5 year); """
+ qt_sql12 """select date_ceil("2023-07-14 10:51:00",interval 5 year); """
+
+ qt_x1 """ select date_floor('9999-12-31 23:59:59.999999', interval 5
minute); """
+ qt_x2 """ select date_floor('9999-12-31 23:59:59.999999', interval 33333
year); """
+ qt_x3 """ select date_floor('9999-12-31 23:59:59.999999', interval -10
year); """
+ qt_x4 """ select date_floor('1923-12-31 23:59:59.999999', interval -10
year); """
+ // qt_x5 """ select date_floor('0000-01-01 00:00:00', interval 7 minute);
"""//wrong
+ qt_x6 """ select date_floor('0001-01-01 00:00:00', interval 7 minute); """
+ qt_x7 """ select date_ceil('9999-12-31 23:59:59.999999', interval 5
minute); """
+ qt_x8 """ select date_ceil('9999-12-31 23:59:59.999999', interval 1
second); """
+ qt_x9 """ select date_ceil('9999-12-31 23:59:59.999999', interval 100
year); """
+ // qt_x10 """ select date_ceil('0000-01-01 23:59:59.999999', interval 7
month); """//wrong
Review Comment:
what is the meaning of wrong? what is the behavior in this cases?
##########
regression-test/suites/query_p0/sql_functions/datetime_functions/test_date_floor_ceil.groovy:
##########
@@ -32,5 +32,20 @@ suite("test_date_floor_ceil") {
qt_sql9 """select date_ceil("2023-07-14 10:51:00",interval 5 hour); """
qt_sql10 """select date_ceil("2023-07-14 10:51:00",interval 5 day); """
qt_sql11 """select date_ceil("2023-07-14 10:51:00",interval 5 month); """
- qt_sql12 """select date_ceil("2023-07-14 10:51:00",interval 5 year); """
+ qt_sql12 """select date_ceil("2023-07-14 10:51:00",interval 5 year); """
+
+ qt_x1 """ select date_floor('9999-12-31 23:59:59.999999', interval 5
minute); """
+ qt_x2 """ select date_floor('9999-12-31 23:59:59.999999', interval 33333
year); """
+ qt_x3 """ select date_floor('9999-12-31 23:59:59.999999', interval -10
year); """
+ qt_x4 """ select date_floor('1923-12-31 23:59:59.999999', interval -10
year); """
+ // qt_x5 """ select date_floor('0000-01-01 00:00:00', interval 7 minute);
"""//wrong
Review Comment:
what does this mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
