wangbo commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2038863667
##
fe/fe-core/src/main/java/org/apache/doris/resource/computegroup/ComputeGroup.java:
##
@@ -68,6 +69,10 @@ public String getName() {
return name;
}
+
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035066861
##
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaTaskInfo.java:
##
@@ -147,8 +148,9 @@ private TPipelineFragmentParams rePlan(RoutineLoadJob
routine
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035079750
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/DropOldWorkloadGroupThread.java:
##
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035081749
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -504,24 +498,26 @@ public void dropWorkloadGroup(String workloadGroupN
wangbo commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2036401406
##
fe/fe-core/src/test/java/org/apache/doris/utframe/TestWithFeService.java:
##
@@ -158,7 +158,7 @@ public final void beforeAll() throws Exception {
// this.ena
wangbo commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2036412198
##
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaTaskInfo.java:
##
@@ -147,8 +148,9 @@ private TPipelineFragmentParams rePlan(RoutineLoadJob
routineLo
wangbo commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2036410791
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateWorkloadGroupCommand.java:
##
@@ -67,21 +75,38 @@ private void validate(ConnectContext ct
wangbo commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2036402604
##
fe/fe-core/src/main/java/org/apache/doris/catalog/SchemaTable.java:
##
@@ -494,7 +494,7 @@ public class SchemaTable extends Table {
.colu
wangbo commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2036400492
##
fe/fe-core/src/main/java/org/apache/doris/analysis/AlterRoutineLoadStmt.java:
##
@@ -248,9 +249,12 @@ private void checkJobProperties() throws UserException {
wangbo commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2036399795
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -200,82 +203,78 @@ private void writeUnlock() {
lock.writeLock(
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2034638737
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/DropOldWorkloadGroupThread.java:
##
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035061773
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -670,4 +656,62 @@ public ProcResult fetchResult(UserIdentity
currentU
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035078649
##
fe/fe-core/src/main/java/org/apache/doris/resource/computegroup/ComputeGroupMgr.java:
##
@@ -56,4 +59,14 @@ public ComputeGroup getAllBackendComputeGroup() {
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2034750438
##
fe/fe-core/src/main/java/org/apache/doris/catalog/SchemaTable.java:
##
@@ -494,7 +494,7 @@ public class SchemaTable extends Table {
.co
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035076336
##
fe/fe-core/src/main/java/org/apache/doris/resource/computegroup/ComputeGroup.java:
##
@@ -68,6 +69,10 @@ public String getName() {
return name;
}
+
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035062952
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -670,4 +656,62 @@ public ProcResult fetchResult(UserIdentity
currentU
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035074575
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropWorkloadGroupCommand.java:
##
@@ -48,7 +57,19 @@ public void doRun(ConnectContext ctx, St
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035073000
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateWorkloadGroupCommand.java:
##
@@ -67,21 +75,38 @@ private void validate(ConnectContext
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035071284
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateWorkloadGroupCommand.java:
##
@@ -67,21 +75,38 @@ private void validate(ConnectContext
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035070192
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateWorkloadGroupCommand.java:
##
@@ -67,21 +75,38 @@ private void validate(ConnectContext
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035060842
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -670,4 +656,62 @@ public ProcResult fetchResult(UserIdentity
currentU
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035057510
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -670,4 +656,62 @@ public ProcResult fetchResult(UserIdentity
currentU
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035050769
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -200,82 +203,78 @@ private void writeUnlock() {
lock.writeLoc
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2034639985
##
fe/fe-core/src/test/java/org/apache/doris/utframe/TestWithFeService.java:
##
@@ -158,7 +158,7 @@ public final void beforeAll() throws Exception {
// this.e
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2034638737
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/DropOldWorkloadGroupThread.java:
##
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2034623512
##
fe/fe-core/src/main/java/org/apache/doris/analysis/AlterRoutineLoadStmt.java:
##
@@ -248,9 +249,12 @@ private void checkJobProperties() throws UserException {
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2034619945
##
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroupMgr.java:
##
@@ -200,82 +203,78 @@ private void writeUnlock() {
lock.writeLoc
yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2034610874
##
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##
@@ -188,7 +188,7 @@ supportedCreateStatement
(WITH ROLLUP (rollupNames=identifierLis
wangbo opened a new pull request, #49884:
URL: https://github.com/apache/doris/pull/49884
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test
hello-stephen commented on PR #49884:
URL: https://github.com/apache/doris/pull/49884#issuecomment-2786265061
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro
30 matches
Mail list logo