yiguolei commented on code in PR #49884: URL: https://github.com/apache/doris/pull/49884#discussion_r2034610874
########## fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4: ########## @@ -188,7 +188,7 @@ supportedCreateStatement (WITH ROLLUP (rollupNames=identifierList)?)? #createTableLike | CREATE ROLE (IF NOT EXISTS)? name=identifierOrText (COMMENT STRING_LITERAL)? #createRole | CREATE WORKLOAD GROUP (IF NOT EXISTS)? - name=identifierOrText properties=propertyClause? #createWorkloadGroup + name=identifierOrText (FOR computeGroup=identifierOrText)? properties=propertyClause? #createWorkloadGroup Review Comment: 至少要增加一个SQL BASED regression test,来保证这个语法正确,包括对应的系统表 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org