yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035074575
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DropWorkloadGroupCommand.java:
##########
@@ -48,7 +57,19 @@ public void doRun(ConnectContext ctx, StmtExecutor executor)
throws Exception {
if
(!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(),
PrivPredicate.ADMIN)) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
"ADMIN");
}
-
Env.getCurrentEnv().getWorkloadGroupMgr().dropWorkloadGroup(workloadGroupName,
ifExists);
+
+ if (StringUtils.isEmpty(computeGroup)) {
+ computeGroup = Tag.DEFAULT_BACKEND_TAG.value;
+ } else if (Config.isCloudMode()) {
+ String originStr = computeGroup;
+ computeGroup = ((CloudSystemInfoService)
Env.getCurrentEnv().getClusterInfo()).getCloudClusterIdByName(
+ computeGroup);
+ if (StringUtils.isEmpty(computeGroup)) {
+ throw new UserException("can not find clusterId for " +
originStr);
Review Comment:
这里为啥提示词，变成了clusterId？
另外，所有的报错信息里，一句话的开头，第一个字母大写
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
