yiguolei commented on code in PR #49884:
URL: https://github.com/apache/doris/pull/49884#discussion_r2035073000
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/CreateWorkloadGroupCommand.java:
##########
@@ -67,21 +75,38 @@ private void validate(ConnectContext ctx) throws
AnalysisException {
}
String tagStr = properties.get(WorkloadGroup.TAG);
- if (!StringUtils.isEmpty(tagStr)
- &&
WorkloadGroupMgr.DEFAULT_GROUP_NAME.equals(workloadGroupName)) {
+ if (!StringUtils.isEmpty(tagStr)) {
throw new AnalysisException(
- WorkloadGroupMgr.DEFAULT_GROUP_NAME
- + " group can not set tag");
+ "tag is deprecated, you can use create workload group [for
compute group] as a replacement.");
+ }
+
+ String cgStr = properties.get(WorkloadGroup.COMPUTE_GROUP);
+ if (!StringUtils.isEmpty(cgStr)) {
+ throw new AnalysisException(WorkloadGroup.COMPUTE_GROUP + " can
not be set in property.");
}
}
@Override
public void run(ConnectContext ctx, StmtExecutor executor) throws
Exception {
validate(ctx);
+
+ if (StringUtils.isEmpty(computeGroup)) {
+ // todo: add check for backend tag.
+ computeGroup = Tag.DEFAULT_BACKEND_TAG.value;
+ } else if (Config.isCloudMode()) {
+ String originStr = computeGroup;
Review Comment:
存算一体的时候，不需要check tag的backend 是否存在吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
