Re: [PR] [optimize](cooldown)If cooldowned_rowsets is empty, there is no need to follow the logic of traversing the files [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #27324: URL: https://github.com/apache/doris/pull/27324#issuecomment-1878269931 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.97 seconds stream load tsv: 564 seconds loaded 74807831229 Bytes,

Re: [PR] [test](Nereids): add more test for eliminate inner join by fk [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29390: URL: https://github.com/apache/doris/pull/29390#issuecomment-1878269482 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [FIX](complextype) update complex nested support complex type in fe [doris]

2024-01-04 Thread via GitHub
amorynan commented on PR #29548: URL: https://github.com/apache/doris/pull/29548#issuecomment-1878269783 run compile -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [fix](memory) Fix LRUCacheType::NUMBER charge [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29588: URL: https://github.com/apache/doris/pull/29588#issuecomment-1878268287 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [test](Nereids): add more test for eliminate inner join by fk [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29390: URL: https://github.com/apache/doris/pull/29390#issuecomment-1878267320 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](dynamic partition) fix dynamic partition storage medium not working [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29490: URL: https://github.com/apache/doris/pull/29490#issuecomment-1878267144 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.52 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [feature](function) support ip function ipv6_string_to_num(_or_default, _or_null), inet6_aton [doris]

2024-01-04 Thread via GitHub
superdiaodiao commented on PR #28361: URL: https://github.com/apache/doris/pull/28361#issuecomment-1878266523 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] (opt)(file cache) make the cache queue percent configurable [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29537: URL: https://github.com/apache/doris/pull/29537#issuecomment-1878265371 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](dynamic partition) fix dynamic partition storage medium not working [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29490: URL: https://github.com/apache/doris/pull/29490#issuecomment-1878265211 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] (opt)(file cache) make the cache queue percent configurable [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29537: URL: https://github.com/apache/doris/pull/29537#issuecomment-1878264009 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] (opt)(file cache) make the cache queue percent configurable [doris]

2024-01-04 Thread via GitHub
Lchangliang commented on PR #29537: URL: https://github.com/apache/doris/pull/29537#issuecomment-1878263306 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [fix](Nereids) create double literal when create decimal literal failed [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #28959: URL: https://github.com/apache/doris/pull/28959#issuecomment-1878262966 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.09 seconds stream load tsv: 565 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](group_commit) Fix group_commit ut [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29587: URL: https://github.com/apache/doris/pull/29587#issuecomment-1878262410 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [Bug](config) set enabe_agg_state to need forward (#29454) [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29590: URL: https://github.com/apache/doris/pull/29590#issuecomment-1878262149 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 49.67 seconds stream load tsv: 568 seconds loaded 74807831229 Bytes,

[PR] [fix](planner) Fix table sample not take effect [doris]

2024-01-04 Thread via GitHub
xinyiZzz opened a new pull request, #29594: URL: https://github.com/apache/doris/pull/29594 ## Proposed changes Modify `computeSampleTabletIds` location ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org

Re: [PR] [fix](Nereids) create double literal when create decimal literal failed [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #28959: URL: https://github.com/apache/doris/pull/28959#issuecomment-1878261471 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [enhancement](Nereids) add test for push filter through operator [doris]

2024-01-04 Thread via GitHub
jackwener merged PR #27294: URL: https://github.com/apache/doris/pull/27294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Error while running github feature from .asf.yaml in doris!

2024-01-04 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

(doris) branch master updated (d86277c2c22 -> 0eee560f945)

2024-01-04 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from d86277c2c22 [optimize](cooldown)Improved filtering conditions for cooldown tablet (#27338) add 0eee560f945 [enha

Re: [PR] (opt)(file cache) make the cache queue percent configurable [doris]

2024-01-04 Thread via GitHub
zzzxl1993 commented on PR #29537: URL: https://github.com/apache/doris/pull/29537#issuecomment-1878260705 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [Enhancement](array) reserve nested column to improve read array column [doris]

2024-01-04 Thread via GitHub
amorynan commented on PR #29501: URL: https://github.com/apache/doris/pull/29501#issuecomment-1878260304 hey, Is there any data show for ur enhancement ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Pick [bugfix](thirdparty) Upgrade aws s3 sdk to prevent mem leak (#25106) [doris]

2024-01-04 Thread via GitHub
morningman commented on PR #25418: URL: https://github.com/apache/doris/pull/25418#issuecomment-1878259054 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](wal) Fix update wal dir core [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29583: URL: https://github.com/apache/doris/pull/29583#issuecomment-1878256975 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [fix](dynamic partition) fix dynamic partition storage medium not working [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29490: URL: https://github.com/apache/doris/pull/29490#issuecomment-1878255817 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [FIX](complextype) update complex nested support complex type in fe [doris]

2024-01-04 Thread via GitHub
amorynan commented on PR #29548: URL: https://github.com/apache/doris/pull/29548#issuecomment-1878255666 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [chore](clang-tidy): add bugprone linters [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29521: URL: https://github.com/apache/doris/pull/29521#issuecomment-187827 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feature](function) support ip function ipv6_string_to_num(_or_default, _or_null), inet6_aton [doris]

2024-01-04 Thread via GitHub
superdiaodiao commented on PR #28361: URL: https://github.com/apache/doris/pull/28361#issuecomment-1878255385 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Feature](profile)Support report runtime workload statistics [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on code in PR #29591: URL: https://github.com/apache/doris/pull/29591#discussion_r1442576903 ## be/src/runtime/buffer_control_block.h: ## @@ -91,11 +91,7 @@ class BufferControlBlock { [[nodiscard]] const TUniqueId& fragment_id() const { retur

Re: [PR] [fix](memory) Fix LRUCacheType::NUMBER charge [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29588: URL: https://github.com/apache/doris/pull/29588#issuecomment-1878254131 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.87 seconds stream load tsv: 568 seconds loaded 74807831229 Bytes,

Re: [PR] [chore](clang-tidy): add bugprone linters [doris]

2024-01-04 Thread via GitHub
gavinchou commented on PR #29521: URL: https://github.com/apache/doris/pull/29521#issuecomment-1878252811 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [fix](Nereids) create double literal when create decimal literal failed [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #28959: URL: https://github.com/apache/doris/pull/28959#issuecomment-1878251875 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [feature](function) support ip functions isipv4string and isipv6string [doris]

2024-01-04 Thread via GitHub
sjyango commented on PR #28556: URL: https://github.com/apache/doris/pull/28556#issuecomment-1878251468 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [improvement](group commit) Add an option of enable relay wal on all regression test [doris]

2024-01-04 Thread via GitHub
hust-hhb commented on PR #28757: URL: https://github.com/apache/doris/pull/28757#issuecomment-1878251150 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [log](cancel) User should see detail cancel message in terminal [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29589: URL: https://github.com/apache/doris/pull/29589#issuecomment-1878250659 TeamCity be ut coverage result: Function Coverage: 37.84% (8018/21189) Line Coverage: 29.52% (65215/220916) Region Coverage: 28.97% (33526/115733) Branch Coverage: 24.8

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #26856: URL: https://github.com/apache/doris/pull/26856#issuecomment-1878250627 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [feature](function) support ip function ipv6stringtonum(ordefault, ornull), inet6_aton [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on code in PR #28361: URL: https://github.com/apache/doris/pull/28361#discussion_r1442573589 ## be/src/vec/functions/function_ip.h: ## @@ -348,4 +348,261 @@ } }; +namespace detail { +template +ColumnPtr convertToIPv6(const StringColumnType&

[PR] [chore] (broker) Improve broker building process [doris]

2024-01-04 Thread via GitHub
murong00 opened a new pull request, #29593: URL: https://github.com/apache/doris/pull/29593 ## Proposed changes Currently the `outputDirectory` in `maven-thrift-plugin` is not conventional, developers need to move the generated thrift java files to correct directory manually, this ma

Re: [PR] [Feature](profile)Support report runtime workload statistics [doris]

2024-01-04 Thread via GitHub
yiguolei commented on code in PR #29591: URL: https://github.com/apache/doris/pull/29591#discussion_r1442572232 ## be/src/common/daemon.cpp: ## @@ -352,6 +354,65 @@ void Daemon::block_spill_gc_thread() { } } +void Daemon::report_be_workload_runtime_stats_thread() { Revi

Re: [PR] [fix](memory) Fix LRUCacheType::NUMBER charge [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29588: URL: https://github.com/apache/doris/pull/29588#issuecomment-1878247818 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [fix](group_commit) Fix group_commit ut [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29587: URL: https://github.com/apache/doris/pull/29587#issuecomment-1878247589 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.47 seconds stream load tsv: 568 seconds loaded 74807831229 Bytes,

Re: [PR] [enhancement](group_commit) refector wal manager code [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on code in PR #29560: URL: https://github.com/apache/doris/pull/29560#discussion_r1442570565 ## be/src/olap/wal/wal_manager.cpp: ## @@ -507,4 +427,114 @@ std::string WalManager::_get_base_wal_path(const std::string& wal_path_str) { return wal_

[PR] [fix](regression-test) fix non stable case test_bitmap_index [doris]

2024-01-04 Thread via GitHub
cambyzju opened a new pull request, #29592: URL: https://github.com/apache/doris/pull/29592 ## Proposed changes Wrong wait getJobState make this case not stable. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.a

[PR] [Feature](profile)Support report runtime workload statistics [doris]

2024-01-04 Thread via GitHub
wangbo opened a new pull request, #29591: URL: https://github.com/apache/doris/pull/29591 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d

Re: [PR] [Fix](wal) Fix update wal dir core [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29583: URL: https://github.com/apache/doris/pull/29583#issuecomment-1878245718 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.64 seconds stream load tsv: 575 seconds loaded 74807831229 Bytes,

Re: [PR] [Improvement](execute) optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #28788: URL: https://github.com/apache/doris/pull/28788#issuecomment-1878245349 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [I] [Bug] be Aborted [doris]

2024-01-04 Thread via GitHub
liuxinwang commented on issue #27856: URL: https://github.com/apache/doris/issues/27856#issuecomment-1878243893 支持从1.2.7.1回退到1.2.1吗 @LemonLiTree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [fix](group_commit) Fix group_commit ut [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29587: URL: https://github.com/apache/doris/pull/29587#issuecomment-1878243060 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [optimize](cooldown)If cooldowned_rowsets is empty, there is no need to follow the logic of traversing the files [doris]

2024-01-04 Thread via GitHub
xingyingone commented on PR #27324: URL: https://github.com/apache/doris/pull/27324#issuecomment-1878242638 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](auth)remove the key when priv is empty [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29522: URL: https://github.com/apache/doris/pull/29522#issuecomment-1878241128 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](auth)remove the key when priv is empty [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29522: URL: https://github.com/apache/doris/pull/29522#issuecomment-1878241166 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](dynamic partition) fix dynamic partition storage medium not working [doris]

2024-01-04 Thread via GitHub
yujun777 commented on PR #29490: URL: https://github.com/apache/doris/pull/29490#issuecomment-1878239909 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [enhancement](group_commit) refector wal manager code [doris]

2024-01-04 Thread via GitHub
hust-hhb commented on PR #29560: URL: https://github.com/apache/doris/pull/29560#issuecomment-1878240009 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [test](p0) [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29584: URL: https://github.com/apache/doris/pull/29584#issuecomment-1878239682 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [log](cancel) User should see detail cancel message in terminal [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29589: URL: https://github.com/apache/doris/pull/29589#issuecomment-1878238282 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [log](cancel) User should see detail cancel message in terminal [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29589: URL: https://github.com/apache/doris/pull/29589#issuecomment-1878238300 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](memory) Fix LRUCacheType::NUMBER charge [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29588: URL: https://github.com/apache/doris/pull/29588#issuecomment-1878238238 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [Fix](wal) Fix update wal dir core [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29583: URL: https://github.com/apache/doris/pull/29583#issuecomment-1878237046 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [fix](Nereids) exists should not return null [doris]

2024-01-04 Thread via GitHub
morrySnow commented on PR #29435: URL: https://github.com/apache/doris/pull/29435#issuecomment-1878237189 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Improvement](execute) optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #28788: URL: https://github.com/apache/doris/pull/28788#issuecomment-1878236869 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.69 seconds stream load tsv: 576 seconds loaded 74807831229 Bytes,

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #26856: URL: https://github.com/apache/doris/pull/26856#issuecomment-1878236858 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.24 seconds stream load tsv: 562 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](group_commit) Fix group_commit ut [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29587: URL: https://github.com/apache/doris/pull/29587#issuecomment-1878236781 TeamCity be ut coverage result: Function Coverage: 36.63% (8617/23522) Line Coverage: 28.66% (7/244284) Region Coverage: 27.65% (36249/131119) Branch Coverage: 24.3

Re: [PR] [fix](Nereids) create double literal when create decimal literal failed [doris]

2024-01-04 Thread via GitHub
morrySnow commented on PR #28959: URL: https://github.com/apache/doris/pull/28959#issuecomment-1878235943 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [test] test pipelineX [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29567: URL: https://github.com/apache/doris/pull/29567#issuecomment-1878235845 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Bug](config) set enabe_agg_state to need forward (#29454) [doris]

2024-01-04 Thread via GitHub
BiteThet commented on PR #29590: URL: https://github.com/apache/doris/pull/29590#issuecomment-1878235107 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [opt](Nereids) add float type signature for sum aggregate function [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29503: URL: https://github.com/apache/doris/pull/29503#issuecomment-1878234962 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] [Bug](config) set enabe_agg_state to need forward (#29454) [doris]

2024-01-04 Thread via GitHub
BiteThet opened a new pull request, #29590: URL: https://github.com/apache/doris/pull/29590 set enabe_agg_state to need forward ## Proposed changes pick from #29454 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d.

Re: [PR] [test](p0) [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29584: URL: https://github.com/apache/doris/pull/29584#issuecomment-1878234827 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 48.01 seconds stream load tsv: 566 seconds loaded 74807831229 Bytes,

Re: [PR] [Improvement](execute) optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #28788: URL: https://github.com/apache/doris/pull/28788#issuecomment-1878234577 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [fix](fe) comparsion of string and integer should not be cast to double [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29582: URL: https://github.com/apache/doris/pull/29582#issuecomment-1878234146 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 47.4 seconds stream load tsv: 566 seconds loaded 74807831229 Bytes, a

Re: [PR] [fix](fe) comparsion of string and integer should not be cast to double [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29582: URL: https://github.com/apache/doris/pull/29582#issuecomment-1878234023 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [Fix](group commit) Fix wal mem back pressure fault injection case [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29493: URL: https://github.com/apache/doris/pull/29493#issuecomment-1878234015 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.77 seconds stream load tsv: 564 seconds loaded 74807831229 Bytes,

Re: [PR] [log](cancel) User should see detail cancel message in terminal [doris]

2024-01-04 Thread via GitHub
zhiqiang- commented on PR #29589: URL: https://github.com/apache/doris/pull/29589#issuecomment-1878233691 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

(doris) 01/01: [Bug](config) set enabe_agg_state to need forward (#29454)

2024-01-04 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a commit to branch cp_0105 in repository https://gitbox.apache.org/repos/asf/doris.git commit 189d38c4fb61c8643f975353df3e8dedbf48dc9e Author: Pxl AuthorDate: Thu Jan 4 10:47:29 2024 +0800 [Bug](config) se

Re: [PR] [fix](group_commit) Fix group_commit ut [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29587: URL: https://github.com/apache/doris/pull/29587#issuecomment-1878233363 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

[PR] [log](cancel) User should see detail cancel message in terminal [doris]

2024-01-04 Thread via GitHub
zhiqiang- opened a new pull request, #29589: URL: https://github.com/apache/doris/pull/29589 before ``` detailMessage = ()[CANCELLED] ``` after ``` detailMessage = ()[CANCELLED]Query timeout ``` -- This is an automated message from the Apache Git Service. T

(doris) branch cp_0105 created (now 189d38c4fb6)

2024-01-04 Thread panxiaolei
This is an automated email from the ASF dual-hosted git repository. panxiaolei pushed a change to branch cp_0105 in repository https://gitbox.apache.org/repos/asf/doris.git at 189d38c4fb6 [Bug](config) set enabe_agg_state to need forward (#29454) This branch includes the following new com

Re: [PR] [fix](fe) comparsion of string and integer should not be cast to double [doris]

2024-01-04 Thread via GitHub
morrySnow commented on code in PR #29582: URL: https://github.com/apache/doris/pull/29582#discussion_r1442560524 ## fe/fe-core/src/main/java/org/apache/doris/nereids/util/TypeCoercionUtils.java: ## @@ -920,7 +920,7 @@ public static Expression processComparisonPredicate(Comparis

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #26856: URL: https://github.com/apache/doris/pull/26856#issuecomment-1878230964 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [fix](fe) comparsion of string and integer should not be cast to double [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29582: URL: https://github.com/apache/doris/pull/29582#issuecomment-1878229930 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [Fix](group commit) Fix wal mem back pressure fault injection case [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29493: URL: https://github.com/apache/doris/pull/29493#issuecomment-1878229918 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [Fix](group commit) Fix wal mem back pressure fault injection case [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29493: URL: https://github.com/apache/doris/pull/29493#issuecomment-1878228271 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [improve](insert-into) record rows info in log for check [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29581: URL: https://github.com/apache/doris/pull/29581#issuecomment-1878228346 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 49.43 seconds stream load tsv: 566 seconds loaded 74807831229 Bytes,

Re: [PR] [fix](memory) Fix LRUCacheType::NUMBER charge [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on PR #29588: URL: https://github.com/apache/doris/pull/29588#issuecomment-1878227989 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](auth)remove the key when priv is empty [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29522: URL: https://github.com/apache/doris/pull/29522#issuecomment-1878227567 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 46.65 seconds stream load tsv: 569 seconds loaded 74807831229 Bytes,

Re: [PR] [Fix](wal) Fix update wal dir core [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29583: URL: https://github.com/apache/doris/pull/29583#issuecomment-1878227500 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [regression-test](group commit) enable wait_internal_group_commit_finish [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #26856: URL: https://github.com/apache/doris/pull/26856#issuecomment-1878224702 TeamCity be ut coverage result: Function Coverage: 36.63% (8616/23522) Line Coverage: 28.66% (70024/244288) Region Coverage: 27.64% (36244/131121) Branch Coverage: 24.3

Re: [PR] [Fix](wal) Fix update wal dir core [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29583: URL: https://github.com/apache/doris/pull/29583#issuecomment-1878224662 TeamCity be ut coverage result: Function Coverage: 36.64% (8619/23522) Line Coverage: 28.66% (70022/244284) Region Coverage: 27.65% (36260/131118) Branch Coverage: 24.3

Re: [PR] [Improvement](execute) optimize for ColumnNullable's serialize_vec/deserialize_vec [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #28788: URL: https://github.com/apache/doris/pull/28788#issuecomment-1878224907 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

(doris) branch branch-2.1 updated (afaefa3a9e7 -> d86277c2c22)

2024-01-04 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git from afaefa3a9e7 [regression](decimalv2) add schema change test case for decimalv2 (#29474) add 0d0b9d64dd7 [imp

Re: [PR] [Fix](group commit) Fix wal mem back pressure fault injection case [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29493: URL: https://github.com/apache/doris/pull/29493#issuecomment-1878224558 TeamCity be ut coverage result: Function Coverage: 36.63% (8617/23522) Line Coverage: 28.67% (70032/244283) Region Coverage: 27.64% (36239/131119) Branch Coverage: 24.3

Re: [PR] [Fix](show data) Inverted index size not added to data size after index build [doris]

2024-01-04 Thread via GitHub
zzzxl1993 commented on PR #29568: URL: https://github.com/apache/doris/pull/29568#issuecomment-1878224383 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

(doris) branch master updated: [optimize](cooldown)Improved filtering conditions for cooldown tablet (#27338)

2024-01-04 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new d86277c2c22 [optimize](cooldown)Improved filter

Error while running github feature from .asf.yaml in doris!

2024-01-04 Thread Apache Infrastructure
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsub

Re: [PR] [optimize](cooldown)Improved filtering conditions for cooldown tablet [doris]

2024-01-04 Thread via GitHub
yiguolei merged PR #27338: URL: https://github.com/apache/doris/pull/27338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](group_commit) Fix group_commit ut [doris]

2024-01-04 Thread via GitHub
github-actions[bot] commented on code in PR #29587: URL: https://github.com/apache/doris/pull/29587#discussion_r1442554620 ## be/test/olap/wal_manager_test.cpp: ## @@ -64,23 +64,37 @@ class WalManagerTest : public testing::Test { _env->_function_client_cache = new Brpc

Re: [PR] [improve](insert-into) record rows info in log for check [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29581: URL: https://github.com/apache/doris/pull/29581#issuecomment-1878222685 TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpch-tools ``` Tpch sf100 test result on

Re: [PR] [Performance](exec) opt the exchange performance [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29579: URL: https://github.com/apache/doris/pull/29579#issuecomment-1878222581 TeamCity be ut coverage result: Function Coverage: 36.63% (8617/23523) Line Coverage: 28.64% (70028/244479) Region Coverage: 27.63% (36249/131183) Branch Coverage: 24.3

Re: [PR] [improve](insert-into) record rows info in log for check [doris]

2024-01-04 Thread via GitHub
doris-robot commented on PR #29581: URL: https://github.com/apache/doris/pull/29581#issuecomment-187827 TPC-DS test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G', run with scripts in https://github.com/apache/doris/tree/master/tools/tpcds-tools ``` TPC-DS sf100 test result

Re: [PR] [fix](memory) Fix LRUCacheType::NUMBER charge [doris]

2024-01-04 Thread via GitHub
xinyiZzz commented on PR #29588: URL: https://github.com/apache/doris/pull/29588#issuecomment-1878222053 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [fix](memory) Fix LRUCacheType::NUMBER charge [doris]

2024-01-04 Thread via GitHub
xinyiZzz opened a new pull request, #29588: URL: https://github.com/apache/doris/pull/29588 ## Proposed changes if LRUCacheType::NUMBER, charge not add handle_size, because charge at this time is no longer the memory size, but an independent weight. ## Further comments I

  1   2   3   4   5   6   7   8   9   10   >