github-actions[bot] commented on code in PR #29587:
URL: https://github.com/apache/doris/pull/29587#discussion_r1442554620
##########
be/test/olap/wal_manager_test.cpp:
##########
@@ -64,23 +64,37 @@ class WalManagerTest : public testing::Test {
_env->_function_client_cache = new
BrpcClientCache<PFunctionService_Stub>();
_env->_stream_load_executor = StreamLoadExecutor::create_shared(_env);
_env->_store_paths = {StorePath(std::filesystem::current_path(), 0)};
- _env->_wal_manager = WalManager::create_shared(_env, wal_dir);
+ _env->_wal_manager = WalManager::create_shared(_env, wal_dir.string());
k_stream_load_begin_result = TLoadTxnBeginResult();
}
void TearDown() override {
-
static_cast<void>(io::global_local_filesystem()->delete_directory(wal_dir));
+ Status st = io::global_local_filesystem()->delete_directory(wal_dir);
+ if (!st.ok()) {
+ LOG(WARNING) << "fail to delete " << wal_dir.string();
+ }
SAFE_STOP(_env->_wal_manager);
SAFE_DELETE(_env->_function_client_cache);
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_master_info);
}
- void prepare() {
static_cast<void>(io::global_local_filesystem()->create_directory(wal_dir)); }
+ void prepare() {
Review Comment:
warning: method 'prepare' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void prepare() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
