murong00 opened a new pull request, #29593:
URL: https://github.com/apache/doris/pull/29593

   ## Proposed changes
   
   Currently the `outputDirectory` in `maven-thrift-plugin` is not 
conventional, developers need to move the generated thrift java files to 
correct directory manually, this may confuse some new users. This pr uses the 
preferred  way as below:
   - create `thrift` dir in `src/main` which is the default `thriftSourceRoot` 
for `maven-thrift-plugin`
   - the thrift java files are generated into `target/generated-sources` 
automatically when compiled
   
   In addition, the properties `skip.plugin` and `env.DORIS_THIRDPARTY` are not 
available since module `broker` is independent, use the correct values instead.
   
   ## Further comments
   
   The final directory structure is as follows:
   
   
![thrift](https://github.com/apache/doris/assets/31875453/00fedfc0-ca55-4a35-8c1e-471340233b70)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to