github-actions[bot] commented on code in PR #29591:
URL: https://github.com/apache/doris/pull/29591#discussion_r1442576903
##########
be/src/runtime/buffer_control_block.h:
##########
@@ -91,11 +91,7 @@ class BufferControlBlock {
[[nodiscard]] const TUniqueId& fragment_id() const { return _fragment_id; }
- void set_query_statistics(std::shared_ptr<QueryStatistics> statistics) {
- _query_statistics = statistics;
- }
-
- void update_num_written_rows(int64_t num_rows) {
+ void update_return_rows(int64_t num_rows) {
Review Comment:
warning: method 'update_return_rows' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void update_return_rows(int64_t num_rows) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
