morningman commented on pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#issuecomment-644562825
> > > When the FE Coordinator executes execRemoteFragmentAsync(), if it
finds an RPC error, return a Future with an error code instead of exception.
> >
> >
morningman commented on a change in pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#discussion_r440616500
##
File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java
##
@@ -1469,8 +1470,41 @@ public boolean isBackendStateHealthy() {
chaoyli commented on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644558471
> And by the way, better to fix the compilation problem in another PR.
> That is more urgent and need to be fixed and merged ASAP.
It's because I run the unit te
morningman commented on pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#issuecomment-644557656
> > When the FE Coordinator executes execRemoteFragmentAsync(), if it finds
an RPC error, return a Future with an error code instead of exception.
>
> @morningm
morningman commented on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644557164
> I thinks the variable forward_to_master is useless, even make application
complicated. User deploy the Doris will one Master and two Follower. The master
will chang
morningman commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440610898
##
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFrag
chaoyli edited a comment on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644554315
> Hi @chaoyli . Actually, not all `ShowProc` stmt should be forward to
master.
> Some of them, yes, like: `show proc "/cluster_balance"`, because the
non-maste
chaoyli commented on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644554315
> Hi @chaoyli . Actually, not all `ShowProc` stmt should be forward to
master.
> Some of them, yes, like: `show proc "/cluster_balance"`, because the
non-master FE ha
wuyunfeng commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440608474
##
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragm
chaoyli removed a comment on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644552857
> Hi @chaoyli . Actually, not all `ShowProc` stmt should be forward to
master.
> Some of them, yes, like: `show proc "/cluster_balance"`, because the
non-mast
chaoyli commented on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644552857
> Hi @chaoyli . Actually, not all `ShowProc` stmt should be forward to
master.
> Some of them, yes, like: `show proc "/cluster_balance"`, because the
non-master FE ha
morningman commented on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644551305
In fact, this parameter is mainly to solve the "publish timeout" problem.
If the publish time is more consistent on all replicas, then this config is
actually meani
WingsGo commented on pull request #3866:
URL: https://github.com/apache/incubator-doris/pull/3866#issuecomment-644551059
> @WingsGo Hi, it seems code format code still exist in this PR.
Yes, It's because the code file includes some core function,so I have to
revert it one by one, but
morningman commented on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644549909
> @morningman I see.
>
> ```
> for (auto rowset : _input_rowsets) {
> if (rowset->end_version() <= _tablet->latest_read_version()
>
kangkaisen commented on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644545224
@morningman I see.
```
for (auto rowset : _input_rowsets) {
if (rowset->end_version() <= _tablet->latest_read_version()
|| rowset->creat
morningman commented on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644543792
And by the way, better to fix the compilation problem in another PR.
That is more urgent and need to be fixed and merged ASAP.
morningman commented on pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#issuecomment-644543498
Hi @chaoyli . Actually, not all `ShowProc` stmt should be forward to master.
Some of them, yes, like: `show proc "/cluster_balance"`, because the
non-master FE has
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596929
##
File path: fe/src/main/java/org/apache/doris/planner/MysqlScanNode.java
##
@@ -149,4 +150,14 @@ public int getNumInstances() {
retur
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596171
##
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragm
kangkaisen commented on a change in pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822#discussion_r440596514
##
File path: docs/zh-CN/administrator-guide/operation/tablet-meta-tool.md
##
@@ -136,4 +136,13 @@ api：
./lib/meta_tool --operation=show_meta
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440594546
##
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragm
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596171
##
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragm
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440596171
##
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragm
morningman commented on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644540827
> * now, if cumulative_compaction_skip_window_seconds =30 +
latest_read_version, system will then do compaction every 30s and
latest_read_version will be ignored
kangkaisen commented on pull request #3866:
URL: https://github.com/apache/incubator-doris/pull/3866#issuecomment-644539797
@WingsGo Hi, it seems code format code still exist in this PR.
This is an automated message from the
wutiangan commented on a change in pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886#discussion_r440594546
##
File path: fe/src/main/java/org/apache/doris/planner/DistributedPlanner.java
##
@@ -294,6 +294,11 @@ private PlanFragment createHashJoinFragm
kangkaisen commented on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644535162
> According to `We can use cumulative_compaction_skip_window_seconds to
configure this threshold. That is, when the threshold time is exceeded,
latest_read_version will b
wuyunfeng commented on a change in pull request #3454:
URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r440588407
##
File path:
fe/src/main/java/org/apache/doris/external/elasticsearch/EsIndexState.java
##
@@ -44,7 +47,43 @@ public EsIndexState(String index
wuyunfeng commented on a change in pull request #3454:
URL: https://github.com/apache/incubator-doris/pull/3454#discussion_r440585954
##
File path:
fe/src/main/java/org/apache/doris/external/elasticsearch/EsIndexState.java
##
@@ -44,7 +47,43 @@ public EsIndexState(String index
morningman opened a new pull request #3886:
URL: https://github.com/apache/incubator-doris/pull/3886
Fix #3885
1. Set MysqlScanNode's cardinality to 0
This is an automated message from the Apache Git Service.
To respon
morningman opened a new issue #3885:
URL: https://github.com/apache/incubator-doris/issues/3885
**Describe the bug**
When execute sql with a olap table join a mysql table, SQL planner will
return a SHUFFLE join
plan, which may cause a lot of network data transmission.
This is b
yangzhg commented on pull request #3806:
URL: https://github.com/apache/incubator-doris/pull/3806#issuecomment-644519515
> why it has much of uncorrelated code.
done
This is an automated message from the Apache Git Ser
yangzhg commented on a change in pull request #3822:
URL: https://github.com/apache/incubator-doris/pull/3822#discussion_r440573216
##
File path: be/src/tools/meta_tool.cpp
##
@@ -34,6 +34,13 @@
#include "json2pb/pb_to_json.h"
#include "gutil/strings/split.h"
#include "gutil
kangkaisen commented on a change in pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883#discussion_r440572972
##
File path: fe/src/main/java/org/apache/doris/analysis/ShowProcStmt.java
##
@@ -82,10 +82,6 @@ public ShowResultSetMetaData getMetaData() {
kangkaisen commented on pull request #3878:
URL: https://github.com/apache/incubator-doris/pull/3878#issuecomment-644515644
@xy720 Hi, Please add the UT for new BufferedReader class, Thanks.
This is an automated message from
kangkaisen commented on a change in pull request #3878:
URL: https://github.com/apache/incubator-doris/pull/3878#discussion_r440570998
##
File path: be/src/exec/buffered_reader.h
##
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
kangkaisen commented on a change in pull request #3869:
URL: https://github.com/apache/incubator-doris/pull/3869#discussion_r440569648
##
File path: be/src/olap/aggregate_func.h
##
@@ -449,15 +449,22 @@ struct
AggregateFuncTraits
struct AggregateFuncTraits {
static void
chaoyli commented on issue #3884:
URL:
https://github.com/apache/incubator-doris/issues/3884#issuecomment-644511890
master:
--
chaoyli commented on issue #3884:
URL:
https://github.com/apache/incubator-doris/issues/3884#issuecomment-644511945
follower:
chaoyli opened a new issue #3884:
URL: https://github.com/apache/incubator-doris/issues/3884
Now some SHOW PROC statementss have no message when executed
in follower. These message are only in master.
This is an automated
chaoyli opened a new pull request #3883:
URL: https://github.com/apache/incubator-doris/pull/3883
Now some SHOW PROC statementss have no message when executed
in follower. These message are only in master. So I add
FORWARD_NO_SYNC for all SHOW PROC statements.
---
yiguolei commented on a change in pull request #3881:
URL: https://github.com/apache/incubator-doris/pull/3881#discussion_r440560907
##
File path:
fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java
##
@@ -550,19 +550,20 @@ public By
HangyuanLiu commented on pull request #3873:
URL: https://github.com/apache/incubator-doris/pull/3873#issuecomment-644504909
> Please provide detailed commit message
Done
This is an automated message from the Apache Gi
chaoyli commented on pull request #3791:
URL: https://github.com/apache/incubator-doris/pull/3791#issuecomment-644501696
It seems a common problem when build. You can add it into
docs/zh-CN/installing/install-deploy.md and docs/en/installing/install-deploy.md
-
yiguolei commented on pull request #3878:
URL: https://github.com/apache/incubator-doris/pull/3878#issuecomment-644500884
Great job
This is an automated message from the Apache Git Service.
To respond to the message, please l
kangkaisen commented on pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#issuecomment-644498556
> When the FE Coordinator executes execRemoteFragmentAsync(), if it finds an
RPC error, return a Future with an error code instead of exception.
@morningman Hi,
WingsGo commented on pull request #3882:
URL: https://github.com/apache/incubator-doris/pull/3882#issuecomment-644497394
For #3880
This is an automated message from the Apache Git Service.
To respond to the message, please l
WingsGo opened a new pull request #3882:
URL: https://github.com/apache/incubator-doris/pull/3882
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
xy720 opened a new pull request #3881:
URL: https://github.com/apache/incubator-doris/pull/3881
#3879
This commit fixs a bug that broker cannot read the full length of buffer
size, when the buffer size is set larger than 128k.
This bug will cause the data size returned by pread r
WingsGo opened a new issue #3880:
URL: https://github.com/apache/incubator-doris/issues/3880
**Describe the bug**
If we create table like follwing
```
CREATE TABLE `test_show_create` (
`date` int(11) NOT NULL,
`idhash` bitmap BITMAP_UNION NOT NULL
) ENGINE=OLAP
A
xy720 opened a new issue #3879:
URL: https://github.com/apache/incubator-doris/issues/3879
**Describe the bug**
Our current broker cannot read the full length of buffer from input stream
when the buffer size is set larger than 128k.
**To Reproduce**
Set the pread request's leng
EmmyMiao87 commented on pull request #3873:
URL: https://github.com/apache/incubator-doris/pull/3873#issuecomment-644493550
Please provide detailed commit message
This is an automated message from the Apache Git Service.
To r
xy720 opened a new pull request #3878:
URL: https://github.com/apache/incubator-doris/pull/3878
Please see the description in #3877 .
This is an automated message from the Apache Git Service.
To respond to the message, please
wuyunfeng commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440531919
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -30,72 +30,320 @@ Doris-On-ES将Doris的分布式查询规划能力和ES(Elasticsearch)的全文
1. ES中的多in
fanlongmengjd edited a comment on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644293419
According to `We can use cumulative_compaction_skip_window_seconds to
configure this threshold. That is, when the threshold time is exceeded,
latest_read_versio
fanlongmengjd commented on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644293419
According to `We can use cumulative_compaction_skip_window_seconds to
configure this threshold. That is, when the threshold time is exceeded,
latest_read_version will
xy720 opened a new issue #3877:
URL: https://github.com/apache/incubator-doris/issues/3877
Currently, broker load support reading parquet file from remote, and soon we
will use parquet format as intermediate output in spark load.
But due to the seperated metadata (file meta/column me
morningman commented on a change in pull request #3858:
URL: https://github.com/apache/incubator-doris/pull/3858#discussion_r440120241
##
File path: be/src/runtime/data_stream_recvr.h
##
@@ -163,6 +163,7 @@ class DataStreamRecvr {
// receiver and placed in _sender_queue_po
wutiangan commented on a change in pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#discussion_r440114459
##
File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java
##
@@ -1469,8 +1470,41 @@ public boolean isBackendStateHealthy() {
wutiangan commented on a change in pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#discussion_r440113858
##
File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java
##
@@ -1469,8 +1470,41 @@ public boolean isBackendStateHealthy() {
wutiangan commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440110249
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -195,37 +443,30 @@ select * from es_table where esquery(k4, ' {
1.
创建ES外表后，FE会
wutiangan commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440109428
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -30,72 +30,320 @@ Doris-On-ES将Doris的分布式查询规划能力和ES(Elasticsearch)的全文
1. ES中的多in
wutiangan commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440109428
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -30,72 +30,320 @@ Doris-On-ES将Doris的分布式查询规划能力和ES(Elasticsearch)的全文
1. ES中的多in
wutiangan commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440107816
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -30,72 +30,320 @@ Doris-On-ES将Doris的分布式查询规划能力和ES(Elasticsearch)的全文
1. ES中的多in
wutiangan commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440107314
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -30,72 +30,320 @@ Doris-On-ES将Doris的分布式查询规划能力和ES(Elasticsearch)的全文
1. ES中的多in
sduzh opened a new issue #3876:
URL: https://github.com/apache/incubator-doris/issues/3876
**To Reproduce**
```
CREATE TABLE t0(c0 INT , c1 DOUBLE )DUPLICATE KEY(c0) DISTRIBUTED BY
HASH(c0) BUCKETS 1 PROPERTIES("replication_num"="1");
SELECT MIN(CAST(0.15508025062004804 AS DATE))
wutiangan commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440105076
##
File path: docs/en/extending-doris/doris-on-es.md
##
@@ -26,62 +26,314 @@ under the License.
# Doris On ES
-Doris-On-ES combines Doris's
wutiangan commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440105196
##
File path: docs/en/extending-doris/doris-on-es.md
##
@@ -26,62 +26,314 @@ under the License.
# Doris On ES
-Doris-On-ES combines Doris's
sduzh opened a new issue #3875:
URL: https://github.com/apache/incubator-doris/issues/3875
**To Reproduce**
```SQL
CREATE TABLE t0(c0 DECIMAL(2,0) )DUPLICATE KEY(c0) DISTRIBUTED BY HASH(c0)
BUCKETS 1 PROPERTIES("replication_num"="1");
INSERT INTO t0 VALUES (1);
SELECT t0.c0 FROM
wuyunfeng commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440088348
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -30,72 +30,320 @@ Doris-On-ES将Doris的分布式查询规划能力和ES(Elasticsearch)的全文
1. ES中的多in
sduzh edited a comment on issue #3865:
URL:
https://github.com/apache/incubator-doris/issues/3865#issuecomment-643957485
`natural` is a keyword of `MySQL` while it is parsed as the alias name of
table `t0` here, which is very confusing for MySQL user.
sduzh opened a new issue #3874:
URL: https://github.com/apache/incubator-doris/issues/3874
**Describe the bug**
BE crashed when running the [sqlancer](https://github.com/sqlancer/sqlancer).
**To Reproduce**
```SQL
CREATE TABLE t0(c0 BIGINT , c1 TINYINT )DUPLICATE KEY(c0) DIST
This is an automated email from the ASF dual-hosted git repository.
lichaoyong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6c4d7c6 [Feature] Add QueryDetail
chaoyli closed issue #3689:
URL: https://github.com/apache/incubator-doris/issues/3689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chaoyli merged pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
HangyuanLiu opened a new pull request #3873:
URL: https://github.com/apache/incubator-doris/pull/3873
Support materialized view schema change history data
1、bitmap
2、hill
3、count
This is an automated message from the
EmmyMiao87 commented on a change in pull request #3867:
URL: https://github.com/apache/incubator-doris/pull/3867#discussion_r440052521
##
File path: docs/zh-CN/extending-doris/doris-on-es.md
##
@@ -30,72 +30,320 @@ Doris-On-ES将Doris的分布式查询规划能力和ES(Elasticsearch)的全文
1. ES中的多i
morningman opened a new pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872
Fix: #3871
Mainly change:
1. Fix the bug in `update_status(status)` of `PlanFragmentExecutor`.
2. When the FE Coordinator executes `execRemoteFragmentAsync()`, if it finds
an RP
morningman opened a new issue #3871:
URL: https://github.com/apache/incubator-doris/issues/3871
**Describe the bug**
BE crash with coredump like:
```
(gdb) bt
#0 0x in ?? ()
#1 0x01045667 in release (bytes=8192, this=0x633b7d40) at
/var/doris/pal
sduzh commented on issue #3870:
URL:
https://github.com/apache/incubator-doris/issues/3870#issuecomment-644008305
The `EXPLAIN` statement is OK:
```
mysql> explain SELECT t0.c0 FROM t0 GROUP BY t0.c0 HAVING
MIN(((634403704)>=(MOD((('k')LIKE('1')), ACOS(((2050915657)<=(1))) < 10;
sduzh opened a new issue #3870:
URL: https://github.com/apache/incubator-doris/issues/3870
**Describe the bug**
Run query failed with error message `ERROR 1064 (HY000): errCode = 2,
detailMessage = Unknown expr node type: 0`
**To Reproduce**
```
CREATE TABLE `t0` (
`c0`
Youngwb opened a new pull request #3869:
URL: https://github.com/apache/incubator-doris/pull/3869
According #3868, BE will core because of invalid address, This bug
happens occasionally because most of the time HyperLogLog's data are nullptr,
which does not cause crashes, but sometimes
HangyuanLiu closed pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Youngwb opened a new issue #3868:
URL: https://github.com/apache/incubator-doris/issues/3868
**Describe the bug**
BE will core when user query table which contains HLL data and it's write by
old version(maybe 0.10), This bug happens occasionally, not always
**Screenshots**
