morningman commented on a change in pull request #3872:
URL: https://github.com/apache/incubator-doris/pull/3872#discussion_r440616500



##########
File path: fe/src/main/java/org/apache/doris/qe/Coordinator.java
##########
@@ -1469,8 +1470,41 @@ public boolean isBackendStateHealthy() {
             try {
                 return 
BackendServiceProxy.getInstance().execPlanFragmentAsync(brpcAddress, rpcParams);
             } catch (RpcException e) {
-                SimpleScheduler.addToBlacklist(backend.getId());
-                throw e;
+                // Do not throw exception here.
+                // return a completed future, the caller will check the result 
and do the cancel process.
+                PExecPlanFragmentResult result = new PExecPlanFragmentResult();
+                PStatus pStatus = new PStatus();
+                pStatus.error_msgs.add(e.getMessage());
+                // use THRIFT_RPC_ERROR so that this BE will be added to the 
black list later.

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to