morningman commented on issue #3859:
URL:
https://github.com/apache/incubator-doris/issues/3859#issuecomment-644549909
> @morningman I see.
>
> ```
> for (auto rowset : _input_rowsets) {
> if (rowset->end_version() <= _tablet->latest_read_version()
> || rowset->creation_time() +
config::cumulative_compaction_skip_window_seconds < now) {
> transient_rowsets.push_back(rowset);
> } else {
> break;
> }
> }
> ```
>
> So, by your design. The
`config::cumulative_compaction_skip_window_seconds` need very large?
> If config::cumulative_compaction_skip_window_seconds is 30s, and the query
time is 60s, we still get
> 230 error?
No need. After upgrade, if you leave the
`cumulative_compaction_skip_window_seconds` unchanged(default 30 sec), the
behavior of cumu compaction is just same as origin(And even better because it
try to avoid merging "not-read-yet" version).
And if you set `cumulative_compaction_skip_window_seconds` to a large
value(eg, 5 minute), the behavior depends on:
1. If query frequency is reasonable(eg, at least once per minute), then this
config has no effect in most cases.
2. If query frequency is low(eg, once per 10 minutes), then the compaction
will do every 5 minutes, which act same as the origin.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
