decster commented on a change in pull request #3734:
URL: https://github.com/apache/incubator-doris/pull/3734#discussion_r433654154
##
File path: be/src/olap/memory/mem_tablet_scan.h
##
@@ -0,0 +1,82 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
decster commented on a change in pull request #3734:
URL: https://github.com/apache/incubator-doris/pull/3734#discussion_r433653854
##
File path: be/src/olap/base_tablet.cpp
##
@@ -44,11 +43,13 @@ OLAPStatus BaseTablet::set_tablet_state(TabletState state) {
}
void BaseTable
caiconghui edited a comment on pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#issuecomment-637308718
> @caiconghui Hi, If you only change the webserver_num_workers from 5 to 48,
how many times stream load performance will improve?
@kangkaisen
if every st
caiconghui commented on pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#issuecomment-637308718
> @caiconghui Hi, If you only change the webserver_num_workers from 5 to 48,
how many times stream load performance will improve?
@kangkaisen
if every stream lo
yangzhg commented on pull request #3745:
URL: https://github.com/apache/incubator-doris/pull/3745#issuecomment-637267051
> Better to update the doc here:
> `administrator-guide/operation/tablet-repair-and-balance.md`
done
--
chaoyli commented on a change in pull request #3734:
URL: https://github.com/apache/incubator-doris/pull/3734#discussion_r433597310
##
File path: be/src/olap/memory/mem_tablet_scan.h
##
@@ -0,0 +1,82 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
kangkaisen merged pull request #3722:
URL: https://github.com/apache/incubator-doris/pull/3722
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
kangkaisen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 761a0cc [Bug] Fix bug that running
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433591664
##
File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java
##
@@ -109,7 +109,7 @@
// if true, need report to coordinator when
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433591288
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetail.java
##
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) unde
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433589126
##
File path: fe/src/main/java/org/apache/doris/qe/ConnectProcessor.java
##
@@ -126,6 +129,11 @@ private void auditAfterExec(String origStmt, Stat
chaoyli commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433589126
##
File path: fe/src/main/java/org/apache/doris/qe/ConnectProcessor.java
##
@@ -126,6 +129,11 @@ private void auditAfterExec(String origStmt, Stat
HangyuanLiu commented on issue #3740:
URL:
https://github.com/apache/incubator-doris/issues/3740#issuecomment-637223922
We are gradually improving the documentation. The detailed config is
commented and explained in the config.cpp/Config.java
If you have a certain configuration explana
marising commented on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-637211321
> > 2. The table of customer
> > alter table add column xxx double key null after xxx,but no error
message and execute success!
>
> @marising
> Should creat
wyb commented on a change in pull request #3716:
URL: https://github.com/apache/incubator-doris/pull/3716#discussion_r433352697
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/SparkEtlJobHandler.java
##
@@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundatio
wyb commented on a change in pull request #3716:
URL: https://github.com/apache/incubator-doris/pull/3716#discussion_r433351923
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/SparkEtlJobHandler.java
##
@@ -0,0 +1,170 @@
+// Licensed to the Apache Software Foundatio
wyb commented on a change in pull request #3716:
URL: https://github.com/apache/incubator-doris/pull/3716#discussion_r433350943
##
File path: fe/src/main/java/org/apache/doris/common/Pair.java
##
@@ -25,7 +27,9 @@
public class Pair {
public static PairComparator> PAIR_VAL
acelyc111 commented on pull request #3691:
URL: https://github.com/apache/incubator-doris/pull/3691#issuecomment-636962937
> This CL LGTM.
>
> But I have reservations about changing some functions that originally
returned `Status` to `Void`.
> Although these functions currently ha
wyb commented on a change in pull request #3715:
URL: https://github.com/apache/incubator-doris/pull/3715#discussion_r433322836
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java
##
@@ -0,0 +1,249 @@
+// Licensed to the Apache Software Foundation (ASF
kangkaisen commented on a change in pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742#discussion_r433316888
##
File path: be/src/olap/push_handler.cpp
##
@@ -761,6 +915,126 @@ OLAPStatus LzoBinaryReader::_next_block() {
return res;
}
+OLAPStatus
wyb commented on a change in pull request #3715:
URL: https://github.com/apache/incubator-doris/pull/3715#discussion_r433313450
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java
##
@@ -0,0 +1,249 @@
+// Licensed to the Apache Software Foundation (ASF
kangkaisen commented on a change in pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742#discussion_r433312209
##
File path: be/src/olap/push_handler.cpp
##
@@ -761,6 +915,126 @@ OLAPStatus LzoBinaryReader::_next_block() {
return res;
}
+OLAPStatus
kangkaisen commented on a change in pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742#discussion_r433312577
##
File path: be/src/olap/push_handler.cpp
##
@@ -761,6 +915,126 @@ OLAPStatus LzoBinaryReader::_next_block() {
return res;
}
+OLAPStatus
kangkaisen commented on a change in pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742#discussion_r433311525
##
File path: be/src/olap/push_handler.cpp
##
@@ -761,6 +915,126 @@ OLAPStatus LzoBinaryReader::_next_block() {
return res;
}
+OLAPStatus
wyb commented on a change in pull request #3715:
URL: https://github.com/apache/incubator-doris/pull/3715#discussion_r433309138
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/BulkLoadJob.java
##
@@ -0,0 +1,328 @@
+// Licensed to the Apache Software Foundation (ASF)
kangkaisen commented on a change in pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742#discussion_r433307314
##
File path: be/src/olap/push_handler.h
##
@@ -209,6 +216,44 @@ class LzoBinaryReader: public IBinaryReader {
size_t _next_row_start;
};
marising edited a comment on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636912790
Aggregate Key, not Duplicate Key @morningman
CREATE TABLE `xxx_sku_AB` (
..
`price` double NULL COMMENT "",
..
) ENGINE=OLAP
...
marising commented on a change in pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#discussion_r433302450
##
File path: be/src/olap/row.h
##
@@ -59,6 +59,10 @@ bool equal_row(const std::vector& ids,
template
int compare_row(const LhsRowType& lhs, co
morningman commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433294323
##
File path: fe/src/main/java/org/apache/doris/http/rest/ProfileAction.java
##
@@ -0,0 +1,56 @@
+// Licensed to the Apache Software Foundation
This is an automated email from the ASF dual-hosted git repository.
zhaoc pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from ee260d5 [Bug][FsBroker] NPE throw when username is empty (#3731)
add fdf66b8 [MemTracker] add log dept
kangkaisen commented on a change in pull request #3741:
URL: https://github.com/apache/incubator-doris/pull/3741#discussion_r433296327
##
File path: be/src/util/auto_deallocator.h
##
@@ -0,0 +1,76 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
imay merged pull request #3701:
URL: https://github.com/apache/incubator-doris/pull/3701
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
imay commented on a change in pull request #3712:
URL: https://github.com/apache/incubator-doris/pull/3712#discussion_r433290378
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/etl/EtlJobConfig.java
##
@@ -0,0 +1,548 @@
+// Licensed to the Apache Software Foundation
kangkaisen commented on a change in pull request #3741:
URL: https://github.com/apache/incubator-doris/pull/3741#discussion_r433291742
##
File path: be/src/service/doris_main.cpp
##
@@ -136,6 +136,25 @@ int main(int argc, char** argv) {
LOG(FATAL) << "parse config stor
marising edited a comment on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636912790
Aggregate Key, not Duplicate Key
CREATE TABLE `xxx_sku_AB` (
..
`price` double NULL COMMENT "",
..
) ENGINE=OLAP
...
AGGREGATE K
marising commented on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636912790
CREATE TABLE `xxx_sku_AB` (
..
`price` double NULL COMMENT "",
..
) ENGINE=OLAP
...
AGGREGATE KEY(..., `price`, ...)
...
kangkaisen commented on pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#issuecomment-636907661
@chaoyli Hi, you should add the doc for new http api.
This is an automated message from the Apache Gi
imay commented on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636907424
@morningman I'm not sure about it either. However I think it is OK to make
double/float column as a sort key.
-
kangkaisen commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433284738
##
File path: fe/src/main/java/org/apache/doris/http/rest/ConnectionAction.java
##
@@ -0,0 +1,63 @@
+// Licensed to the Apache Software Foundat
morningman commented on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636906110
> 2\. The table of customer
> alter table add column xxx double key null after xxx,but no error
message and execute success!
I guess the table `customer`
kangkaisen commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433283472
##
File path: fe/src/main/java/org/apache/doris/http/rest/ConnectionAction.java
##
@@ -0,0 +1,63 @@
+// Licensed to the Apache Software Foundat
imay commented on a change in pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#discussion_r433283161
##
File path: be/src/olap/row.h
##
@@ -59,6 +59,10 @@ bool equal_row(const std::vector& ids,
template
int compare_row(const LhsRowType& lhs, const
kangkaisen commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433282652
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetail.java
##
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) u
kangkaisen commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433281766
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (AS
kangkaisen commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433281258
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (AS
kangkaisen commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433280630
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (AS
xy720 commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433261194
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) un
xy720 commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433261194
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) un
xy720 commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433261194
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) un
imay commented on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636901913
> 2\. The table of customer
> alter table add column xxx double key null after xxx,but no error
message and execute success!
@marising
Should create an iss
xy720 commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433261194
##
File path: fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software Foundation (ASF) un
xy720 commented on a change in pull request #3744:
URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433259804
##
File path: fe/src/main/java/org/apache/doris/qe/ConnectProcessor.java
##
@@ -126,6 +129,11 @@ private void auditAfterExec(String origStmt, Statem
morningman commented on a change in pull request #3712:
URL: https://github.com/apache/incubator-doris/pull/3712#discussion_r433256290
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/etl/EtlJobConfig.java
##
@@ -0,0 +1,548 @@
+// Licensed to the Apache Software Foun
morningman commented on a change in pull request #3741:
URL: https://github.com/apache/incubator-doris/pull/3741#discussion_r433252027
##
File path: be/src/olap/utils.cpp
##
@@ -973,6 +979,108 @@ OLAPStatus copy_file(const string& src, const string&
dest) {
return r
marising edited a comment on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636877119
It's very confusing for me,doris does not support the key column as double
or float,but I've met twice.
1. I test alter table add double key column
MyS
marising commented on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636877119
It's very confusing for me,doris does not support the key column as double
or float,but I've met twice.
1. I create table and alter table add column
MySQL [ch
spaces-X commented on pull request #3741:
URL: https://github.com/apache/incubator-doris/pull/3741#issuecomment-636865723
> Hi @spaces-X, Could you create an issue to describe what problem you try
to solve?
Done [issue](https://github.com/apache/incubator-doris/issues/3746)
--
spaces-X opened a new issue #3746:
URL: https://github.com/apache/incubator-doris/issues/3746
**Describe the bug**
When BE starts up, it will check data paths in storage_data_path to make
sure they are actually existed.
In some situations, the data path is existed but for some reason
yangzhg opened a new pull request #3745:
URL: https://github.com/apache/incubator-doris/pull/3745
Add a link of meta data to doris web server's tablet to access BE's HTTP
interface to obtain the corresponding Tablet Meta information

add ee260d5 [Bug][FsBroker
morningman closed issue #3730:
URL: https://github.com/apache/incubator-doris/issues/3730
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
morningman commented on pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#issuecomment-636848312
This CL looks good to me.
But I had a question in your issue: #3735, that why key columns include
float or double.
We don't support using float or double column
morningman commented on issue #3737:
URL:
https://github.com/apache/incubator-doris/issues/3737#issuecomment-636847147
We've already adapted to the higher version.PR #3262
And we may release it when 0.13 is released
This
xy720 commented on issue #3433:
URL:
https://github.com/apache/incubator-doris/issues/3433#issuecomment-636846173
**Be handle push task**
#3742 [Spark load][Be 1/1] Be handle push task
This is an automated message from th
morningman commented on pull request #3741:
URL: https://github.com/apache/incubator-doris/pull/3741#issuecomment-636845240
Hi @spaces-X, Could you create an issue to describe what problem you try to
solve?
This is an automa
kangkaisen commented on issue #3743:
URL:
https://github.com/apache/incubator-doris/issues/3743#issuecomment-636824747
Good job!
I think change the lock to table level is reasonable and necessary. Looking
forward to your PR.
caiconghui opened a new issue #3743:
URL: https://github.com/apache/incubator-doris/issues/3743
Now, Doris still get bad performance for High concurrency stream load, and I
add some metric to trace the some bottleneck for issue #3696, and modify some
be config to make it a litte better. Ho
xy720 opened a new pull request #3742:
URL: https://github.com/apache/incubator-doris/pull/3742
1、Add a PushBrokerReader in push_handle.cpp.
2、PushBrokerReader wraps the ParquetScanner to support reading data from
parquet format file through broker.
wyb commented on a change in pull request #3715:
URL: https://github.com/apache/incubator-doris/pull/3715#discussion_r433181187
##
File path: fe/src/main/java/org/apache/doris/load/loadv2/SparkLoadJob.java
##
@@ -0,0 +1,249 @@
+// Licensed to the Apache Software Foundation (ASF
spaces-X opened a new pull request #3741:
URL: https://github.com/apache/incubator-doris/pull/3741
Ignore **broken disks** from storage_root_path:
- add read and write check for each dir in storage_root_path and ignore
broken disks.
- add AutoDeallocator.h to manage the lifecycle
morningman merged pull request #3718:
URL: https://github.com/apache/incubator-doris/pull/3718
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 8e71c07 [Spark load][Fe 2/5] Updat
hxianshun opened a new issue #3740:
URL: https://github.com/apache/incubator-doris/issues/3740
https://github.com/apache/incubator-doris/blob/master/docs/zh-CN/administrator-guide/config/be_config.md
In this page, most of configurations have no instructions. Users can't know
what th
HangyuanLiu opened a new pull request #3739:
URL: https://github.com/apache/incubator-doris/pull/3739
Just For review [#3344]
Support materialized view schema change history data
This is an automated message from the A
hxianshun commented on issue #3529:
URL:
https://github.com/apache/incubator-doris/issues/3529#issuecomment-636684033

 of double/float type is NULL
acelyc111 closed issue #3687:
URL: https://github.com/apache/incubator-doris/issues/3687
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
vagetablechicken opened a new issue #3737:
URL: https://github.com/apache/incubator-doris/issues/3737
**Describe the bug**
We get a coredump file.
```
Program terminated with signal 6, Aborted.
#0 0x7f6868de11d7 in raise () from /lib64/libc.so.6
Missing separate debuginfo
81 matches
Mail list logo