marising commented on a change in pull request #3738:
URL: https://github.com/apache/incubator-doris/pull/3738#discussion_r433302450
##########
File path: be/src/olap/row.h
##########
@@ -59,6 +59,10 @@ bool equal_row(const std::vector<uint32_t>& ids,
template<typename LhsRowType, typename RhsRowType>
int compare_row(const LhsRowType& lhs, const RhsRowType& rhs) {
for (uint32_t cid = 0; cid < lhs.schema()->num_key_columns(); ++cid) {
+ //because the num_column_ids include the column of double/float type
Review comment:
Ignore the column of double/float type in engine_checksum_task.cpp, but
num_key_columns include the double/float column index.
In other ways, I can only add related functions such as reader.init, compare
function for sort and aggregation function for checksum. The code volume is a
little large.
```
// ignore float and double type considering to precision lose
for (size_t i = 0; i < tablet->tablet_schema().num_columns(); ++i) {
FieldType type = tablet->tablet_schema().column(i).type();
if (type == OLAP_FIELD_TYPE_FLOAT || type == OLAP_FIELD_TYPE_DOUBLE)
{
continue;
}
reader_params.return_columns.push_back(i);
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
