kangkaisen commented on a change in pull request #3744: URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433284738
########## File path: fe/src/main/java/org/apache/doris/http/rest/ConnectionAction.java ########## @@ -0,0 +1,63 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.http.rest; + +import io.netty.handler.codec.http.HttpMethod; +import io.netty.handler.codec.http.HttpResponseStatus; +import org.apache.doris.common.util.DebugUtil; +import org.apache.doris.http.ActionController; +import org.apache.doris.http.BaseRequest; +import org.apache.doris.http.BaseResponse; +import org.apache.doris.http.IllegalArgException; +import org.apache.doris.qe.ConnectContext; +import org.apache.doris.service.ExecuteEnv; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +// This class is used to get current query_id of connection_id. +// Every connection holds at most one query at every point. +// Some we can get query_id firstly, and get query by query_id. +public class ConnectionAction extends RestBaseAction { + public ConnectionAction(ActionController controller) { + super(controller); + } + + public static void registerAction (ActionController controller) throws IllegalArgException { + controller.registerHandler(HttpMethod.GET, "/connection", new ConnectionAction(controller)); + } + + @Override + public void execute(BaseRequest request, BaseResponse response) { + String connStr = request.getSingleParameter("connection_id"); + if (connStr == null) { + response.getContent().append("not valid parameter"); + sendResult(request, response, HttpResponseStatus.BAD_REQUEST); + return; + } + long connectionId = Long.valueOf(connStr.trim()); + ConnectContext context = ExecuteEnv.getInstance().getScheduler().getContext(connectionId); + if (context == null || context.queryId() == null) { + response.getContent().append("connection id " + connectionId + " not found."); + sendResult(request, response, HttpResponseStatus.NOT_FOUND); + return; + } + String queryId = DebugUtil.printId(context.queryId()); + response.getContent().append(queryId); + sendResult(request, response); Review comment: prefer response by json ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
