kangkaisen commented on a change in pull request #3744: URL: https://github.com/apache/incubator-doris/pull/3744#discussion_r433282652
########## File path: fe/src/main/java/org/apache/doris/qe/QueryDetail.java ########## @@ -0,0 +1,114 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.qe; + +public class QueryDetail { + public enum QueryMemState { + RUNNING, + FINISHED, + FAILED, + CANCELLED + }; + + // When query received, FE will construct a QueryDtail + // object. This object will set queryId, startTime, sql + // fields. As well state is be set as RUNNING. + // After query finished, endTime and latency will + // be set and state will be updated to be FINISHED/FAILED/CANCELLED + // according to the query execution results. + // So, one query will be inserted into as a item and + // be udpated upon finished. To indicate the two event, + // a extra field named eventTime is added. + private long eventTime; Review comment: I still don't understand what's the meaning of eventTime? and why do we need it? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
