[GitHub] [incubator-doris] morningman commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
morningman commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422453405 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #3424: allow delete duplicated non-key column using delete from

2020-05-08 Thread GitBox
kangpinghuang commented on a change in pull request #3424: URL: https://github.com/apache/incubator-doris/pull/3424#discussion_r422450785 ## File path: be/src/olap/olap_cond.cpp ## @@ -637,7 +637,7 @@ bool Conditions::delete_conditions_eval(const RowCursor& row) const { }

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #3513: [Doris On ES]fix bug of query failed in doc_value_mode when fields have none value

2020-05-08 Thread GitBox
wuyunfeng commented on a change in pull request #3513: URL: https://github.com/apache/incubator-doris/pull/3513#discussion_r422451684 ## File path: be/src/exec/es/es_scroll_parser.h ## @@ -50,5 +50,7 @@ class ScrollParser { rapidjson::Document _document_node; rapidj

[GitHub] [incubator-doris] wangbo commented on issue #3433: [Spark load] Doris support Spark load

2020-05-08 Thread GitBox
wangbo commented on issue #3433: URL: https://github.com/apache/incubator-doris/issues/3433#issuecomment-626104019 **Count Distinct Module** #3319 Support Java Verision HyperLogLog(REVIEWING) #3061 Doris Support Using Hive Table to Build Global Dict(TESTING) #3088 Support Java vers

[GitHub] [incubator-doris] vagetablechicken commented on issue #3416: Replace the thread pool in FragmentMgr

2020-05-08 Thread GitBox
vagetablechicken commented on issue #3416: URL: https://github.com/apache/incubator-doris/issues/3416#issuecomment-626102191 ### Step 1 One FragmentExecState obj called exec_state. After exec_state inited and prepared, we try to put it in threadpool to execute. If threadpool is fu

[GitHub] [incubator-doris] vagetablechicken opened a new pull request #3533: Add -Werror when gcc<=7.3.0 & udf fix

2020-05-08 Thread GitBox
vagetablechicken opened a new pull request #3533: URL: https://github.com/apache/incubator-doris/pull/3533 ref https://github.com/apache/incubator-doris/issues/3507 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] vagetablechicken commented on issue #3507: Compile warnings should be errors

2020-05-08 Thread GitBox
vagetablechicken commented on issue #3507: URL: https://github.com/apache/incubator-doris/issues/3507#issuecomment-626099485 About the warning of udf: ``` In member function 'const char* doris_udf::FunctionContext::user() const': cc1plus: warning: function may return address of loc

[GitHub] [incubator-doris] WingsGo commented on pull request #3527: [SQL]When compare StringLiteral and Numerical, cast them to Numerical type

2020-05-08 Thread GitBox
WingsGo commented on pull request #3527: URL: https://github.com/apache/incubator-doris/pull/3527#issuecomment-626099088 > Add unit test for this CL. Done This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #3495: [ASAN] Fix some address problems detected by ASAN

2020-05-08 Thread GitBox
acelyc111 commented on a change in pull request #3495: URL: https://github.com/apache/incubator-doris/pull/3495#discussion_r422447817 ## File path: be/src/util/path_util.cpp ## @@ -70,13 +70,19 @@ vector split_path(const string& path) { return segments; } +struct FreeDe

[GitHub] [incubator-doris] gaodayue commented on pull request #3488: [Config] allow user to config BRPC socket_max_unwritten_bytes

2020-05-08 Thread GitBox
gaodayue commented on pull request #3488: URL: https://github.com/apache/incubator-doris/pull/3488#issuecomment-626095465 Hi @morningman do you have any more comments? In addition, I can't see why NewDorisTest failed, but I think it's unrelated to this PR, could you help confirm that? --

[incubator-doris] branch master updated: [Bug] Fix BE crash when input to hll_merge is null (#3521)

2020-05-08 Thread gaodayue
This is an automated email from the ASF dual-hosted git repository. gaodayue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new b62b310 [Bug] Fix BE crash when inpu

[GitHub] [incubator-doris] decster opened a new pull request #3532: Remove unused ColumnType

2020-05-08 Thread GitBox
decster opened a new pull request #3532: URL: https://github.com/apache/incubator-doris/pull/3532 The enum doris::ColumnType is not used anymore, and it causes confusion with doris::memory::ColumnType. This CL remove ColumnType and some unused test cases. --

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #3424: allow delete duplicated non-key column using delete from

2020-05-08 Thread GitBox
yangzhg commented on a change in pull request #3424: URL: https://github.com/apache/incubator-doris/pull/3424#discussion_r422442539 ## File path: be/src/olap/rowset/column_data.cpp ## @@ -509,7 +510,10 @@ int ColumnData::delete_pruning_filter() { return DEL_NOT_SATISFI

[GitHub] [incubator-doris] chaoyli commented on issue #3517: [Proposal] Get the hot spot of the doris cluster.

2020-05-08 Thread GitBox
chaoyli commented on issue #3517: URL: https://github.com/apache/incubator-doris/issues/3517#issuecomment-626088176 > This is a good job. > However I think something maybe discussed clearly before writing code. > > 1. Who will update this metrics? > 2. How will updater get the

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-08 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422438126 ## File path: be/src/olap/memory/CMakeLists.txt ## @@ -22,6 +22,12 @@ set(LIBRARY_OUTPUT_PATH "${BUILD_DIR}/src/olap/memory") set(EXECUTABLE_OUTP

[GitHub] [incubator-doris] decster commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-08 Thread GitBox
decster commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r422438098 ## File path: be/src/olap/memory/buffer.h ## @@ -0,0 +1,61 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [incubator-doris] imay commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422436653 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +--- + + +

[GitHub] [incubator-doris] imay commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422436108 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +--- + + +

[incubator-doris-website] 40/40: Merge pull request #3 from hffariel/reset_master_branch

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 2c2493d2beb49279f77ab7f7d70f7bbe7f35e039 Merge: c747f58 0ec31c9 Author: Zhao Chun AuthorDate: Sat May 9

[incubator-doris-website] 34/40: Add release process

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 7f2be2311a404de40a0f484e183ecf0bb0c77e42 Author: lide AuthorDate: Tue Mar 12 10:51:19 2019 +0800 Ad

[incubator-doris-website] 10/40: updated downloads file

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 7002a90d76bdf1c2296310c758f4d518cdd0689e Author: lide AuthorDate: Fri Oct 26 17:04:36 2018 +0800 up

[incubator-doris-website] 26/40: Update doris logos under menu

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit c7f8930cb44fa9d1abe3e2883161944f671b3a13 Author: lide AuthorDate: Mon Nov 12 13:34:05 2018 +0800 Up

[incubator-doris-website] 09/40: change README.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 6924c51113a252181fbdfdb885570e305a236703 Author: lide AuthorDate: Wed Oct 24 17:55:04 2018 +0800 ch

[incubator-doris-website] 13/40: Update 0.8.2.1 release download package

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 1ad9efff7b984e7e116f8f2b0954f8203e368d7b Author: lide AuthorDate: Sat Oct 27 17:11:20 2018 +0800 Up

[incubator-doris-website] 18/40: update contributing.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 390e97640c916c08a8eb39a1e3165e6b7d2f28ff Author: lide AuthorDate: Thu Nov 1 13:35:55 2018 +0800 upd

[incubator-doris-website] 39/40: change some spelling

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 0ec31c91b1ad84007035ba2d1a18d4a30fcd2081 Author: fariel AuthorDate: Fri May 8 17:08:31 2020 +0800 c

[incubator-doris-website] 21/40: fix an error of title

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit c5ddfd6a9da19971140a20c700f63817737059ae Author: lide AuthorDate: Wed Nov 7 16:39:05 2018 +0800 fix

[incubator-doris-website] 04/40: restore bake.sh

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 902e7460345c8883e7b2cf2343e7a7b480b5892e Author: lide AuthorDate: Sat Sep 29 12:37:15 2018 +0800 re

[incubator-doris-website] branch master updated (c747f58 -> 2c2493d)

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git. from c747f58 Update doris logo new 6bbfd91 reset master branch new 8d2758f update README.md

[incubator-doris-website] 22/40: add how-to-write commit message

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 0d6845777844f55e4c24ae305b13fd117f7d05e4 Author: lide AuthorDate: Fri Nov 9 15:28:34 2018 +0800 add

[incubator-doris-website] 08/40: change architecute from png to jpg

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit b5a1a0043baf990e28634f87a977cf0f8aa1fe8e Author: lide AuthorDate: Wed Oct 24 15:02:41 2018 +0800 ch

[incubator-doris-website] 30/40: Remove the download page of non-apache release

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 7ee232c9e6663eec171592ef0095763ac0223030 Author: lide AuthorDate: Thu Jan 31 12:26:14 2019 +0800 Re

[incubator-doris-website] 35/40: Improve release process

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 86b5d9dec24602956b194182fa0ecafdeda8ee09 Author: lide AuthorDate: Tue Mar 12 11:11:26 2019 +0800 Im

[incubator-doris-website] 20/40: add how-to-add wechat to contributing.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit a9e81c2493a9f9d23f4a227a35e556ce58add465 Author: lide AuthorDate: Wed Nov 7 16:24:56 2018 +0800 add

[incubator-doris-website] 29/40: Remove non-apache release version informaiton

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 4a123c88d8b0319f2ccc4b1ad1a07307e0f42827 Author: lide AuthorDate: Thu Jan 31 10:56:41 2019 +0800 Re

[incubator-doris-website] 32/40: Release 0.9.0 in Download page

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit b395f998bae1548e81c09e26811460bff55e2ffa Author: lide AuthorDate: Mon Feb 18 15:19:02 2019 +0800 Re

[incubator-doris-website] 36/40: Update doris logo

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit c747f58d1df7513f67596426b1725545bc1fc984 Author: lide AuthorDate: Mon May 13 14:47:48 2019 +0800 Up

[incubator-doris-website] 11/40: test

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 48ef4c9bea53b89a4a1c3bdf1126316dc2c21bb5 Author: lide AuthorDate: Fri Oct 26 17:15:52 2018 +0800 te

[incubator-doris-website] 16/40: update Community by add the link of contributing.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 18bdb4c96b40c4e6a5904742c861027ecdfe2b92 Author: lide AuthorDate: Thu Nov 1 10:36:25 2018 +0800 upd

[incubator-doris-website] 24/40: update how-to-write commit message

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 72c81f7c9e6d46c9bbcafe89756cbe88825021a8 Author: lide AuthorDate: Fri Nov 9 15:53:02 2018 +0800 upd

[incubator-doris-website] 33/40: Correct link issues in downloads page

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 7dafbb12541dbc6cf6b09068209655d81e5484b5 Author: lide AuthorDate: Thu Feb 21 17:23:01 2019 +0800 Co

[incubator-doris-website] 28/40: Add pmc.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 1f92a9c15a916c79c3a2e7f78859c5088a62a971 Author: lide AuthorDate: Wed Jan 23 13:44:20 2019 +0800 Ad

[incubator-doris-website] 38/40: update README.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 8d2758f2cdb61945751c396c26b1c975388236fe Author: fariel AuthorDate: Fri May 8 17:04:29 2020 +0800 u

[incubator-doris-website] 12/40: updated downloads.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 52d28af5058228e9ef64edb87ec8229960943488 Author: lide AuthorDate: Fri Oct 26 17:23:07 2018 +0800 up

[incubator-doris-website] 15/40: add contributing.md to Documents

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 2ab825daf8257f2452887f42fef0fd98edd36ca4 Author: lide AuthorDate: Thu Nov 1 10:24:40 2018 +0800 add

[incubator-doris-website] 17/40: update contributing.md

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 15d5e9ab37a2bbe52dd161e7f24320f8e6f3b5da Author: lide AuthorDate: Thu Nov 1 13:22:27 2018 +0800 upd

[incubator-doris-website] 25/40: Add doris log to menu

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit eb6cfb6ac828e0fc4ab2ac87d02ee044b6c01b0e Author: lide AuthorDate: Mon Nov 12 11:10:22 2018 +0800 Ad

[incubator-doris-website] 27/40: Add github logo and repo link

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit d61f879c1159fa712042181f35c3437aaec4a364 Author: lide AuthorDate: Mon Nov 12 19:32:37 2018 +0800 Ad

[incubator-doris-website] 02/40: fixed build error

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit d9f1f4b237dea873efed2a0fc9173ce4be355669 Author: lide AuthorDate: Wed Sep 26 16:43:06 2018 +0800 fi

[incubator-doris-website] 23/40: update how-to-write commit message

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 2d020b19f6ec216f03a7c176e7c1d6581d8aae2e Author: lide AuthorDate: Fri Nov 9 15:43:48 2018 +0800 upd

[incubator-doris-website] 31/40: Release 0.9.0 in Download page

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit 1336ed82cb1c4cfebeeb6f1bc67c9679c02de760 Author: lide AuthorDate: Mon Feb 18 15:09:43 2019 +0800 Re

[incubator-doris-website] 14/40: rollback the release of 0.8.2.1, it not a right way to release a version in apache way

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris-website.git commit f5bbb078b2ac6bec8baa1e207afc93689e19a123 Author: lide AuthorDate: Sat Oct 27 17:41:09 2018 +0800 ro

[incubator-doris] branch master updated: [ut] disable backgrounp scan context gc to speed up unit test (#3524)

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new e2c3c84 [ut] disable backgrounp scan co

[incubator-doris] branch master updated: Support append_trailing_char_if_absent function (#3439)

2020-05-08 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new a656a7d Support append_trailing_char_if

[GitHub] [incubator-doris] imay commented on pull request #3322: Remove redundant com.baidu:jprotobuf

2020-05-08 Thread GitBox
imay commented on pull request #3322: URL: https://github.com/apache/incubator-doris/pull/3322#issuecomment-625884442 @liutang123 What's your test result? Does it work fine after applying your PR? This is an automated mes

[GitHub] [incubator-doris] imay commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422193795 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +--- + + +

[GitHub] [incubator-doris] morningman commented on a change in pull request #3508: [Memory Engine] add core column related classes

2020-05-08 Thread GitBox
morningman commented on a change in pull request #3508: URL: https://github.com/apache/incubator-doris/pull/3508#discussion_r421895904 ## File path: be/src/olap/memory/CMakeLists.txt ## @@ -22,6 +22,12 @@ set(LIBRARY_OUTPUT_PATH "${BUILD_DIR}/src/olap/memory") set(EXECUTABLE_O

[GitHub] [incubator-doris] morningman commented on pull request #3439: Support append_trailing_char_if_absent function

2020-05-08 Thread GitBox
morningman commented on pull request #3439: URL: https://github.com/apache/incubator-doris/pull/3439#issuecomment-625851825 UT passed. LGTM This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
morningman commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422185761 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #3495: [ASAN] Fix some address problems detected by ASAN

2020-05-08 Thread GitBox
acelyc111 commented on a change in pull request #3495: URL: https://github.com/apache/incubator-doris/pull/3495#discussion_r422183638 ## File path: be/src/util/path_util.cpp ## @@ -70,13 +70,19 @@ vector split_path(const string& path) { return segments; } +struct FreeDe

[GitHub] [incubator-doris] morningman commented on a change in pull request #3531: Remove unreasonable DCHECK for mem_tracker

2020-05-08 Thread GitBox
morningman commented on a change in pull request #3531: URL: https://github.com/apache/incubator-doris/pull/3531#discussion_r422182323 ## File path: be/src/runtime/bufferpool/reservation_tracker.cc ## @@ -281,14 +281,11 @@ bool ReservationTracker::TransferReservationTo(Reserva

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3495: [ASAN] Fix some address problems detected by ASAN

2020-05-08 Thread GitBox
kangkaisen commented on a change in pull request #3495: URL: https://github.com/apache/incubator-doris/pull/3495#discussion_r422125426 ## File path: be/src/util/path_util.cpp ## @@ -70,13 +70,19 @@ vector split_path(const string& path) { return segments; } +struct FreeD

[GitHub] [incubator-doris] imay commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422117696 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +--- + + +

[GitHub] [incubator-doris] imay commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422116217 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +--- + + +

[GitHub] [incubator-doris] imay commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422115945 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +--- + + +

[GitHub] [incubator-doris] imay commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422115103 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +--- + + +

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
EmmyMiao87 commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422112754 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #3522: [community] Add Committer Guide

2020-05-08 Thread GitBox
kangkaisen commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422105472 ## File path: docs/zh-CN/community/committer-guide.md ## @@ -0,0 +1,91 @@ +--- +{ +"title": "Committer指南", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] kangkaisen opened a new pull request #3531: Remove unreasonable DCHECK for mem_tracker

2020-05-08 Thread GitBox
kangkaisen opened a new pull request #3531: URL: https://github.com/apache/incubator-doris/pull/3531 For #3530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] kangkaisen opened a new issue #3530: Group by query will core in Debug mode BE

2020-05-08 Thread GitBox
kangkaisen opened a new issue #3530: URL: https://github.com/apache/incubator-doris/issues/3530 **Describe the bug** Run any group by query in Debug mode BE ``` F0508 18:39:32.956269 32493 reservation_tracker.cc:286] Check failed: tracker->mem_tracker_ == nullptr || !tracker->mem_t

[GitHub] [incubator-doris] morningman opened a new issue #3529: [Bug] BE crash in brpc

2020-05-08 Thread GitBox
morningman opened a new issue #3529: URL: https://github.com/apache/incubator-doris/issues/3529 **Describe the bug** ``` (gdb) where #0 bthread::id_create_impl (id=id@entry=0x7f724e708ac0, data=data@entry=0x8918c788, on_error=on_error@entry=0x0, on_error2=on_error2@entry=0x

[GitHub] [incubator-doris] WingsGo commented on pull request #3527: [SQL]When compare StringLiteral and Numerical, cast them to Numerical type

2020-05-08 Thread GitBox
WingsGo commented on pull request #3527: URL: https://github.com/apache/incubator-doris/pull/3527#issuecomment-625764918 > @WingsGo > You should create a separated issue to track this problem. And you should explain in what way you want to change fix it. > Because this CL will influen

[GitHub] [incubator-doris] WingsGo opened a new issue #3528: [Proposal]Convert both type to numerical when compare StringLiteral nad Numerical Type

2020-05-08 Thread GitBox
WingsGo opened a new issue #3528: URL: https://github.com/apache/incubator-doris/issues/3528 # Background When we compare string and number in Doris, it may cause some problem: 1. Cause full table scan, in extreme cases, it will make doris cannot work. For example: if our sq

[GitHub] [incubator-doris] imay commented on issue #3517: [Proposal] Get the hot spot of the doris cluster.

2020-05-08 Thread GitBox
imay commented on issue #3517: URL: https://github.com/apache/incubator-doris/issues/3517#issuecomment-625760711 This is a good job. However I think something maybe discussed clearly before writing code. 1. Who will update this metrics? 2. How will updater get the table id? 3. H

[GitHub] [incubator-doris] HappenLee commented on issue #3438: [Proposal] Vectorization query optimization for Doris

2020-05-08 Thread GitBox
HappenLee commented on issue #3438: URL: https://github.com/apache/incubator-doris/issues/3438#issuecomment-625759402 ### About the POC At present, only aggregatenode has been verified . * 1. First, we do tuple convert columnVector and **time consuming of conversion operation is

[GitHub] [incubator-doris] imay commented on pull request #3527: [SQL]When compare StringLiteral and Numerical, cast them to Numerical type

2020-05-08 Thread GitBox
imay commented on pull request #3527: URL: https://github.com/apache/incubator-doris/pull/3527#issuecomment-625750983 @WingsGo You should create a separated issue to track this problem. And you should explain in what way you want to change fix it. Because this CL will influence the b

[GitHub] [incubator-doris] WingsGo commented on pull request #3527: [SQL]When compare StringLiteral and Numerical, cast them to Numerical type

2020-05-08 Thread GitBox
WingsGo commented on pull request #3527: URL: https://github.com/apache/incubator-doris/pull/3527#issuecomment-625747668 For #3491 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] WingsGo opened a new pull request #3527: [SQL]When compare StringLiteral and Numerical, cast them to Numerical type

2020-05-08 Thread GitBox
WingsGo opened a new pull request #3527: URL: https://github.com/apache/incubator-doris/pull/3527 When compare StringLiteral and Numerical type, Doris will convert them both to Double Type, which will lead some unexpected behavior. For example: `select 2882303761517473127 = "28823037615174

[GitHub] [incubator-doris] codeofdave opened a new issue #3526: aarch64上编译不通过

2020-05-08 Thread GitBox
codeofdave opened a new issue #3526: URL: https://github.com/apache/incubator-doris/issues/3526 编译brpc时报错 /home/incubator-doris/thirdparty/src/incubator-brpc-0.9.5/src/bthread/context.h:69:1: error: expected initializer before ‘bthread_jump_fcontext’ bthread_jump_fcontext(bthread_fc

[GitHub] [incubator-doris] wkhapy123 opened a new issue #3525: help .how could docker be not kill by system

2020-05-08 Thread GitBox
wkhapy123 opened a new issue #3525: URL: https://github.com/apache/incubator-doris/issues/3525 now docker be was cgroup by docker-compose: mem_limit doris version:DORIS-0.11.38-release This is an automated

[GitHub] [incubator-doris] acelyc111 opened a new pull request #3524: [ut] disable backgrounp scan context gc to speed up unit test

2020-05-08 Thread GitBox
acelyc111 opened a new pull request #3524: URL: https://github.com/apache/incubator-doris/pull/3524 Each test case in ExternalScanContextMgrTest may cost 1 minitue which is too long, we'd better disable backgrounp scan context gc to speed up unit test. ---