morningman commented on a change in pull request #3531:
URL: https://github.com/apache/incubator-doris/pull/3531#discussion_r422182323
##########
File path: be/src/runtime/bufferpool/reservation_tracker.cc
##########
@@ -281,14 +281,11 @@ bool
ReservationTracker::TransferReservationTo(ReservationTracker* other, int64_
// so this is all atomic.
for (ReservationTracker* tracker : other_path_to_common) {
tracker->UpdateReservation(bytes);
- // We don't handle MemTrackers with limit in this function - this should
always
- // succeed.
- DCHECK(tracker->mem_tracker_ == nullptr ||
!tracker->mem_tracker_->has_limit());
Review comment:
I also found this bug when running in LSAN mode.
But the comment here is strange: `We don't handle MemTrackers with limit in
this function`.
And if it has limit, the following `DCHECK(success)` should be removed too?
And what if it return false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
