[incubator-doris] branch master updated: [ut] disable backgrounp scan context gc to speed up unit test (#3524)

[zhaoc]

This is an automated email from the ASF dual-hosted git repository.

zhaoc pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git


The following commit(s) were added to refs/heads/master by this push:
     new e2c3c84  [ut] disable backgrounp scan context gc to speed up unit test 
(#3524)
e2c3c84 is described below

commit e2c3c84e8de015e3c662d6192365a3d98c59c192
Author: Yingchun Lai <405403...@qq.com>
AuthorDate: Sat May 9 09:01:05 2020 +0800

    [ut] disable backgrounp scan context gc to speed up unit test (#3524)
    
    Each test case in ExternalScanContextMgrTest may cost 1 minitue
    which is too long, we'd better disable backgrounp scan context
    gc to speed up unit test.
---
 be/src/runtime/external_scan_context_mgr.cpp       | 2 ++
 be/test/runtime/external_scan_context_mgr_test.cpp | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/be/src/runtime/external_scan_context_mgr.cpp 
b/be/src/runtime/external_scan_context_mgr.cpp
index 2a456be..500dc0c 100644
--- a/be/src/runtime/external_scan_context_mgr.cpp
+++ b/be/src/runtime/external_scan_context_mgr.cpp
@@ -92,6 +92,7 @@ Status ExternalScanContextMgr::clear_scan_context(const 
std::string& context_id)
 }
 
 void ExternalScanContextMgr::gc_expired_context() {
+#ifndef BE_TEST
     while (!_is_stop) {
         
std::this_thread::sleep_for(std::chrono::seconds(doris::config::scan_context_gc_interval_min
 * 60));
         time_t current_time = time(NULL);
@@ -125,5 +126,6 @@ void ExternalScanContextMgr::gc_expired_context() {
             
_exec_env->result_queue_mgr()->cancel(expired_context->fragment_instance_id);
         }
     }
+#endif
 }
 }
diff --git a/be/test/runtime/external_scan_context_mgr_test.cpp 
b/be/test/runtime/external_scan_context_mgr_test.cpp
index 52d2790..73dc4fe 100644
--- a/be/test/runtime/external_scan_context_mgr_test.cpp
+++ b/be/test/runtime/external_scan_context_mgr_test.cpp
@@ -110,8 +110,6 @@ int main(int argc, char** argv) {
         return -1;
     }
 
-    doris::config::scan_context_gc_interval_min = 1;
-    // doris::init_glog("be-test");
     ::testing::InitGoogleTest(&argc, argv);
     doris::CpuInfo::init();
     return RUN_ALL_TESTS();


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org