imay commented on a change in pull request #3522: URL: https://github.com/apache/incubator-doris/pull/3522#discussion_r422436108
########## File path: docs/zh-CN/community/committer-guide.md ########## @@ -0,0 +1,91 @@ +--- +{ + "title": "Committer指南", + "language": "zh-CN" +} +--- + +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# Committer指南 + +## Committer新人指南 + +### 订阅公共邮件列表 + +请订阅{dev,commits}@doris.apache.org邮件列表,通过发送邮件到{dev,commits}-subscr...@doris.apache.org完成订阅. +commits邮件非常重要,因为所有的GitHub Issue,PR提交都会发往这个邮件列表. + +### 订阅private邮件列表 + +订阅priv...@doris.apache.org通过发送邮件到private-subscr...@doris.apache.org完成订阅. +这个订阅操作需要邮件列表的moderator进行审核才能订阅成功。 +如果你是PPMC的话, 可以通过通过[邮件列表订阅帮手](https://whimsy.apache.org/committers/subscribe)直接完成订阅 + +### 关联你的 ASF 账号与 Github 账号 + +我们用GitHub来管理我们的Issue以及用户贡献. +所以你需要把你的ASF账号与GitHub账号进行关联来获得[Doris仓库](https://github.com/apache/incubator-doris)的写入权限。 +通过在[Gitbox](https://gitbox.apache.org/setup/)完成操作后,你就可以对GitHub仓库中的Issue,PR进行管理 + +## Code Review指南 + +1. 始终保持一个较高的标准来进行review,这样才能更好地保证整个产品的质量。 + +2. 对于用户接口类的、整体架构方面的修改,需要社区进行充分地讨论,可以在邮件组发起,也可以在issue上发起。用户接口的改变包括支持新的函数,支持新的功能。这样能够保证产品的一致性 Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org