[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375676702 ## File path: docs/documentation/cn/administrator-guide/alter-table/alter-table-temp-part

[GitHub] [incubator-doris] imay commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
imay commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375674869 ## File path: docs/documentation/cn/administrator-guide/alter-table/alter-table-temp-partition.

[GitHub] [incubator-doris] kangkaisen opened a new pull request #2847: Doris support in memory olap table

2020-02-05 Thread GitBox
kangkaisen opened a new pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847 For https://github.com/apache/incubator-doris/issues/2846 The doc and schema change support will do in next PR.

[GitHub] [incubator-doris] kangkaisen opened a new issue #2846: [Proposal] Support in memory olap table in Segment V2

2020-02-05 Thread GitBox
kangkaisen opened a new issue #2846: [Proposal] Support in memory olap table in Segment V2 URL: https://github.com/apache/incubator-doris/issues/2846 ## 1 Why need in memory olap table Currently, Disk seek is still a bottleneck for most of Doris queries, So we could use in memory table

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375643507 ## File path: docs/documentation/cn/administrator-guide/alter-table/alter-table-temp-part

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375642809 ## File path: be/src/olap/base_compaction.cpp ## @@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::p

[GitHub] [incubator-doris] morningman commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction

2020-02-05 Thread GitBox
morningman commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375626880 ## File path: be/src/olap/base_compaction.cpp ## @@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::p

[GitHub] [incubator-doris] imay commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
imay commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375619199 ## File path: docs/documentation/cn/administrator-guide/alter-table/alter-table-temp-partition.

[GitHub] [incubator-doris] imay merged pull request #2840: Fix spelling mistakes for load metrics description

2020-02-05 Thread GitBox
imay merged pull request #2840: Fix spelling mistakes for load metrics description URL: https://github.com/apache/incubator-doris/pull/2840 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-doris] branch master updated: Fix spelling mistakes for load metrics description (#2840)

2020-02-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new d549c40 Fix spelling mistakes for load

[incubator-doris] branch master updated: Fix removing tablet bug from partition_map in TabletManager (#2842)

2020-02-05 Thread lingbin
This is an automated email from the ASF dual-hosted git repository. lingbin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 14c7720 Fix removing tablet bug from

[GitHub] [incubator-doris] lingbin merged pull request #2842: Fix removing tablet bug from partition_map in TabletManager

2020-02-05 Thread GitBox
lingbin merged pull request #2842: Fix removing tablet bug from partition_map in TabletManager URL: https://github.com/apache/incubator-doris/pull/2842 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] morningman merged pull request #2831: Refactor `AgentServer` to make it less error-prone and more readable

2020-02-05 Thread GitBox
morningman merged pull request #2831: Refactor `AgentServer` to make it less error-prone and more readable URL: https://github.com/apache/incubator-doris/pull/2831 This is an automated message from the Apache Git Service. To

[incubator-doris] branch master updated: [Code Refactor] Refactor AgentServer to make it less error-prone and more readable (#2831)

2020-02-05 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new e991b13 [Code Refactor] Refactor A

[GitHub] [incubator-doris] yangzhg opened a new issue #2845: Implements IntersectNode and ExceptNode

2020-02-05 Thread GitBox
yangzhg opened a new issue #2845: Implements IntersectNode and ExceptNode URL: https://github.com/apache/incubator-doris/issues/2845 subtask for #2834 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-doris] yangzhg opened a new issue #2844: Add INTERSECT and EXCEPT support to SetOperationStmt and planner

2020-02-05 Thread GitBox
yangzhg opened a new issue #2844: Add INTERSECT and EXCEPT support to SetOperationStmt and planner URL: https://github.com/apache/incubator-doris/issues/2844 subtask for #2834 This is an automated message from the Apache Git

[GitHub] [incubator-doris] yangzhg opened a new issue #2843: Convert UnionStmt class into to SetOperationStmt, add Syntax support to sql_parser

2020-02-05 Thread GitBox
yangzhg opened a new issue #2843: Convert UnionStmt class into to SetOperationStmt, add Syntax support to sql_parser URL: https://github.com/apache/incubator-doris/issues/2843 subtask for #2834 This is an automated message f

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2839: [Compaction] Avoid unnecessary compaction URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375349589 ## File path: be/src/olap/base_compaction.cpp ## @@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::p

[GitHub] [incubator-doris] lingbin opened a new pull request #2842: Fix removing elements bug from partition_map in TabletManager

2020-02-05 Thread GitBox
lingbin opened a new pull request #2842: Fix removing elements bug from partition_map in TabletManager URL: https://github.com/apache/incubator-doris/pull/2842 When using an iterator of _tablet_map.tablet_arr(`std::list`) to remove a tablet, we should first remove tablet from _partition_

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375344047 ## File path: docs/documentation/cn/administrator-guide/alter-table/alter-table-temp-part

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375336823 ## File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java ##

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2831: Refactor `AgentServer` to make it less error-prone and more readable

2020-02-05 Thread GitBox
lingbin commented on a change in pull request #2831: Refactor `AgentServer` to make it less error-prone and more readable URL: https://github.com/apache/incubator-doris/pull/2831#discussion_r375334190 ## File path: be/src/agent/agent_server.cpp ## @@ -67,438 +47,236 @@ Age

[GitHub] [incubator-doris] imay commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
imay commented on a change in pull request #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#discussion_r375328471 ## File path: docs/documentation/cn/administrator-guide/alter-table/alter-table-temp-partition.

[incubator-doris] branch master updated (581c771 -> 25a6d6a)

2020-02-05 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 581c771 [Doc] Add create index usage document (#2832) add 25a6d6a Make cmake and maven configurable (#

[GitHub] [incubator-doris] imay closed issue #2835: Make CMake and MVN configurable

2020-02-05 Thread GitBox
imay closed issue #2835: Make CMake and MVN configurable URL: https://github.com/apache/incubator-doris/issues/2835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] imay merged pull request #2837: Make cmake and maven configurable

2020-02-05 Thread GitBox
imay merged pull request #2837: Make cmake and maven configurable URL: https://github.com/apache/incubator-doris/pull/2837 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375258433 ## File path: fe/src/main/java/org/apache/doris/planner/OlapScanNode.java ## @@ -130,6 +138,90 @@ publi

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375288106 ## File path: fe/src/main/java/org/apache/doris/planner/OlapScanNode.java ## @@ -497,4 +596,108 @@ publ

[GitHub] [incubator-doris] caiconghui opened a new issue #2841: Fix spelling mistakes for load metrics description

2020-02-05 Thread GitBox
caiconghui opened a new issue #2841: Fix spelling mistakes for load metrics description URL: https://github.com/apache/incubator-doris/issues/2841 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-doris] caiconghui commented on issue #2840: Fix spelling mistakes for load metrics description

2020-02-05 Thread GitBox
caiconghui commented on issue #2840: Fix spelling mistakes for load metrics description URL: https://github.com/apache/incubator-doris/pull/2840#issuecomment-582434756 #2841 This is an automated message from the Apache Git S

[GitHub] [incubator-doris] caiconghui opened a new pull request #2840: Fix spelling mistakes for load metrics description

2020-02-05 Thread GitBox
caiconghui opened a new pull request #2840: Fix spelling mistakes for load metrics description URL: https://github.com/apache/incubator-doris/pull/2840 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #2837: Make cmake and maven configurable

2020-02-05 Thread GitBox
HangyuanLiu commented on a change in pull request #2837: Make cmake and maven configurable URL: https://github.com/apache/incubator-doris/pull/2837#discussion_r375280321 ## File path: env.sh ## @@ -80,9 +80,23 @@ if [[ $JAVA_VER -lt 18 ]]; then fi # check maven -export

[GitHub] [incubator-doris] morningman opened a new pull request #2839: [Compaction] Avoid unnecessary compaction

2020-02-05 Thread GitBox
morningman opened a new pull request #2839: [Compaction] Avoid unnecessary compaction URL: https://github.com/apache/incubator-doris/pull/2839 It is not necessary to perform compaction in the following cases 1. A tablet has only 2 rowsets, the versions are [0-1] and [2-x]. In this c

[GitHub] [incubator-doris] morningman opened a new issue #2838: [Compaction] Always performing some unnecessary compactions

2020-02-05 Thread GitBox
morningman opened a new issue #2838: [Compaction] Always performing some unnecessary compactions URL: https://github.com/apache/incubator-doris/issues/2838 It is not necessary to perform compaction in the following cases 1. A tablet has only 2 rowsets, the versions are [0-1] and [2-x

[GitHub] [incubator-doris] imay opened a new pull request #2837: Make cmake and maven configurable

2020-02-05 Thread GitBox
imay opened a new pull request #2837: Make cmake and maven configurable URL: https://github.com/apache/incubator-doris/pull/2837 #2835 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] imay opened a new issue #2836: LLVM 3.4.2 may be not compatible with GCC 8 or higher

2020-02-05 Thread GitBox
imay opened a new issue #2836: LLVM 3.4.2 may be not compatible with GCC 8 or higher URL: https://github.com/apache/incubator-doris/issues/2836 Today, I tried to compile Doris with GCC 8 and GCC 9, but failed. Besides some minor problems, That LLVM 3.4.2 is not compatible with GCC8+ is the

[GitHub] [incubator-doris] imay opened a new issue #2835: Make CMake and MVN configurable

2020-02-05 Thread GitBox
imay opened a new issue #2835: Make CMake and MVN configurable URL: https://github.com/apache/incubator-doris/issues/2835 When compiling doris, there is no way to specify cmake or mvn, which is very inconvenient in some scenarios. We need to make it configurable so that users can specify t

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375241987 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
kangkaisen commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375241330 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] kangkaisen commented on issue #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
kangkaisen commented on issue #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#issuecomment-582389201 > @kangkaisen Would you help to review this PR? OK. I will review this PR. -

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375209306 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] yangzhg opened a new issue #2834: [Proposal] Full support of set operations: add INTERSECT and EXCEPT set operators

2020-02-05 Thread GitBox
yangzhg opened a new issue #2834: [Proposal] Full support of set operations: add INTERSECT and EXCEPT set operators URL: https://github.com/apache/incubator-doris/issues/2834 # Description Generaly set functionality includes the below. but now doris has just support UNION & UNION ALL.

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375194192 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375182334 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375182332 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375163069 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375163071 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375163071 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375163069 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375147620 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375145172 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375138678 ## File path: fe/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java ## @@ -0,0 +1,45

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375135778 ## File path: fe/src/main/java/org/apache/doris/planner/OlapScanNode.java ## @@ -130,6 +138,66 @@ publi

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375123244 ## File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java ## @@ -90,6 +90,8 @@ publi

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375122934 ## File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java ## @@ -90,6 +90,8 @@ publi

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375120683 ## File path: fe/src/main/java/org/apache/doris/catalog/OlapTable.java ## @@ -292,6 +292,10 @@ public v

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector

2020-02-05 Thread GitBox
EmmyMiao87 commented on a change in pull request #2821: The new materialized view selector URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375118334 ## File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java ## @@ -4791,8 +4791,10 @@ public v

[GitHub] [incubator-doris] morningman commented on issue #2828: [Temp Partition] Support add/drop/replace temp partitions

2020-02-05 Thread GitBox
morningman commented on issue #2828: [Temp Partition] Support add/drop/replace temp partitions URL: https://github.com/apache/incubator-doris/pull/2828#issuecomment-582297628 @kangkaisen Would you help to review this PR? This