EmmyMiao87 commented on a change in pull request #2821: The new materialized 
view selector
URL: https://github.com/apache/incubator-doris/pull/2821#discussion_r375120683
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/OlapTable.java
 ##########
 @@ -292,6 +292,10 @@ public void setIndexStorageType(Long indexId, 
TStorageType newStorageType) {
     public void rebuildFullSchema() {
         fullSchema.clear();
         nameToColumn.clear();
+        for (Column baseColumn : indexIdToSchema.get(baseIndexId)) {
 
 Review comment:
   The order of the table structure in this map is not necessarily. However 
those two attributes `fullSchema` and `nameToColumn` must contain the base 
schema of table. 
   So we need to add the base schema into those attributes firstly. 
   Then I supplement those temporary columns caused by the schema change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to