morningman commented on a change in pull request #2839: [Compaction] Avoid
unnecessary compaction
URL: https://github.com/apache/incubator-doris/pull/2839#discussion_r375626880
##########
File path: be/src/olap/base_compaction.cpp
##########
@@ -87,6 +93,11 @@ OLAPStatus BaseCompaction::pick_rowsets_to_compact() {
}
double base_cumulative_delta_ratio = config::base_cumulative_delta_ratio;
+ if (base_size == 0) {
Review comment:
`_input_rowsets.size()` is the number of rowsets.
For example, we have 2 rowsets with version: [0-1] and [2-2];
the `base_size` here is the data size of [0-1], which can be zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
