[GitHub] [incubator-doris] HangyuanLiu commented on issue #2812: Fix parquet arrow read batch bug

2020-01-19 Thread GitBox
HangyuanLiu commented on issue #2812: Fix parquet arrow read batch bug URL: https://github.com/apache/incubator-doris/pull/2812#issuecomment-576143120 The original code was to determine the number of rows in the batch based on the number of rows in the parquet RowGroup. It could be a ba

[GitHub] [incubator-doris] chaoyli commented on issue #2812: Fix parquet arrow read batch bug

2020-01-19 Thread GitBox
chaoyli commented on issue #2812: Fix parquet arrow read batch bug URL: https://github.com/apache/incubator-doris/pull/2812#issuecomment-576141567 I have a question, why it will be crashed? This is an automated message from th

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2815: create bloom filter index failed for largeint in segment v2

2020-01-19 Thread GitBox
kangpinghuang opened a new issue #2815: create bloom filter index failed for largeint in segment v2 URL: https://github.com/apache/incubator-doris/issues/2815 **Describe the bug** when load with large int column with bloom filter index, BE will core dump when insert int128 value into st

[GitHub] [incubator-doris] yangzhg opened a new pull request #2814: fix docs sequence error

2020-01-19 Thread GitBox
yangzhg opened a new pull request #2814: fix docs sequence error URL: https://github.com/apache/incubator-doris/pull/2814 wrong sequence of 1.2 and 1.4 #2806 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-doris] Lishi-hub commented on a change in pull request #2813: Support starts_with (str, prefix) function

2020-01-19 Thread GitBox
Lishi-hub commented on a change in pull request #2813: Support starts_with (str, prefix) function URL: https://github.com/apache/incubator-doris/pull/2813#discussion_r368393414 ## File path: gensrc/script/doris_builtins_functions.py ## @@ -506,6 +506,8 @@ '15Funct

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #2813: Starts with

2020-01-19 Thread GitBox
HangyuanLiu commented on a change in pull request #2813: Starts with URL: https://github.com/apache/incubator-doris/pull/2813#discussion_r368392312 ## File path: gensrc/script/doris_builtins_functions.py ## @@ -506,6 +506,8 @@ '15FunctionContextERKNS1_9StringValERK

[GitHub] [incubator-doris] HangyuanLiu commented on issue #2813: Starts with

2020-01-19 Thread GitBox
HangyuanLiu commented on issue #2813: Starts with URL: https://github.com/apache/incubator-doris/pull/2813#issuecomment-576133408 1、Please rename title, so as "Support starts_with function"? 2、Please relate this PR to issue

[GitHub] [incubator-doris] Lishi-hub opened a new pull request #2813: Starts with

2020-01-19 Thread GitBox
Lishi-hub opened a new pull request #2813: Starts with URL: https://github.com/apache/incubator-doris/pull/2813 Returns true whether string starts with the specified prefix, otherwise it returns false. This is an automated me

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #2812: Fix parquet arrow read batch bug

2020-01-19 Thread GitBox
HangyuanLiu opened a new pull request #2812: Fix parquet arrow read batch bug URL: https://github.com/apache/incubator-doris/pull/2812 Fix parquet arrow read batch bug #2811 This is an automated message from the Apache Git

[GitHub] [incubator-doris] HangyuanLiu opened a new issue #2811: Be crash when broker load with parquet format

2020-01-19 Thread GitBox
HangyuanLiu opened a new issue #2811: Be crash when broker load with parquet format URL: https://github.com/apache/incubator-doris/issues/2811 **Describe the bug** Be crash when broker load with parquet format **To Reproduce** Steps to reproduce the behavior: 1. Load data

[GitHub] [incubator-doris] morningman merged pull request #2800: Support new show functions syntax to make user search function more conveniently

2020-01-19 Thread GitBox
morningman merged pull request #2800: Support new show functions syntax to make user search function more conveniently URL: https://github.com/apache/incubator-doris/pull/2800 This is an automated message from the Apache Git

[incubator-doris] branch master updated (0f829ca -> 58ff952)

2020-01-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 0f829ca Add arm compatible patches (#2798) add 58ff952 [Stmt] Support new show functions syntax t

[GitHub] [incubator-doris] kangkaisen commented on issue #2807: doris can't create table according to help-manual

2020-01-19 Thread GitBox
kangkaisen commented on issue #2807: doris can't create table according to help-manual URL: https://github.com/apache/incubator-doris/issues/2807#issuecomment-576102290 This is not a issue. The doc is for 0.11. bug your code should has this PR: https://github.com/apache/incubator-do

[GitHub] [incubator-doris] kangkaisen commented on issue #2810: doris can't insert into table(bitmap) after created it

2020-01-19 Thread GitBox
kangkaisen commented on issue #2810: doris can't insert into table(bitmap) after created it URL: https://github.com/apache/incubator-doris/issues/2810#issuecomment-576101763 This issue is duplicated with https://github.com/apache/incubator-doris/issues/2406 and has been fixed. --

[GitHub] [incubator-doris] gaodayue closed pull request #2793: Reformat BE code 2/7

2020-01-19 Thread GitBox
gaodayue closed pull request #2793: Reformat BE code 2/7 URL: https://github.com/apache/incubator-doris/pull/2793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-doris] gaodayue commented on issue #2793: Reformat BE code 2/7

2020-01-19 Thread GitBox
gaodayue commented on issue #2793: Reformat BE code 2/7 URL: https://github.com/apache/incubator-doris/pull/2793#issuecomment-576096985 Closed the PR due to the community hasn't reached consensus on the code style, which should be discussed first ---

[GitHub] [incubator-doris] gaodayue commented on issue #2794: Reformat BE code 3/7

2020-01-19 Thread GitBox
gaodayue commented on issue #2794: Reformat BE code 3/7 URL: https://github.com/apache/incubator-doris/pull/2794#issuecomment-576096933 Closed the PR due to the community hasn't reached consensus on the code style, which should be discussed first ---

[GitHub] [incubator-doris] gaodayue closed pull request #2794: Reformat BE code 3/7

2020-01-19 Thread GitBox
gaodayue closed pull request #2794: Reformat BE code 3/7 URL: https://github.com/apache/incubator-doris/pull/2794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-doris] blackfox1983 opened a new issue #2810: doris can't insert into table(bitmap) after created it

2020-01-19 Thread GitBox
blackfox1983 opened a new issue #2810: doris can't insert into table(bitmap) after created it URL: https://github.com/apache/incubator-doris/issues/2810 according the manual, i create the table. CREATE TABLE `bitmap_test` ( `id` int(11) NULL COMMENT "", `id2` bitmap bitmap_

[GitHub] [incubator-doris] caiconghui commented on issue #2808: Remove unused code for ShowPartitionsStmtTest and add apache license header

2020-01-19 Thread GitBox
caiconghui commented on issue #2808: Remove unused code for ShowPartitionsStmtTest and add apache license header URL: https://github.com/apache/incubator-doris/pull/2808#issuecomment-576086746 #2809 This is an automated mess

[GitHub] [incubator-doris] caiconghui opened a new issue #2809: Remove unused code for ShowPartitionsStmtTest and add apache license header

2020-01-19 Thread GitBox
caiconghui opened a new issue #2809: Remove unused code for ShowPartitionsStmtTest and add apache license header URL: https://github.com/apache/incubator-doris/issues/2809 ShowPartitionsStmtTest.java file has unused code, and the apache license header is absent ---

[GitHub] [incubator-doris] caiconghui opened a new pull request #2808: Remove unused code for ShowPartitionsStmtTest and add apache license header

2020-01-19 Thread GitBox
caiconghui opened a new pull request #2808: Remove unused code for ShowPartitionsStmtTest and add apache license header URL: https://github.com/apache/incubator-doris/pull/2808 This is an automated message from the Apache Gi

[GitHub] [incubator-doris] blackfox1983 opened a new issue #2807: doris can't create table according to help-manual

2020-01-19 Thread GitBox
blackfox1983 opened a new issue #2807: doris can't create table according to help-manual URL: https://github.com/apache/incubator-doris/issues/2807 in help-manual ![image](https://user-images.githubusercontent.com/6658943/72694904-97106a00-3b71-11ea-99cb-db397e5a60d9.png) actual

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r368342676 ## File path: conf/fe.conf ## @@ -25,7 +25,10 @@ LOG_DIR = ${DORIS_HOME}/log DATE = `date +%Y%m%d-%H%M%S` -JAVA_OPTS

[GitHub] [incubator-doris] wenbronk opened a new issue #2806: wrong sequence of 1.2 and 1.4

2020-01-19 Thread GitBox
wenbronk opened a new issue #2806: wrong sequence of 1.2 and 1.4 URL: https://github.com/apache/incubator-doris/issues/2806 http://doris.apache.org/documentation/cn/getting-started/best-practice.html#star-schema ![image](http://images.wenbronk.cn/markdown201912/20200120095515.png)

[GitHub] [incubator-doris] wenbronk opened a new issue #2805: wrong sequence

2020-01-19 Thread GitBox
wenbronk opened a new issue #2805: wrong sequence URL: https://github.com/apache/incubator-doris/issues/2805 http://doris.apache.org/documentation/cn/getting-started/best-practice.html#star-schema ![wrong sequence](http://images.wenbronk.cn/markdown201912/20200120095515.png) --

[GitHub] [incubator-doris] wenbronk closed issue #2805: wrong sequence

2020-01-19 Thread GitBox
wenbronk closed issue #2805: wrong sequence URL: https://github.com/apache/incubator-doris/issues/2805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r368342676 ## File path: conf/fe.conf ## @@ -25,7 +25,10 @@ LOG_DIR = ${DORIS_HOME}/log DATE = `date +%Y%m%d-%H%M%S` -JAVA_OPTS

[incubator-doris] branch master updated: Add arm compatible patches (#2798)

2020-01-19 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 0f829ca Add arm compatible patches (#27

[GitHub] [incubator-doris] imay merged pull request #2798: add arm compatible patches

2020-01-19 Thread GitBox
imay merged pull request #2798: add arm compatible patches URL: https://github.com/apache/incubator-doris/pull/2798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] morningman commented on a change in pull request #2804: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
morningman commented on a change in pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r368302322 ## File path: fe/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java ## @@ -31,6 +32,13 @@ import org.apache

[GitHub] [incubator-doris] morningman commented on a change in pull request #2804: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
morningman commented on a change in pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r368302316 ## File path: fe/src/main/java/org/apache/doris/PaloFe.java ## @@ -222,10 +274,12 @@ private static CommandLineOption

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r368301659 ## File path: fe/src/main/java/org/apache/doris/PaloFe.java ## @@ -222,10 +274,12 @@ private static CommandLineOptions p

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
yangzhg commented on a change in pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804#discussion_r368301810 ## File path: fe/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java ## @@ -31,6 +32,13 @@ import org.apache.do

[GitHub] [incubator-doris] morningman commented on a change in pull request #2800: Support new show functions syntax to make user search function more conveniently

2020-01-19 Thread GitBox
morningman commented on a change in pull request #2800: Support new show functions syntax to make user search function more conveniently URL: https://github.com/apache/incubator-doris/pull/2800#discussion_r368301911 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -194,1

[GitHub] [incubator-doris] morningman commented on a change in pull request #2800: Support new show functions syntax to make user search function more conveniently

2020-01-19 Thread GitBox
morningman commented on a change in pull request #2800: Support new show functions syntax to make user search function more conveniently URL: https://github.com/apache/incubator-doris/pull/2800#discussion_r368301681 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.jav

[GitHub] [incubator-doris] morningman commented on a change in pull request #2800: Support new show functions syntax to make user search function more conveniently

2020-01-19 Thread GitBox
morningman commented on a change in pull request #2800: Support new show functions syntax to make user search function more conveniently URL: https://github.com/apache/incubator-doris/pull/2800#discussion_r368301637 ## File path: fe/src/main/java/org/apache/doris/qe/ShowExecutor.jav

[GitHub] [incubator-doris] imay merged pull request #2802: Add notes in java stream load sample to avoid wrong use of stream load

2020-01-19 Thread GitBox
imay merged pull request #2802: Add notes in java stream load sample to avoid wrong use of stream load URL: https://github.com/apache/incubator-doris/pull/2802 This is an automated message from the Apache Git Service. To res

[incubator-doris] branch master updated (634928e -> 47a7df1)

2020-01-19 Thread zhaoc
This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 634928e Fix typo and remove tmp file in ut (#2789) add 47a7df1 Add notes in java stream load sample to

[GitHub] [incubator-doris] morningman opened a new pull request #2804: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
morningman opened a new pull request #2804: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/pull/2804 Support compile and running Frontend process and Broker process with OpenJDK. OpenJDK 13 is tested. ISSUE: #2803

[GitHub] [incubator-doris] morningman opened a new issue #2803: [JDK] Support OpenJDK

2020-01-19 Thread GitBox
morningman opened a new issue #2803: [JDK] Support OpenJDK URL: https://github.com/apache/incubator-doris/issues/2803 Support compile and running Frontend process and Broker process with OpenJDK This is an automated message fr

[GitHub] [incubator-doris] caiconghui opened a new pull request #2802: Add notes in java stream load sample to avoid wrong use of stream load

2020-01-19 Thread GitBox
caiconghui opened a new pull request #2802: Add notes in java stream load sample to avoid wrong use of stream load URL: https://github.com/apache/incubator-doris/pull/2802 This is an automated message from the Apache Git Ser

[GitHub] [incubator-doris] caiconghui commented on issue #2802: Add notes in java stream load sample to avoid wrong use of stream load

2020-01-19 Thread GitBox
caiconghui commented on issue #2802: Add notes in java stream load sample to avoid wrong use of stream load URL: https://github.com/apache/incubator-doris/pull/2802#issuecomment-576007584 #2801 This is an automated message f

[GitHub] [incubator-doris] caiconghui opened a new issue #2801: DorisStreamLoad java sample should add more note to avoid wrong use of stream load

2020-01-19 Thread GitBox
caiconghui opened a new issue #2801: DorisStreamLoad java sample should add more note to avoid wrong use of stream load URL: https://github.com/apache/incubator-doris/issues/2801 In our production environment, our user who use DorisStreamLoad example think stream load is ok when statusCode

[GitHub] [incubator-doris] morningman merged pull request #2789: fix typo and remove tmp file generated by ut

2020-01-19 Thread GitBox
morningman merged pull request #2789: fix typo and remove tmp file generated by ut URL: https://github.com/apache/incubator-doris/pull/2789 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-doris] branch master updated (7c4149c -> 634928e)

2020-01-19 Thread morningman
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 7c4149c Improve comparison and printing of Version (#2796) add 634928e Fix typo and remove tmp fi

[GitHub] [incubator-doris] caiconghui commented on issue #2800: Support new show functions syntax to make user search function more conveniently

2020-01-19 Thread GitBox
caiconghui commented on issue #2800: Support new show functions syntax to make user search function more conveniently URL: https://github.com/apache/incubator-doris/pull/2800#issuecomment-576004402 #2795 This is an automated

[GitHub] [incubator-doris] caiconghui opened a new pull request #2800: Support new show functions syntax to make user search function more conveniently

2020-01-19 Thread GitBox
caiconghui opened a new pull request #2800: Support new show functions syntax to make user search function more conveniently URL: https://github.com/apache/incubator-doris/pull/2800 Support new Show functions syntax to make functions more friendly for user to use -

[GitHub] [incubator-doris] chaoyli commented on issue #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
chaoyli commented on issue #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#issuecomment-576002090 I think it may be better to discuss to adopt which style at first. Abide by the old style formulated in Baidu, or Impala style. Second, we can change t

[GitHub] [incubator-doris] gaodayue commented on issue #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on issue #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#issuecomment-576001150 Hi @lingbin @chaoyli , I updated the PR according to your suggestions. Now I managed to reduce the diff from `+1,014 −1,242` into `+616 −618`, could you r

[GitHub] [incubator-doris] gaodayue commented on issue #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on issue #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#issuecomment-576000358 I tried [impala's](https://github.com/apache/impala/blob/master/.clang-format) `IncludeCategories` on `be/src/agent/utils.cpp`, the result is ```

[GitHub] [incubator-doris] chaoyli commented on issue #2751: Fix bug for SIGFPE produced in AlphaRowset::split_range

2020-01-19 Thread GitBox
chaoyli commented on issue #2751: Fix bug for SIGFPE produced in AlphaRowset::split_range URL: https://github.com/apache/incubator-doris/pull/2751#issuecomment-576000112 If you can reproduce this bug, you can use watch command in GDB. This command can used to know the variable modified in

[GitHub] [incubator-doris] chaoyli commented on issue #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
chaoyli commented on issue #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#issuecomment-575999533 Because there is a internal code style format in Baidu for C++ programmer. There are some difference between with Impala including indention and variabl

[GitHub] [incubator-doris] xy720 opened a new pull request #2799: Filter NullLiteral in castTo method instead of throwing a exception

2020-01-19 Thread GitBox
xy720 opened a new pull request #2799: Filter NullLiteral in castTo method instead of throwing a exception URL: https://github.com/apache/incubator-doris/pull/2799 Issue #2399 #2396 (2.2) We used to use **Precondition** to throw an exception when encounter a NullLiteral in castTo

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368289151 ## File path: be/src/agent/utils.cpp ## @@ -16,32 +16,33 @@ // under the License. #include "agent/utils.h" + #inclu

[GitHub] [incubator-doris] wenbronk commented on issue #2797: unable to login with mysql -h xxx -uxxx after changing root password

2020-01-19 Thread GitBox
wenbronk commented on issue #2797: unable to login with mysql -h xxx -uxxx after changing root password URL: https://github.com/apache/incubator-doris/issues/2797#issuecomment-575995390 可以登陆了, 谢谢!!! This is an automated mess

[GitHub] [incubator-doris] wenbronk closed issue #2797: unable to login with mysql -h xxx -uxxx after changing root password

2020-01-19 Thread GitBox
wenbronk closed issue #2797: unable to login with mysql -h xxx -uxxx after changing root password URL: https://github.com/apache/incubator-doris/issues/2797 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-doris] imay commented on a change in pull request #2782: Add file cache for v2

2020-01-19 Thread GitBox
imay commented on a change in pull request #2782: Add file cache for v2 URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r368278521 ## File path: be/src/common/config.h ## @@ -221,6 +221,7 @@ namespace config { CONF_Bool(row_nums_check, "true")

[GitHub] [incubator-doris] imay commented on a change in pull request #2782: Add file cache for v2

2020-01-19 Thread GitBox
imay commented on a change in pull request #2782: Add file cache for v2 URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r368278925 ## File path: be/src/util/file_cache.h ## @@ -0,0 +1,316 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-doris] imay commented on a change in pull request #2782: Add file cache for v2

2020-01-19 Thread GitBox
imay commented on a change in pull request #2782: Add file cache for v2 URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r368278763 ## File path: be/src/env/env.h ## @@ -73,6 +76,9 @@ class Env { const std::strin

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368281781 ## File path: be/src/agent/utils.cpp ## @@ -91,23 +86,23 @@ AgentStatus MasterServerClient::finish_task( cl

[GitHub] [incubator-doris] lingbin merged pull request #2796: Improve comparison and printing of Version

2020-01-19 Thread GitBox
lingbin merged pull request #2796: Improve comparison and printing of Version URL: https://github.com/apache/incubator-doris/pull/2796 This is an automated message from the Apache Git Service. To respond to the message, pleas

[incubator-doris] branch master updated (92d8f6a -> 7c4149c)

2020-01-19 Thread lingbin
This is an automated email from the ASF dual-hosted git repository. lingbin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 92d8f6a [Alter] Allow submitting alter jobs when table is unstable add 7c4149c Improve comparison an

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368281450 ## File path: be/src/agent/user_resource_listener.cpp ## @@ -64,16 +61,15 @@ void UserResourceListener::update_users_res

[GitHub] [incubator-doris] HangyuanLiu closed issue #2518: Support CURDATE in Doris

2020-01-19 Thread GitBox
HangyuanLiu closed issue #2518: Support CURDATE in Doris URL: https://github.com/apache/incubator-doris/issues/2518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368281069 ## File path: be/src/agent/task_worker_pool.h ## @@ -65,10 +65,8 @@ class TaskWorkerPool { typedef void* (*CALLBA

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368280870 ## File path: be/src/agent/pusher.cpp ## @@ -178,18 +176,16 @@ AgentStatus Pusher::process(vector* tablet_infos) {

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368279500 ## File path: be/src/agent/utils.cpp ## @@ -59,26 +60,20 @@ using apache::thrift::transport::TTransportException; name

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368276703 ## File path: be/src/agent/task_worker_pool.h ## @@ -65,10 +65,8 @@ class TaskWorkerPool { typedef void* (*CALLBAC

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368278813 ## File path: be/src/agent/user_resource_listener.cpp ## @@ -64,16 +61,15 @@ void UserResourceListener::update_users_reso

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368275407 ## File path: be/src/agent/pusher.cpp ## @@ -178,18 +176,16 @@ AgentStatus Pusher::process(vector* tablet_infos) {

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368279329 ## File path: be/src/agent/utils.cpp ## @@ -16,32 +16,33 @@ // under the License. #include "agent/utils.h" + #includ

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368279745 ## File path: be/src/agent/utils.cpp ## @@ -91,23 +86,23 @@ AgentStatus MasterServerClient::finish_task( cli

[GitHub] [incubator-doris] yangzhg opened a new pull request #2798: add arm compatible patches

2020-01-19 Thread GitBox
yangzhg opened a new pull request #2798: add arm compatible patches URL: https://github.com/apache/incubator-doris/pull/2798 1. fix llvm patch file formate error 2. add brcp arm compatible patch This is an automated message

[GitHub] [incubator-doris] imay commented on issue #2797: unable to login with mysql -h xxx -uxxx after changing root password

2020-01-19 Thread GitBox
imay commented on issue #2797: unable to login with mysql -h xxx -uxxx after changing root password URL: https://github.com/apache/incubator-doris/issues/2797#issuecomment-575983998 you can try `mysql --default-auth=mysql_native_password -h host -P port` --

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2796: Improve comparison and printing of Version

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2796: Improve comparison and printing of Version URL: https://github.com/apache/incubator-doris/pull/2796#discussion_r368277997 ## File path: be/src/olap/tablet.cpp ## @@ -272,16 +255,11 @@ OLAPStatus Tablet::add_rowset(Rowset

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2796: Improve comparison and printing of Version

2020-01-19 Thread GitBox
lingbin commented on a change in pull request #2796: Improve comparison and printing of Version URL: https://github.com/apache/incubator-doris/pull/2796#discussion_r368276909 ## File path: be/src/olap/olap_common.h ## @@ -189,20 +186,29 @@ struct Version { int64_t sec

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2782: Add file cache for v2

2020-01-19 Thread GitBox
kangpinghuang commented on a change in pull request #2782: Add file cache for v2 URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r368275392 ## File path: be/src/util/file_cache.cpp ## @@ -0,0 +1,416 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2782: Add file cache for v2

2020-01-19 Thread GitBox
kangpinghuang commented on a change in pull request #2782: Add file cache for v2 URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r368275399 ## File path: be/src/util/file_cache.cpp ## @@ -0,0 +1,416 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2782: Add file cache for v2

2020-01-19 Thread GitBox
kangpinghuang commented on a change in pull request #2782: Add file cache for v2 URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r368275375 ## File path: be/src/common/config.h ## @@ -221,6 +221,7 @@ namespace config { CONF_Bool(row_nums_check, "tru

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2782: Add file cache for v2

2020-01-19 Thread GitBox
kangpinghuang commented on a change in pull request #2782: Add file cache for v2 URL: https://github.com/apache/incubator-doris/pull/2782#discussion_r368275378 ## File path: be/src/util/file_cache.cpp ## @@ -0,0 +1,416 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-doris] gaodayue commented on issue #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on issue #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#issuecomment-575979690 Many of the reformat on function declarations and invocations is caused by `ColumnLimit: 100`, I'm going to test whether `ColumnLimit: 0` would disable su

[GitHub] [incubator-doris] wangbo commented on a change in pull request #2781: Batch Operate Rollup table in Doris #2671

2020-01-19 Thread GitBox
wangbo commented on a change in pull request #2781: Batch Operate Rollup table in Doris #2671 URL: https://github.com/apache/incubator-doris/pull/2781#discussion_r368274912 ## File path: fe/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java ## @@ -590,15 +76

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2796: Improve comparison and printing of Version

2020-01-19 Thread GitBox
chaoyli commented on a change in pull request #2796: Improve comparison and printing of Version URL: https://github.com/apache/incubator-doris/pull/2796#discussion_r368274126 ## File path: be/src/olap/olap_common.h ## @@ -189,20 +186,29 @@ struct Version { int64_t sec

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2796: Improve comparison and printing of Version

2020-01-19 Thread GitBox
chaoyli commented on a change in pull request #2796: Improve comparison and printing of Version URL: https://github.com/apache/incubator-doris/pull/2796#discussion_r368273807 ## File path: be/src/olap/tablet.cpp ## @@ -272,16 +255,11 @@ OLAPStatus Tablet::add_rowset(Rowset

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #2792: Reformat BE code 1/7

2020-01-19 Thread GitBox
gaodayue commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368274059 ## File path: be/src/agent/agent_server.cpp ## @@ -53,12 +55,8 @@ using std::vector; namespace doris { -AgentServer