gaodayue commented on a change in pull request #2792: Reformat BE code 1/7 URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368281781
########## File path: be/src/agent/utils.cpp ########## @@ -91,23 +86,23 @@ AgentStatus MasterServerClient::finish_task( client_status = client.reopen(config::thrift_rpc_timeout_ms); if (!client_status.ok()) { - OLAP_LOG_WARNING("master client, get client from cache failed." - "host: %s, port: %d, code: %d", - _master_info.network_address.hostname.c_str(), - _master_info.network_address.port, - client_status.code()); + OLAP_LOG_WARNING( + "master client, get client from cache failed." + "host: %s, port: %d, code: %d", + _master_info.network_address.hostname.c_str(), + _master_info.network_address.port, client_status.code()); Review comment: No. This is caused by `AlwaysBreakBeforeMultilineStrings` which is true in google's style. We can set it to false to allow the above code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org