lingbin commented on a change in pull request #2796: Improve comparison and
printing of Version
URL: https://github.com/apache/incubator-doris/pull/2796#discussion_r368276909
##########
File path: be/src/olap/olap_common.h
##########
@@ -189,20 +186,29 @@ struct Version {
int64_t second;
Version(int64_t first_, int64_t second_) : first(first_), second(second_)
{}
-
Version() : first(0), second(0) {}
+ friend std::ostream& operator<<(std::ostream& os, const Version& version);
+
bool operator!=(const Version& rhs) const {
return first != rhs.first || second != rhs.second;
}
bool operator==(const Version& rhs) const {
return first == rhs.first && second == rhs.second;
}
+
+ bool contains(const Version& other) const {
Review comment:
Done. Thank you for your careful review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
