lingbin commented on a change in pull request #2792: Reformat BE code 1/7
URL: https://github.com/apache/incubator-doris/pull/2792#discussion_r368276703
##########
File path: be/src/agent/task_worker_pool.h
##########
@@ -65,10 +65,8 @@ class TaskWorkerPool {
typedef void* (*CALLBACK_FUNCTION)(void*);
- TaskWorkerPool(
- const TaskWorkerType task_worker_type,
- ExecEnv* env,
- const TMasterInfo& master_info);
+ TaskWorkerPool(const TaskWorkerType task_worker_type, ExecEnv* env,
+ const TMasterInfo& master_info);
Review comment:
In the current code style, If the total line is bigger than 120(better 100,
more suitable for most people's LED) char, use a new line, and leave 8 space at
the beginning of the new line. All the code of the current Doris do like this,
so can you make it optional, and it is up to developers to make his decision.
he can choose one of these ways.
That to say, and for this case, if one wrote:
```
// example 1
TaskWorkerPool(
const TaskWorkerType task_worker_type,
ExecEnv* env,
const TMasterInfo& master_info);
// example 2
TaskWorkerPool(const TaskWorkerType task_worker_type,
ExecEnv* env,
const TMasterInfo& master_info);
// example 3
TaskWorkerPool(const TaskWorkerType task_worker_type, ExecEnv* env,
const TMasterInfo& master_info);
```
All of the above should be allowed, not forced to the third
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
