[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/LoopUnrolling.cpp:167 + const bool isParm = VD->getKind() == Decl::ParmVar; + // Reference parameters are assumed as escaped variables. `getKind` function is only an implementation de

[PATCH] D75432: [analyzer][NFC][MallocChecker] Convert many parameters into CallEvent

vsavchenko added a comment. Hi, @Szelethus, I don't know exactly which of the changes (this one, https://reviews.llvm.org/D75430, or https://reviews.llvm.org/D75431) causes a crash on SQLite, but it's definitely one of these. **Steps to reproduce** clang -cc1 -Wdeprecated-objc-isa-usage -Wer

[PATCH] D80171: [analyzer] LoopUnrolling: fix crash when a parameter is a loop counter

vsavchenko accepted this revision. vsavchenko added a comment. LGTM! Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80171/new/ https://reviews.llvm.org/D80171 ___ cfe-commits mailing list

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

vsavchenko added a comment. @NoQ @ASDenysPetrov I will rebase my changes - no worries :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77802/new/ https://reviews.llvm.org/D77802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. SATest scripts should be

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 265680. vsavchenko added a comment. Modify forgotten parts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80424/new/ https://reviews.llvm.org/D80424 Files: clang/utils/analyzer/SATestBuild.py clang/utils

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko updated this re

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 265682. vsavchenko added a comment. Fix update diffs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/ https://reviews.llvm.org/D80423 Files: clang/utils/analyzer/SATestAdd.py clang/utils/analyze

[PATCH] D80426: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vsavchenko added a parent

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 265691. vsavchenko added a comment. Fix code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/ https://reviews.llvm.org/D80423 Files: clang/utils/analyzer/SATestAdd.py clang/utils

[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG4902ca6da49b: [analyzer] SATestBuild.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80423/new/

[PATCH] D80426: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a9aff12ff3b: [analyzer] SATestUpdateDiffs.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8042

[PATCH] D80424: [analyzer] SATestUtils.py: Refactor and add type annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cebfa4e0692: [analyzer] SATestUtils.py: Refactor and add type annotations (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80424/new/

[PATCH] D80427: [analyzer] SumTimerInfo.py: Partially modernize

This revision was automatically updated to reflect the committed changes. Closed by commit rG475d12028370: [analyzer] SumTimerInfo.py: Partially modernize (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80427/new/ https://rev

[PATCH] D80443: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Tasks can crash with many different

[PATCH] D80443: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b2503a8ab4: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80443/n

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

vsavchenko added a comment. Hi @Szelethus , it looks like I am a bearer of bad news again :( This patch seems to crash `scan-build` on pretty much every project that I tested. One way to reproduce: git clone https://github.com/postgres/postgres.git cd postgres/ scan-build -plist-html -o .

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266015. vsavchenko added a comment. Fix a couple more names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py Index: clang/ut

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266014. vsavchenko added a comment. Replace deprecated method call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py Index: c

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266016. vsavchenko added a comment. Fix SATestBuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py clang/utils/analyzer/S

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

vsavchenko updated this revision to Diff 266518. vsavchenko added a comment. Fix global issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80626/new/ https://reviews.llvm.org/D80626 Files: clang/utils/analyzer/SATestBuild.py Index: clang/util

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266520. vsavchenko added a comment. Fix SATestBuild call to CmpRuns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py clang/

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266521. vsavchenko added a comment. Fix SATestBuild call to CmpRuns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py clang/

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 266551. vsavchenko added a comment. Move 0 % x case to SValBuilder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstr

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked 5 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459-469 +if (Origin.From().isMinSignedValue()) { + // If mini is a minimal signed value, absolute value of it is greater +

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko updated this revision to Diff 266571. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/ https://reviews.llvm.org/D79232 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedCons

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 266586. vsavchenko added a comment. Fix code review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMan

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459-469 +if (Origin.From().isMinSignedValue()) { + // If mini is a minimal signed value, absolute value of it is greater +

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko added a comment. Performance-wise, I've investigated huge slowdowns on `tmux` and `pytorch`. - `pytorch` build produces a lot of warnings and simply trashed my terminal. I guess one time it had more troubles with displaying all that than the other. Here is a table with new times:

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd06c417e6c7: [analyzer] Allow bindings of the CompoundLiteralRegion (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78990/new/ http

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:506-507 + /// + /// where abs(Origin) is the maximal absolute value of any possible values + /// from Origin, and min(T) is

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 266890. vsavchenko added a comment. Fix code review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMan

[PATCH] D79156: [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb2ae74717a2: [analyzer] Merge implementations of SymInt, IntSym, and SymSym exprs (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a09daff0f90: [analyzer] Generalize bitwise AND rules for ranges (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D79434?vs=264606&id=266911#toc Repository: rG LLVM Github

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG47c4b8bd6869: [analyzer] Generalize bitwise OR rules for ranges (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://r

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f57d76a8dd0: [analyzer] Refactor range inference for symbolic expressions (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG73c120a9895a: [analyzer] Introduce reasoning about symbolic remainder operator (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

This revision was automatically updated to reflect the committed changes. Closed by commit rG5395389475bc: [analyzer] SATestBuild.py: Make verbosity level a cmd option (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80626/new/

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

vsavchenko added a comment. Sorry for postponing this review. I'll get to it right away! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:32 +BO_GE < BO_EQ && BO_EQ < BO_NE, +"This class relies on operators order. Rework it otherwise."); + +1 for this static ass

[PATCH] D78933: [analyzer] RangeConstraintManager optimizations in comparison expressions

vsavchenko added a comment. Great job! Thank you for your work! I would say, fixing a couple of minor style issues and testing it on a few more projects, and it is ready to land! > Another point is that I don't know how to get printed stats from the > scan-build. That option in `scan-build`

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + Szelethus wrote: > baloghadamsoftware wrote: > > Szelethus wrote: > > > This mustn't be serious. `StackFrameContext::getIndex()` h

[PATCH] D83836: [Analyzer] Implementing checkRegionChanges for SmartPtrModeling

vsavchenko added a comment. Additionally, I would prefer commit message to be imperative. It is sorta like a rule of a good commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83836/new/ https://reviews.llvm.org/D83836 __

[PATCH] D77062: [analyzer] Improved zero assumption in CStringChecke::assumeZero

vsavchenko added a comment. It is a good practice in many projects to make commit messages into imperative (i.e. "Improve" instead of "Improving" or "Improved"). Again, not everyone follows it, but it is good to keep it consistent, right? @NoQ knock-knock! Comment at: clang

[PATCH] D83877: [Analyzer] Changed in SmartPtrModeling to handle Swap

vsavchenko added a comment. The same thing with the commit message here, it would be better as just "Change" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83877/new/ https://reviews.llvm.org/D83877 ___

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, Szelethus, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Whith the number

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko updated this revision to Diff 278454. vsavchenko added a comment. Rename function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/ https://reviews.llvm.org/D82381 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/R

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko marked an inline comment as done. vsavchenko added a comment. In D83942#2155762 , @Szelethus wrote: > I don't speak snek, but I approve this message! Thanks 😊 > I suppose LLVM could be a HUGE project? Yurp, LLVM, pytorch, (surprisingly!) CMa

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko added a comment. In D83942#2156320 , @NoQ wrote: > > Sizes assigned to the projects in this commit, do not directly > > correspond to the number of lines or files in the project. > > Maybe `QUICK`/`NORMAL`/`SLOW` then? Or by purpose: > `BENCHM

[PATCH] D83942: [analyzer][tests] Add a notion of project sizes

vsavchenko updated this revision to Diff 279738. vsavchenko added a comment. Make --projects and --max-size compatible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83942/new/ https://reviews.llvm.org/D83942 Files: clang/utils/analyzer/ProjectMa

[Differential] D82381: [analyzer] Introduce small improvements to the solver infra

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf531c1c7c0d5: [analyzer] Introduce small improvements to the solver infra (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

This revision was automatically updated to reflect the committed changes. Closed by commit rGf531c1c7c0d5: [analyzer] Introduce small improvements to the solver infra (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13d9878b8dc: [analyzer][solver] Track symbol equivalence (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D82445?vs=275981&id=279746#toc Repository: rG LLVM Github Monorep

[Differential] D83286: [analyzer][solver] Track symbol disequalities

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe63b488f2755: [analyzer][solver] Track symbol disequalities (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D83286?vs=

[Differential] D82445: [analyzer][solver] Track symbol equivalence

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13d9878b8dc: [analyzer][solver] Track symbol equivalence (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D82445?vs=275981&id=279081#toc Repository: rG LLVM Github Monorep

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

This revision was automatically updated to reflect the committed changes. Closed by commit rGe63b488f2755: [analyzer][solver] Track symbol disequalities (authored by vsavchenko). Changed prior to commit: https://reviews.llvm.org/D83286?vs=276729&id=279747#toc Repository: rG LLVM Github Monor

[PATCH] D84303: [analyzer][tests] Fix SATest update functionality

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Not all projects in the p

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

vsavchenko added a comment. In D83660#2167391 , @NoQ wrote: > In D83660#2166917 , @steakhal wrote: > > > Although I'm not the most experienced one here, I think it's good to go. > > > Let's wait for the test to be a

[PATCH] D84453: [clang-tidy] Suppress one unittest under ASan.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM, thanks for taking care of this! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84453/new/ https://reviews.llvm.org/D84453 ___

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:215 // The explicit NULL case. + // We know that 'location' cannot be non-null. This is what + // we call an "explicit" null dereference. Maybe "is defini

[PATCH] D84843: [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the fast fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84843/new/ https://reviews.llvm.org/D84843 __

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

vsavchenko accepted this revision. vsavchenko added a comment. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D84494 ___ cfe-commits mailing list cfe-c

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. LGTM! Thanks for all the investigative work! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84902/new/ https://reviews.llvm.org/D84902 __

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

vsavchenko added a comment. Other then the naming issue, I don't see any problems with this change! Comment at: clang/lib/Analysis/IssueHash.cpp:183 -std::string clang::GetIssueString(const SourceManager &SM, - FullSourceLoc &IssueLoc, -

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. NSErrorChecker u

[PATCH] D77551: [analyzer] Fix NSErrorChecker false positives

vsavchenko marked an inline comment as done. vsavchenko added a comment. In D77551#1964441 , @NoQ wrote: > Looks great, thanks! Do you already have commit access or should i commit > this for you? Thanks :-) No, I don't have commit access ===

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko added a comment. Hi everyone! I'm thinking about adding support for `__attribute((nonnull))__` as well, but it should be handled a bit differently. That annotation is for parameters and not for types, so the corresponding constraints should be generated only when entering the functio

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 255993. vsavchenko added a comment. Fix formatting issues in the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticAnalyzer/Checkers

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko marked 2 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:521 + // Annotations that we want to consider make sense only for types. + auto Region = dyn_cast_or_null(Location.getAsRegion());

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko added a comment. In D77722#1969391 , @Szelethus wrote: > In D77722#1969261 , @vsavchenko > wrote: > > > Hi everyone! > > I'm thinking about adding support for `__attribute((nonnull))__` as well, > > bu

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 256009. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 256017. vsavchenko added a comment. Get rid of nonessential 'auto' in variable declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticA

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko updated this revision to Diff 256020. vsavchenko added a comment. Remove more auto's Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722 Files: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.

[PATCH] D77722: [analyzer] Do not report NSError null dereference for _Nonnull params

vsavchenko added a comment. In D77722#1969551 , @NoQ wrote: > Thanks! > > I'll commit. Awesome! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77722/new/ https://reviews.llvm.org/D77722

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256306. vsavchenko added a comment. Add one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker.

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256318. vsavchenko added a comment. Add forgotten hunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256331. vsavchenko added a comment. Add extra check to be safe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullPara

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko marked 4 inline comments as done. vsavchenko added a comment. In D77806#1973616 , @NoQ wrote: > We're doing much more here than just fixing the CFError behavior; we're > actually making the whole analyzer respect these annotations in top frame.

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256530. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullParamChecker

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Objective-C Clas

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko updated this revision to Diff 258003. vsavchenko added a comment. Fix unfinished comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files: clang/include/clang/StaticAnalyzer/Core/PathSensi

[PATCH] D81315: [analyzer][Draft] [Prototype] warning for default constructed unique pointer dereferences

vsavchenko added a comment. Great start! I think you are on the right track, so maybe this code won't be thrown away at all :-) Try to work on tests and get familiar with `lit`. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:31 namespace { -class SmartPtrM

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

vsavchenko added a comment. Done, sorry for taking so long! Thank you for your work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 ___ cfe-commits mailing lis

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

This revision was automatically updated to reflect the committed changes. Closed by commit rG29353e69d25c: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation (authored by AbbasSabra, committed by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D81565: [analyzer] SATestAdd.py: Parse arguments with argparse

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81564: [analyzer] SATest: Add posibility to download source from git and zip

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81563: [analyzer] SATest: Move from csv to json project maps

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. JSON format is a bit more

[PATCH] D81566: [analyzer] CmpRuns.py: Decouple main functionality from argparse

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. It makes it much harder t

[PATCH] D81569: [analyzer] SATest: Add option to specify projects to test

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81568: [analyzer] ProjectMap: Do not serialize fields with default values

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Static analysis is very s

[PATCH] D81572: [analyzer] SATest: Add convenience 'docker' command

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. It provides a simpler int

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D81567: [analyzer] SATest: Introduce a single entrypoint for regression scripts

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/utils/analyzer/CmpRuns.py:526-529 +if __name__ == "__main__": +print("CmpRuns.py should not be used on its own.") +print("Please use 'SATest.py compare' instead") +sys.exi

  1   2   3   4   5   6   7   8   9   >