vsavchenko added a comment.

Performance-wise, I've investigated huge slowdowns on `tmux` and `pytorch`.

- `pytorch` build produces a lot of warnings and simply trashed my terminal.  I 
guess one time it had more troubles with displaying all that than the other.  
Here is a table with new times:

|               | pytorch                             |
| ------------- | ----------------------------------- |
| Time (before) | 2h21m33s                            |
| Time (after)  | 2h19m23s                            |
| Delta         | {icon info-circle color=blue} -1.5% |
|

As you can see, these numbers are //way// smaller than the original ones.

- `tmux` is a much smaller project, so I decided to run it **20** times for 
each case.

F12018491: boxplot.png <https://reviews.llvm.org/F12018491>
//After// consistently shows slower runtimes, but the overall difference (for 
median times) is only **+3%**.

I believe that as of now we can submit these modifications as is and explore 
performance optimizations later if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80117/new/

https://reviews.llvm.org/D80117



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to