vsavchenko added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/DereferenceChecker.cpp:215
// The explicit NULL case.
+ // We know that 'location' cannot be non-null. This is what
+ // we call an "explicit" null dereference.
----------------
Maybe "is definitely null" here? Otherwise it can be pretty confusing with a
double negation.
================
Comment at:
clang/test/Analysis/Inputs/expected-plists/conditional-path-notes.c.plist:270
<key>description</key><string>Dereference of null pointer (loaded from
variable 'x')</string>
- <key>category</key><string>Logic error</string>
+ <key>category</key><string>Memory error</string>
<key>type</key><string>Dereference of null pointer</string>
----------------
I might've missed some discussions on that matter, so please correct me on that.
In my opinion, null pointer dereference is not a memory error. Null address is
not a correct memory and never was, so it is a logic error that a special value
is being interpreted as the pointer to something.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84494/new/
https://reviews.llvm.org/D84494
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
