[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Manna added a comment. Herald added a project: All. LIT test (SemaCXX/attr-trivial-abi.cpp) is failing for x86 build of clang. The same failures are happening with our downstream X86 clang build. - TEST 'Clang :: SemaCXX/attr-trivial-abi.cpp' FAILED Script: --- : 'RUN:

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Manna added a comment. In D119017#3392984 , @devin.jeanpierre wrote: > In D119017#3392961 , @Manna wrote: > >> LIT test (SemaCXX/attr-trivial-abi.cpp) is failing for x86 build of clang. >> The same failures are

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

Manna added a comment. In D119017#3392996 , @devin.jeanpierre wrote: > In D119017#3392993 , @Manna wrote: > lf so, what target triple, so that I can reproduce? (New to clang development...) >> >> You c

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

This revision was automatically updated to reflect the committed changes. Closed by commit rG06c9cc7eaa8a: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D157989: [NFC] Initialize pointer field

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added a subscriber: hiraditya. Herald added a project: All. Manna requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo

[PATCH] D157989: [NFC] Initialize pointer field

Manna added a comment. Thank you @tahonermann for reviews and feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157989/new/ https://reviews.llvm.org/D157989 ___ cfe-commits mailing list cfe-commit

[PATCH] D157989: [NFC] Initialize pointer field

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd1ddc5850b1: [NFC][OpenMP] Initialize pointer field (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157989/new/ https://reviews.llvm.org

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

Manna created this revision. Manna added reviewers: RKSimon, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/53426 Repository: rG LLVM Github Monorepo https://rev

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo htt

[PATCH] D158293: [NFC][CLANG] Fix potential dereferencing of null return values

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Manna requested review of this revision. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D158295: [NFC][clang][analyzer] Avoid potential dereferencing of null pointer value

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann, steakhal. Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna updated this revision to Diff 552347. Manna retitled this revision from "[NFC][CLANG] Fix potential dereferencing of null return values" to "[NFC][Clang] Fix static code analyzer concern about null value dereference". Manna added a comment. Herald added subscribers: manas, ASDenysPetrov, dk

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2009-2010 (Line.MightBeFunctionDecl || Line.InPPDirective) && - Current.NestingLevel == 0 && + Current.NestingLevel == 0 && Current.Previous &&

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

Manna added a comment. Thank you @aaron.ballman for reviews and feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158227/new/ https://reviews.llvm.org/D158227 ___ cfe-commits mailing list cfe-comm

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added subscribers: ctetreau, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clan

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna added a comment. In D158522#4607054 , @sdesmalen wrote: > It indeed makes sense to pass these by reference. Thank you @sdesmalen for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna updated this revision to Diff 552428. Manna added a comment. Fix build errors. I have updated CodeGenFunction.h as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGen

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna added a comment. In D158522#4607628 , @tahonermann wrote: > Looks fine to me! Thanks @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 _

[PATCH] D158488: [NFC] Initialize member pointers to nullptr.

Manna added a comment. This has already been addressed by https://reviews.llvm.org/D157989 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158488/new/ https://reviews.llvm.org/D158488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna updated this revision to Diff 552706. Manna edited the summary of this revision. Manna removed reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://reviews.llvm.org/D158293 Files: clang/lib/Lex/PPDirecti

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:555 while (true) { CurLexer->Lex(Tok); tahonermann wrote: > I don't think this change is sufficient. If `CurLexer` is null, then the

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e150adaea7b: [NFC][clang] EditedSource::applyRewrites - useless call (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

Manna added a comment. The failure seems unrelated to my change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158227/new/ https://reviews.llvm.org/D158227 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

Manna added a comment. Failure is unrelated to my patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158522/new/ https://reviews.llvm.org/D158522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D158522: [NFC][CLANG] Fix static analyzer bugs about large copy by values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG30c60ec52f15: [NFC][CLANG] Fix static analyzer bugs about large copy by values (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

Manna added a comment. In D158227#4610219 , @dyung wrote: > In D158227#4610097 , @Manna wrote: > >> The failure seems unrelated to my change. > > Hi @Manna, I'm not sure which failure you are referring to, but the

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

Manna updated this revision to Diff 556273. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159474/new/ https://reviews.llvm.org/D159474 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h clang/lib/Analysis/UnsafeBufferUsage.cpp clang/lib/ExtractAPI/Serialization/SymbolGraphSe

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

Manna added a comment. Thank you @tahonermann for reviews and feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159474/new/ https://reviews.llvm.org/D159474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna updated this revision to Diff 554762. Manna marked an inline comment as done. Manna added a comment. Thanks @tahonermann for review and feedback. I have added an assert separately to tell which predicate failed if a failure occurs in future. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna updated this revision to Diff 554810. Manna added a comment. This patch splits all predicates and updates assert messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://reviews.llvm.org/D158293 Files: clang/lib/Lex/PPDirectives.cpp Index: clang/lib/Lex/PPD

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:494-495 ++NumSkipped; assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?"); + assert(CurLexer && "Invalid lexer value"); taho

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rG33b02d766eb8: [NFC][Clang] Fix static code analyzer concern about null value dereference (authored by Manna).

[PATCH] D158293: [NFC][Clang] Fix static code analyzer concern about null value dereference

Manna added a comment. In D158293#4629232 , @tahonermann wrote: > Thanks, Soumi, looks good to me! Thank you @tahonermann for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158293/new/ https://re

[PATCH] D159474: [NFC][CLANG] Fix static analyzer bugs about unnecessary object copies with auto

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. Manna requested review of th

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna marked an inline comment as done. Manna added a comment. ping @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. ping @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

Manna updated this revision to Diff 533589. Manna edited the summary of this revision. Manna added a comment. Thank you @erichkeane for review and comments. I have changed the types of variables MinElts and EltSize to uint64_t instead of the cast. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e12f5ab2df1: [CLANG] Fix uninitialized scalar field issues (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.l

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues

Manna added a comment. Thank you everyone for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. Thank you @tahonermann and @aaronpuchert for reviews and comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D150931: [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign

This revision was automatically updated to reflect the committed changes. Closed by commit rG11528fceac6b: [Clang] Fix Static Code Analysis Concerns with copy without assign (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/ne

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

Manna added a comment. Thank you for reviews @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

This revision was automatically updated to reflect the committed changes. Closed by commit rG982a87ab74d8: [CLANG] Fix potential null pointer dereference bugs (authored by Manna). Changed prior to commit: https://reviews.llvm.org/D153033?vs=532138&id=533742#toc Repository: rG LLVM Github Mon

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && + LHSBuiltinTy && RHSBuiltinTy && Context.getBuiltinVectorTypeInfo(LHSBuiltinTy).E

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

Manna added a comment. Thank you @tahonermann and @tra for reviews and comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151606/new/ https://reviews.llvm.org/D151606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D151606: [NFC][CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in getNVPTXLaneID()

This revision was automatically updated to reflect the committed changes. Closed by commit rG213709e7be03: [CLANG] Fix Static Code Analyzer Concerns with bad bit right shift operation in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

This revision was automatically updated to reflect the committed changes. Closed by commit rG7372c0d46d21: [CLANG] Fix potential integer overflow value in getRVVTypeSize() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153146/new/

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rGa806ec4857c2: [analyzer] Refactor codes in findMethodDecl() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152194/new/ https://reviews.l

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. Thanks @erichkeane. Is this known failure? Failed Tests (1): Clang :: SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp https://buildkite.com/llvm-project/premerge-checks/builds/145026#01874e21-00e2-47a9-9bc4-975357d197ef Repository: rG LLVM Gith

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. In D147574#4245881 , @erichkeane wrote: > In D147574#4245877 , @Manna wrote: > >> Thanks @erichkeane. >> >> Is this known failure? >> >> Failed Tests (1): >> >> Clang :: >> SemaCXX/warn-

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. In D147574#4246004 , @aaron.ballman wrote: > LGTM Thank you @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 _

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. I have committed the patch here: https://reviews.llvm.org/rG59cb47015a18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 ___ cfe-commits

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, arphaman, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna updated this revision to Diff 511478. Manna added a comment. Thanks @erichkeane for reviews. I have updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/Sema/CodeComplete

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna added a comment. I have uploaded wrong one. I will fix it with new patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna updated this revision to Diff 511486. Manna added a comment. I have addressed @erichkeane's review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/Sema/SemaCodeComplete.c

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna updated this revision to Diff 511547. Manna added a comment. Fix clang-format error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/Sema/SemaCodeComplete.cpp clang/lib/Sema/Sema

[PATCH] D147757: Fix static analyzer tool remarks about unchecked return values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, luismarques, s.egerton, dkrupp, donat.nagy, Szelethus, PkmX, a.sidorin, simoncook, baloghadamsoftware, kristof.beyls, arichardson. Herald added a reviewer: NoQ. Herald ad

[PATCH] D147757: Fix static analyzer tool remarks about unchecked return values

Manna abandoned this revision. Manna added a comment. Closing this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147757/new/ https://reviews.llvm.org/D147757 ___ cfe-commits mailing list cfe-co

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel

[PATCH] D147791: [NFC][CLANG] Fix static analyzer tool remarks about unchecked return values

Manna added a comment. In D147791#4251497 , @erichkeane wrote: > I don't see much value in these changes. In the cases I know anything about, > the change in state (or out params) is the error checking that we need. The > casts add nothing but noise,

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna added a comment. Thanks @erichkeane. I have committed the patch here: https://reviews.llvm.org/rG33cf2a39cb11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 ___ cfe-commits mailing list cfe-co

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added a reviewer: ributzka. Herald added a project: All. Manna requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Reported by Coverity Static Analyzer Tool: Big para

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

Manna added a comment. x64 debian failures seem unrelated to my fix: https://lab.llvm.org/buildbot/#/builders/21/builds/67315/steps/6/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147901/new/ https://reviews.llvm.org/D147901 __

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna closed this revision. Manna added a comment. I am closing this revision since it's already been pushed https://reviews.llvm.org/rG33cf2a39cb11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 _

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna closed this revision. Manna added a comment. I am closing this revision since it's already been pushed: https://reviews.llvm.org/rG59cb47015a18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 _

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald ad

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna added a comment. Thank you @aaron.ballman for reviews and feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148189/new/ https://reviews.llvm.org/D148189 ___ cfe-commits mailing list cfe-commi

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

Manna added a comment. The lit test failure seem unrelated to my fix: https://buildkite.com/llvm-project/premerge-checks/builds/146438#0187786e-2f04-40a2-acf1-78eee9f00e7f Failed Tests (1): Clang :: SemaCXX/warn-unsafe-buffer-usage-fixits-pre-increment.cpp Repository: rG LLVM Github Monore

[PATCH] D150968: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Coverity: In clang::​FunctionDecl::​isRep

[PATCH] D150968: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna added a comment. Thank you @erichkeane for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150968/new/ https://reviews.llvm.org/D150968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rGbe37e3e25982: [NFC][CLANG] Fix dereference issue before null check found by Coverity static… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1190 class ParseScopeFlags { Scope *CurScope; +unsigned OldFlags = 0; tahonermann wrote: > shafik wrote: > > @tahonermann I feel like we should have a default member initializ

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523957. Manna added a comment. I have addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h clang/include/clang/StaticA

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna marked 2 inline comments as done. Manna added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h:323-324 + // The copy assignment operator is defined as deleted pending further + // motivation. + SExpr &operator=(const SExpr &) = delet

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Coverity

[PATCH] D150968: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG34d8cd153812: [NFC][CLANG] Fix issue with dereference null return value found by Coverity… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna updated this revision to Diff 523983. Manna added a comment. Fix Clang-format error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 Files: clang/lib/ARCMigrate/ObjCMT.cpp Index: clang/lib/ARCMigrate/ObjCMT.cpp ===

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna updated this revision to Diff 523986. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 Files: clang/lib/ARCMigrate/ObjCMT.cpp Index: clang/lib/ARCMigrate/ObjCMT.cpp === ---

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna abandoned this revision. Manna added a comment. This is False Positive. We are correctly checking type mismatch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 ___ cfe-commits mailing list cfe

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 524044. Manna marked 2 inline comments as done. Manna added a comment. I have updated patch to resolve build errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 Files: clang/include/clang/Analysis/Anal

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. In D150931#4358903 , @aaronpuchert wrote: > Changes to `ThreadSafetyTIL.h` look good to me, thanks! Thank you @aaronpuchert for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org

[PATCH] D151040: [NFC][CLANG] Fix static analyzer concerns

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Dereference null return value Inside "ExprConstant.cpp"

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna abandoned this revision. Manna added a comment. This is False Positive. We are correctly checking type mismatch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 ___ cfe-commits mailing list cfe

[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 524291. Manna added a comment. Thank you @erichkeane for reviews. I have updated patch to avoid regression if the LValue doesn't evaluate right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151040/new/ https://reviews.llvm.org/D151040 Files: clan

[PATCH] D151130: [NFC][CLANG] Fix static code analyzer concerns with dereference null return value

Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static Analyzer Tool: Inside "SemaExprMember

[PATCH] D151137: ]NFC][Clang] Fix Coverity bug with dereference null return value in clang::​CodeGen::​CodeGenFunction::​EmitOMPArraySectionExpr()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Reported by Coverity: Inside "CGExpr.cpp" file, in clang::​CodeGen::​CodeGenFunction::​EmitOMPArraySectionExpr(clang::​OMPArraySectionExpr const *, bool): Retu

[PATCH] D151130: [NFC][CLANG] Fix static code analyzer concerns with dereference null return value

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151130/new/ https://reviews.llvm.org/D151130 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151137: ]NFC][Clang] Fix Coverity bug with dereference null return value in clang::​CodeGen::​CodeGenFunction::​EmitOMPArraySectionExpr()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151137/new/ https://reviews.llvm.org/D151137 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151130: [NFC][CLANG] Fix static code analyzer concerns with dereference null return value

This revision was automatically updated to reflect the committed changes. Closed by commit rG7586aeab7ad3: [NFC][CLANG] Fix static code analyzer concerns with dereference null return… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D151137: ]NFC][Clang] Fix Coverity bug with dereference null return value in clang::​CodeGen::​CodeGenFunction::​EmitOMPArraySectionExpr()

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc6a6c48d4bb: [NFC][Clang] Fix Coverity bug with dereference null return value in clang… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG64e9ba7048b8: [NFC][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151040/new/ https://reviews.

[PATCH] D151054: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG806b0cd5ab56: [NFC][CLANG] Fix issue with dereference null return value found by Coverity… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static An

[PATCH] D151281: [NFC][CLANG] Fix issue with dereference null return value found by Coverity

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static Analyzer Tool, Coverity: Inside "SemaDeclCXX.cpp" file, in clang::​Sema::​CheckExplicitlyDefaultedSpecialMember

[PATCH] D151281: [NFC][CLANG] Fix issue with dereference null return value found by Coverity

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151281/new/ https://reviews.llvm.org/D151281 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D151280: [NFC][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 525388. Manna added a comment. Thank you @erichkeane for reviews! I have updated assert message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151280/new/ https://reviews.llvm.org/D151280 Files: clang/lib/CodeGen/CGExprConstant.cpp Index: clang/l

[PATCH] D151281: [NFC][CLANG] Fix issue with dereference null return value found by Coverity

This revision was automatically updated to reflect the committed changes. Closed by commit rGad571e0d84b3: [NFC][CLANG] Fix issue with dereference null return value found by Coverity (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

Manna created this revision. Manna added a reviewer: erichkeane. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses cast instead of dyn_cast which will assert if the type doesn't match. Repository: rG LLVM Github Monorepo http

[PATCH] D151469: [NFC][CLANG] Fix issue with dereference null return value in EvaluateBuiltinClassifyType()

Manna updated this revision to Diff 525697. Manna added a comment. Thank you @erichkeane for reviews! I have updated patch to avoid the regression. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151469/new/ https://reviews.llvm.org/D151469 Files: clang/lib/AST/ExprConstant.cpp Index

  1   2   3   >