Manna marked an inline comment as done.
Manna added inline comments.
================
Comment at: clang/lib/Lex/PPDirectives.cpp:555
while (true) {
CurLexer->Lex(Tok);
----------------
tahonermann wrote:
> I don't think this change is sufficient. If `CurLexer` is null, then the
> `else` branch will be entered and an unconditional dereference occurs there
> as well. It looks like more analysis is needed, but perhaps the correct fix
> is to add a non-null assertion somewhere above.
Thank you @tahonermann for review and feedback. Yes, my analysis was wrong.
>>perhaps the correct fix is to add a non-null assertion somewhere above.
It sounds reasonable to me. I have added an assert above.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158293/new/
https://reviews.llvm.org/D158293
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
