This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Manna marked an inline comment as done.
Closed by commit rG33b02d766eb8: [NFC][Clang] Fix static code analyzer concern
about null value dereference (authored by Manna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158293/new/
https://reviews.llvm.org/D158293
Files:
clang/lib/Lex/PPDirectives.cpp
Index: clang/lib/Lex/PPDirectives.cpp
===================================================================
--- clang/lib/Lex/PPDirectives.cpp
+++ clang/lib/Lex/PPDirectives.cpp
@@ -491,7 +491,9 @@
llvm::SaveAndRestore SARSkipping(SkippingExcludedConditionalBlock, true);
++NumSkipped;
- assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?");
+ assert(!CurTokenLexer && "Conditional PP block cannot appear in a macro!");
+ assert(CurPPLexer && "Conditional PP block must be in a file!");
+ assert(CurLexer && "Conditional PP block but no current lexer set!");
if (PreambleConditionalStack.reachedEOFWhileSkipping())
PreambleConditionalStack.clearSkipInfo();
Index: clang/lib/Lex/PPDirectives.cpp
===================================================================
--- clang/lib/Lex/PPDirectives.cpp
+++ clang/lib/Lex/PPDirectives.cpp
@@ -491,7 +491,9 @@
llvm::SaveAndRestore SARSkipping(SkippingExcludedConditionalBlock, true);
++NumSkipped;
- assert(!CurTokenLexer && CurPPLexer && "Lexing a macro, not a file?");
+ assert(!CurTokenLexer && "Conditional PP block cannot appear in a macro!");
+ assert(CurPPLexer && "Conditional PP block must be in a file!");
+ assert(CurLexer && "Conditional PP block but no current lexer set!");
if (PreambleConditionalStack.reachedEOFWhileSkipping())
PreambleConditionalStack.clearSkipInfo();
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
