Manna added a comment. In D147791#4251497 <https://reviews.llvm.org/D147791#4251497>, @erichkeane wrote:
> I don't see much value in these changes. In the cases I know anything about, > the change in state (or out params) is the error checking that we need. The > casts add nothing but noise, so I don't think these are good changes. Thanks @erichkeane for reviews and feedback. I agree with you that all changes will silence the static analyzer tool but will not make any big impact. I can close them as a False positive if you are OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147791/new/ https://reviews.llvm.org/D147791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
