[PATCH] D48989: -fdebug-prefix-map option for cc1as

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This seems reasonable if you need the support in the assembler. However, please add a test to ensure that the paths are mapped when invoking the assembler rather than the compiler. Repo

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

compnerd created this revision. compnerd added reviewers: xiaobai, beanz, smeenai. Herald added a subscriber: mgorny. Herald added a project: clang. This adds the clang-cl and clang++ symlinks. Since there are no targets to depend on for this, we cannot force the creation of the symlinks. Furth

[PATCH] D69194: build: add clang-cl and clang++ symlinks in the build tree

compnerd abandoned this revision. compnerd added a comment. I think I must have had something else in my tree, cause a clean build does build them. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69194/new/ https://reviews.llvm.org/D69194 __

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); I don't see a pattern match for the `cls64` on ARM32, would that not fail to lower? ==

[PATCH] D51899: Remove extraneous ".a" suffix from baremetal clang_rt.builtins when compiling for baremetal.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is not a linker specific thing - the library name that we are passing is misnamed - the parameter should be `-l` which will become `lib` ` [`.so` | `.a`]. If we want to guarantee th

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); vhscampos wrote: > compnerd wrote: > > I don't see a pattern match for the `cls64` on ARM32, woul

[PATCH] D69250: [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE

compnerd added inline comments. Comment at: clang/lib/Headers/arm_acle.h:150 +__clsl(unsigned long __t) { +#if __SIZEOF_LONG__ == 4 + return __builtin_arm_cls(__t); vhscampos wrote: > compnerd wrote: > > vhscampos wrote: > > > compnerd wrote: > > > > I don't see

[PATCH] D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks for all the adjustments, this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69250/new/ https://reviews.llvm.org/D69250

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

compnerd accepted this revision. compnerd added a comment. This seems fine with the minor thing that the original check was not incorrect, merely not as portable, `__BYTE_ORDER__` is more portable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7985

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

compnerd closed this revision. compnerd added a comment. Merged as rG68c50708d1f2b9aee3f10ec710df0b1387f701e5 . Thanks for the portability fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D84691: [CMake] Move find_package(ZLIB) to LLVMConfig

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks, this is a great idea! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84691/new/ https://reviews.llvm.org/D84691 __

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:173 + Arg *A = Args.getLastArg(options::OPT_g_Group); + if (A && !A->getOption().matches(options::OPT_g0) && + !A->getOption().matches(options::OPT_gstabs)) Why not hoist th

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd created this revision. compnerd added a reviewer: ldionne. Herald added subscribers: libcxx-commits, dexonsmith. Herald added a project: libc++. Herald added a reviewer: libc++. When building with a non-modularized C runtime, `csignal` would claim `time.h` and thus `timespec` rather than

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd added a comment. @dexonsmith - yeah, sadly I dont think that there is a good way to audit that - any change to the public headers can cause issues. Furthermore, the libc headers themselves also influence this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd added a comment. I think that a `clang-pcm` like tool would be **incredible**. Working with modules is somewhat frustrating because there is no good supported way to see what the module structure that clang actually sees. But that goes well beyond an attempt to repair the NetBSD buil

[PATCH] D82767: clang-format: Explicitly use python3

compnerd added a comment. The thread that I was basing the timeline from is http://lists.llvm.org/pipermail/llvm-dev/2020-January/138730.html. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82767/new/ https://reviews.llvm.org/D82767 ___ cfe

[PATCH] D82767: clang-format: Explicitly use python3

compnerd added a subscriber: arsen. compnerd added a comment. Thinking a bit more about this, using `/usr/bin/env python` ensures that we actually honour the python version that the user specifies because that allows the user control over the python symlink pointing to either python2 or python3.

[PATCH] D83426: Unbreak Clang standalone build.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable to me, this seems like it would be useful to downstream packagers for Linux distros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D83426: Unbreak Clang standalone build.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7a5ad56b60: repair standalone clang builds (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83426/new/ https://reviews.llvm.org/D8342

[PATCH] D82259: Deprecate error prone temporary directory APIs

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3177 llvm::sys::path::append(Result, "ModuleCache"); } This default path is not ideal for Linux. On Linux, if we want to put this into the home directory, we should follow X

[PATCH] D82259: Deprecate error prone temporary directory APIs

compnerd added a comment. Thanks @davezarzycki! Minor nit: git-clang-format the patch please, there was at least one linter warning in the changed code. I do wonder if we can get away with the removal of the API though doing that in a follow up is pretty reasonable to me. I think that one min

[PATCH] D82362: Move default module cache from system temporary directory

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm.org/D82362 ___

[PATCH] D82767: clang-format: Explicitly use python3

compnerd added a comment. While I really like this idea of migrating the scripts to python3, I believe that the current plan is to allow until December for users to migrate, so this might be a bit premature :-(. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82767/new/ https://reviews.

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd updated this revision to Diff 259923. compnerd added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Include clang as some of the CI uses the unified build which fails without the update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd added a comment. @JDevlieghere I dont think that adding another mechanism for finding the python executable is not the right approach. You already have the variables that you are talking about, you just need to specify it in triplicate if you want compatibility across all the versions

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd updated this revision to Diff 259987. compnerd added a comment. Adjust clang-tools-extra at the same time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762 Files: clang-tools-extra/test/lit.site.cf

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd updated this revision to Diff 260010. compnerd added a comment. Add missed case of `PYTHON_EXECUTABLE` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762 Files: clang-tools-extra/test/lit.site.cfg.p

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd added a comment. @JDevlieghere I think that for LLDB, which this patch does not touch, the proper thing to do is to have 2 different paths with the ability to explicitly opt into the path, i.e. `LLDB_USE_PYTHON2:BOOL` and `LLDB_USE_PYTHON3:BOOL` with `CMakeDependentOption` to prevent t

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: llvm/CMakeLists.txt:696 +message(WARNING "Python3 not found, using python2 as a fallback") +find_package(Python3 COMPONENTS Interpreter REQUIRED) +if(Python2_VERSION VERSION_LESS 2.

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd closed this revision. compnerd added a comment. rGcd84bfb8142bc7ff3a07a188ffb809f1d86d1fd7 (with the Python2 fixes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd added a comment. I was trying to do the minimal change to cover llvm. I definitely care about LLD and will do that in a subsequent change. As to the benefit of this, it is primarily that the detection here explicitly ensures that python3 is used rather than python2. The fallback of a

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd abandoned this revision. compnerd added a comment. Given that the original motivation here was to help with NetBSD, and the submodule visibility flag handling unblocks NetBSD, I think that I will hold off on this unless some other motivation arises. Repository: rG LLVM Github Monore

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

compnerd added a comment. What happens if you encounter a `"\t"` as a string? This would convert that to a `"/t"` would it not? Although, I suppose that in practice the treatment of escaped characters is not important. I think I still prefer the `} else {` here over the early return. CHANG

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, especially since none of the other tests break. I don't fully remember the reason for the special case, and if it ever turns up, we can address it then. CHANGES SINCE

[PATCH] D40660: Enable auto-linking on Windows

compnerd created this revision. Herald added a subscriber: cfe-commits. The MSVC driver and clang do not link against the C++ runtime explicitly. Instead, they rely on the auto-linking via the pragma (through `use_ansi.h`) to link against the correct version of the C++ runtime. Attempt to do som

[PATCH] D40660: Enable auto-linking on Windows

compnerd updated this revision to Diff 124976. compnerd added a comment. Fix pragma, ensure that we do not try to recursively link. https://reviews.llvm.org/D40660 Files: include/__config Index: include/__config === --- include

[PATCH] D40660: Enable auto-linking on Windows

compnerd added inline comments. Comment at: include/__config:1266 +#if defined(_LIBCPP_ABI_MICROSOFT) +# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY) +# if defined(_LIBCPP_DEBUG) smeenai wrote: > rnk wrote: > > smeenai wrote: > > > This feels more lik

[PATCH] D40660: Enable auto-linking on Windows

compnerd updated this revision to Diff 124983. compnerd added a comment. @rnk/@smeenai don't want future proofing Repository: rCXX libc++ https://reviews.llvm.org/D40660 Files: include/__config Index: include/__config === --

[PATCH] D40660: Enable auto-linking on Windows

compnerd added inline comments. Comment at: include/__config:1267 +# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY) +# if defined(_LIBCPP_DEBUG) +# pragma comment(lib, "c++d.lib") smeenai wrote: > compnerd wrote: > > smeenai wrote: > > > I guess `_D

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I'm okay with this change in principle, but Im worried that this may break the buildbots. Please ensure that they remain green after this change. Repository: rL LLVM https://reviews.l

[PATCH] D40660: Enable auto-linking on Windows

compnerd closed this revision. compnerd added a comment. SVN r319816 Repository: rCXX libc++ https://reviews.llvm.org/D40660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

compnerd accepted this revision. compnerd added a comment. LGTM if @sdardis is good with it https://reviews.llvm.org/D38110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

compnerd added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:1923 + Tok, *this, diag::err_feature_check_malformed); + return II ? getTargetInfo().getTriple().getArchName().equals_lower( + II->getName()) H

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

compnerd added inline comments. Comment at: include/__libunwind_config.h:73 +# elif defined(_ABIN32) && defined(__mips_soft_float) +#define _LIBUNWIND_TARGET_MIPS_NEWABI 1 +#define _LIBUNWIND_CONTEXT_SIZE 35 Minor nit: I prefer either `NABI` or `NEW_ABI`

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. It would be good to straighten out the corner case of the canonicalized vs specified triple before merging this as that would make it harder to change. Minor nit with the style, I'm not to

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

compnerd added inline comments. Comment at: cmake/Modules/GNUBinaryDirs.cmake:3 + get_filename_component(CMAKE_LIBDIR_BASENAME "${CMAKE_INSTALL_LIBDIR}" NAME) +endif() + Should this perhaps be moved further down near the usage? Comment at: cma

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

compnerd added inline comments. Comment at: clang/include/clang/Config/config.h.cmake:57 +/* Multilib basename for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "${CLANG_INSTALL_LIBDIR_BASENAME}" Does this not potentially break downstreams? Repository:

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Since it has been deprecated for 2 releases, it seems reasonable to cleanup. This seems good to me from the build side, please do wait a bit for anyone else to chime in on this. Reposit

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. Herald added a subscriber: cfe-commits. The Windows SDK has occurrences of the `i128` and `ui128` suffix (at least in

[PATCH] D111457: [test] Add lit helper for windows paths

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, though I'm not a fan of the variable names - they seem a bit difficult to read due to no separation (e.g., `%fs-src-root` or `%fs_src_root` vs `%fssrcroot`) Repository:

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/debug-prefix-map.c:7 +// RUN: %clang -g -fdebug-prefix-map=%p=%{fssrcroot}UNLIKELY_PATH%{fssep}empty -S -c %s -emit-llvm -o - | FileCh

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd added a comment. This was something that I was hitting an issue with. In particular, it was a module build for a module which pulled in intsafe.h. Now, given that it is a preprocessor macro, it would stand to reason that it will normally be dropped and thus won't matter if the fronte

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

compnerd added a comment. I don't have an example module sadly. It was something that I ran into with Swift code import the WinSDK module defined in https://github.com/apple/swift/blob/main/stdlib/public/Platform/winsdk.modulemap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:10 #include "RISCV.h" +#include "../Clang.h" #include "ToolChains/CommonArgs.h" This feels like a layering violation. I suppose that as long as modular builds are okay ...

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(cl

[PATCH] D130190: [Driver] Error for -gsplit-dwarf with RISC-V linker relaxation

compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:146 +Arg *A; +if (getDebugFissionKind(D, Args, A) != DwarfFissionKind::None) + D.Diag(clang::diag::err_drv_riscv_unsupported_with_linker_relaxation) MaskRay wrote:

[PATCH] D130446: [apinotes] Upstream changes to `APINotesYAMLCompiler.cpp`.

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Can you please add a round trip test as well? Additionally, please add a proper commit message to describe the change here. Comment at: clang/lib/APINotes/API

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

compnerd added a comment. Herald added a project: All. The sema portions of this change are still causing an issue. Although the revert (rGf95bd18b5faa6a5af4b5786312c373c5b2dce687 ) and the subsequent re-application in rG3466

[PATCH] D126093: Sema: adjust assertion to account for deduced types

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. Previous changes for the BTF attributes introduced a new sub-tree visitation. That uncovered that when accessing the

[PATCH] D126093: Sema: adjust assertion to account for deduced types

compnerd updated this revision to Diff 431084. compnerd added a comment. git-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126093/new/ https://reviews.llvm.org/D126093 Files: clang/include/clang/Sema/DeclSpec.h clang/test/Sema/typerep-typespec.c Index: clang/test/Sem

[PATCH] D126093: Sema: adjust assertion to account for deduced types

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGb159108bc5eb: Sema: adjust assertion to account for deduced types (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D126093?vs=431084&i

[PATCH] D66446: [clang][IFS] Adding new Interface Stubs format.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Please add a test case for read/write, otherwise LGTM. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:383 +auto VD = cast(E.first)->getType

[PATCH] D66573: [clang][ifs] Dropping older experimental interface stub formats.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Please add a diagnostic to indicate that the provided value is invalid for the argument (or at at least extend the existing the tests to ensure that the old values are diagnosed in the dri

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

compnerd added a comment. I think that this is pretty easy to forget. Fortunately, last argument wins. Why not sink this into the `%clang` substitution in lit? That ensures that we run with an empty sysroot and then when the test needs to adjust the sysroot, it can do so explicitly. Reposi

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

compnerd added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:122-131 if (TC.getArch() == llvm::Triple::x86) CmdArgs.push_back("i386pe"); - if (TC.getArch() == llvm::Triple::x86_64) + else if (TC.getArch() == llvm::Triple::x86_64) CmdArgs.push_back("i

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

compnerd accepted this revision. compnerd added a comment. Yeah, I think that this is okay. https://reviews.llvm.org/D36364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

compnerd accepted this revision. compnerd added a comment. Would be nice to split up the PPC fixes into its own commit. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D70764: build: reduce CMake handling for zlib

compnerd closed this revision. compnerd added a comment. GIT 68a235d07f9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70764/new/ https://reviews.llvm.org/D70764

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftObjCMembers : Attr { + let Spellings = [GNU<"swift_objc_members">]; aaron.ballman wrote: > Should this be inherited by redec

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

compnerd added a comment. Discussed this with @aaron.ballman offline; he is okay with this since this is not going to permit incorrect code through without a diagnostic, even if it is not the most clear and the attribute wont be accidentally ignored. We can add more diagnostics as a follow up

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

compnerd updated this revision to Diff 291269. compnerd added a comment. address feedback from @aaron.ballman and @gribozavr2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87395/new/ https://reviews.llvm.org/D87395 Files: clang/include/clang/Bas

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftBridgedTypedef : Attr { + let Spellings = [GNU<"swift_bridged_typedef">]; aaron.ballman wrote: > Should this be inherited on redeclarations? I don't see why not. @rjm

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: clang. compnerd requested review of this revision. This extends semantic analysis of attributes for Swift interoperability by introducing the `swift_bridge` attribute. This attribute enables bridging

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: clang. compnerd requested review of this revision. This introduces the new `swift_name` attribute that allows annotating interfaces with an alternate spelling for Swift. This is used as part of the i

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2173 + SubjectList<[Enum, EnumConstant, Field, Function, GlobalVar, Struct, TypedefName, + ObjCInterface, ObjCClassMethod, ObjCInstanceMethod, ObjCProperty, ObjCProtocol], +

[PATCH] D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87243/new/ https://reviews.llvm.org/D87243

[PATCH] D87331: Sema: add support for `__attribute__((__swift_error__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rGf5ab5b20fb2a: Sema: add support for `__attribute__((__swift_error__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87331?vs=290990&id=291336#toc Repository: rG LLVM Git

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291346. compnerd edited the summary of this revision. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2123 + let Spellings = [GNU<"swift_bridged_typedef">]; + let Subjects = SubjectList<[TypedefName], ErrorDiag, "typedefs">; + let Documentation = [SwiftBridgedTypedefDocs]; aaron.ball

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7543 + case ParsedAttr::AT_SwiftBridgedTypedef: +handleSimpleAttribute(S, D, AL); +break; aaron.ballman wrote: > compnerd wrote: > > aa

[PATCH] D87395: Sema: add support for `__attribute__((__swift_objc_members__))`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG916b43403588: Sema: add support for `__attribute__((__swift_objc_members__))` (authored by compnerd). Changed prior to commit: https://reviews.llv

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291587. compnerd added a comment. Add additional test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include/clang/Basic/Attr.td clang/include/c

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd marked 4 inline comments as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5535 + // Don't duplicate annotations that are already set. + if (D->hasAttr()) { +S.Diag(AL.getLoc(), diag::warn_duplicate_attribute) << AL.getAttrName();

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd updated this revision to Diff 291601. compnerd marked an inline comment as done. compnerd added a comment. Address some feedback from @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87532/new/ https://reviews.llvm.org/D87532

[PATCH] D87396: Sema: add support for `__attribute__((__swift_typedef_bridged__))`

compnerd updated this revision to Diff 291621. compnerd added a comment. - Add additional test case that was requested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDoc

[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2121 +def SwiftBridgedTypedef : Attr { + let Spellings = [GNU<"swift_bridged_typedef">]; compnerd wrote: > aaron.ballman wrote: > > Should

[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

compnerd updated this revision to Diff 291687. compnerd added a comment. - make the attribute inheritable - add a test case for inheritance - add a test case for C++ type alias Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://review

[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a reviewer: jdoerfert. Herald added a project: clang. compnerd requested review of this revision. Add the `swift_newtype` attribute which allows a type definition to be imported into Swift as a new type. The im

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2133 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; aaron.ballman wrote: > Is this a type or a declaration attribute? It looks like a declaration > attribute bas

[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d26d6a1b062: Sema: add support for `__attribute__((__swift_bridged_typedef__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87396?vs=291687&id=292009#toc Repository: r

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: clang. compnerd requested review of this revision. This attribute allows declarations to be restricted to the framework itself, enabling Swift to remove the declarations when importing libraries. Thi

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2134 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; + let Args = [StringArgument<"SwiftType">]; aaron.ballman wrote: > I

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd updated this revision to Diff 292018. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87532/new/ https://reviews.llvm.org/D87532 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Bas

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2173 + SubjectList<[Enum, EnumConstant, Field, Function, GlobalVar, Struct, TypedefName, + ObjCInterface, ObjCClassMethod, ObjCInstanceMethod, ObjCProperty, ObjCProtocol], +

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 8 inline comments as done. compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4289 +if (Inline->getName() != Name && !Inline->isImplicit()) { + Diag(Inline->getLocation(), diag::warn_attribute_ignored) << Inline; + Diag(CI.ge

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292253. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a01d9498a7: Sema: add support for `__attribute__((__swift_bridge__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87532?vs=292018&id=292273#toc Repository: rG LLVM Gi

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd marked 3 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:104 +def ObjCClassMethod +: SubsetSubjectisInstanceMethod()}], aaron.ballman wrote: > This change is no longer needed. Ah, right, I'll m

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd updated this revision to Diff 292299. compnerd marked 2 inline comments as done. compnerd added a comment. Address everything but warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87534/new/ https://reviews.llvm.org/D87534 Files: cl

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4289 +if (Inline->getName() != Name && !Inline->isImplicit()) { + Diag(Inline->getLocation(), diag::warn_attribute_ignored) << Inline; + Diag(CI.getLoc(), diag::note_conflicting_attribute);

<    1   2   3   4   5   6   7   >