compnerd added inline comments.
================
Comment at: cmake/Modules/GNUBinaryDirs.cmake:3
+ get_filename_component(CMAKE_LIBDIR_BASENAME "${CMAKE_INSTALL_LIBDIR}" NAME)
+endif()
+
----------------
Should this perhaps be moved further down near the usage?
================
Comment at: cmake/Modules/GNUBinaryDirs.cmake:6
+if (NOT DEFINED CMAKE_BINARY_BINDIR)
+ set(CMAKE_BINARY_BINDIR "${CMAKE_BINARY_BINDIR}/bin")
+endif()
----------------
arichardson wrote:
> I find this name a bit confusing, maybe something like `CMAKE_BUILD_BINDIR`
> (and the same for _LIBDIR/_INCLUDEDIR would be less surprising? That way it's
> clear that we are referring to binaries/libraries/includes in the build
> output (and it mirrors CMAKE_INSTALL_INCLUDEDIR, etc.)
I think you mean `${CMAKE_BINARY_DIR}/bin` as this is in a block where
`CMAKE_BINARY_BINDIR` is undefined.
================
Comment at: cmake/Modules/GNUBinaryDirs.cmake:10
+if (NOT DEFINED CMAKE_BINARY_INCLUDEDIR)
+ set(CMAKE_BINARY_INCLUDEDIR "${CMAKE_BINARY_DIR}/inc")
+endif()
----------------
Is the default spelling for include not `include` not `inc`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132608/new/
https://reviews.llvm.org/D132608
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
