compnerd added inline comments.
================ Comment at: clang/include/clang/Basic/Attr.td:2123 + let Spellings = [GNU<"swift_bridged_typedef">]; + let Subjects = SubjectList<[TypedefName], ErrorDiag, "typedefs">; + let Documentation = [SwiftBridgedTypedefDocs]; ---------------- aaron.ballman wrote: > compnerd wrote: > > aaron.ballman wrote: > > > Does the default diagnostic text generate something bad that caused you > > > to add `typedefs` here? > > I don't remember, I'll double check. > I noticed on a few other reviews that there was a field there, I wonder if > the code originated before we added smarter logic for arbitrary subject lists. Yes, this code is definitely old. If there are sites that you notice that could be changed to something new, Im happy to work though those changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
