compnerd marked an inline comment as done. compnerd added inline comments.
================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7543 + case ParsedAttr::AT_SwiftBridgedTypedef: + handleSimpleAttribute<SwiftBridgedTypedefAttr>(S, D, AL); + break; ---------------- aaron.ballman wrote: > compnerd wrote: > > aaron.ballman wrote: > > > Should there be any type checking that the underlying type of the typedef > > > is a sensible one to bridge? > > I can't really think of anything that you could check that would be > > valuable. What types of things were you thinking? > I was mostly thinking about builtin types like `int`, but I don't insist. Typedefing `int` to something else and importing that with a different name is reasonable I believe. I'll add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87396/new/ https://reviews.llvm.org/D87396 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
