[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE pengfei wrote: > probinson wrote: > > pengfei wrote: > > > probinson wrote: > > > > pengfei wrote: >

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1461fabfb141: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. R

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D153681: [X86] Move back _mulx_u32 to 32-bit only

probinson added a comment. I'm okay with putting this back if the codegen (D153620 ) can't be resolved. Honestly I didn't think it was a problem. But I think Craig or Simon should sign off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

probinson added a comment. In D141824#4229953 , @argentite wrote: > Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, > right? `UNSUPPORTED: target={{.*-(ps4|ps5)}}` please. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

probinson added a comment. In D141824#4231372 , @probinson wrote: > In D141824#4229953 , @argentite > wrote: > >> Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, >> right? > > `UNSUPPORT

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added subscribers: debug-info, probinson. probinson added a comment. I think we cannot be 100% sure about source paths in a cross-compile situation. Cross-compiling on platform A targeting platform B does not mean your sources and debugger UI are on platform B. My users keep source and

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D147461 Files: clang/lib/Headers/immintrin.h Index: clang/lib/Headers/immintrin.h ===

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson added a comment. FTR, I'll be working my way through a bunch of intrinsics over the next month or so, trying not to do too many at once. Mostly AVX2 but also some others. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147461/new/ https://reviews.llvm.org/D147461 _

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa82170fa41ca: [Headers] Add some intrinsic function descriptions to immintrin.h. (authored by probinson). Herald added a project: clang. Changed pri

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added a comment. An LLVM code change should be testable on its own; this has it tested by Clang. I think you need a new command-line option to set TargetOptions::UseTargetPathSeparator e.g. via llvm-mc. Other TargetOptions are handled this way. Repository: rG LLVM Github Monorepo

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D148021 Files: clang/lib/Headers/fmaintrin.h Index: clang/lib/Headers/fmaintrin.h

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added inline comments. Comment at: clang/lib/Headers/fmaintrin.h:22 +/// Computes a multiply-add of 128-bit vectors of [4 x float]. +///For each element, computes (__A * __B) + __C . +/// pengfei wrote: > We are using a special format to describute

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:156 +///A 256-bit vector containing one of the source operands. +/// \returns A 256-bit vector containing the sums. static __inline__ __m256i __DEFAULT_FN_ATTRS256 craig.topper wrote

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 524786. probinson added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h =

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 525632. probinson added a comment. Correct order of horizontal operands CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:456 +/// j := i*128 +/// result[j+31:j] := __a[j+63:j+32] - __a[j+31:j] +/// result[j+63:j+32] := __a[j+127:j+96] - __a[j+95:j+64] craig.topper wrote: > Intel intrinsics guide says

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson marked an inline comment as done. probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:412 +///vectors of [16 x i16] and returns the lower 16 bits of each difference +///in an element of the [16 x i16] result (overflow is ignored). +///

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. probinson marked an inline comment as done. Closed by commit rGd8291908ef49: [Headers][doc] Add add/sub/mul intrinsic descriptions to avx2intrin.h (authored by probinso

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. (Time to look for the next round of embarrassing mistakes...) https://reviews.llvm.org/D151749 Files: clang/lib/

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 526782. probinson added a comment. Update some SATURATEx to SATURATExU CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151749/new/ https://reviews.llvm.org/D151749 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5399f1d7cab: [Headers][doc] Add shuffle-like intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. Changed

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I'm traveling but will look at this on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017 ___ cfe-commits mailing list cfe-commi

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson created this revision. probinson added reviewers: rjmccall, MaskRay. Herald added a project: All. probinson requested review of this revision. People use -ffunction-sections to put each function into its own object-file section; this makes linker garbage-collection simpler. However, if t

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. This works in my simple test cases, but I'm not 100% sure it's (a) the best place to do this, or (b) the only place that needs to do this. Really we should guarantee that `comdat any` wins over `comdat nodeduplicate` in all cases. CHANGES SINCE LAST ACTION https://

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. I'm not sure I understand the linker's mechanics here. Let me say some things and you can describe my misunderstanding. - If the linker was going to discard all of section foo (in the current scheme), that means it had no reason to retain either f() or g(). In the new

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson abandoned this revision. probinson added a comment. Discussion on the GCC bug has persuaded me this is not a good idea. I'll solve my user's problem a different way. @MaskRay you can close the GCC bug, it looks like I can't do it myself. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D144188: Tighten up a modules test

probinson created this revision. probinson added a reviewer: ChuanqiXu. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D144188 Files: clang/test/CXX/module/basic/basic.def.odr/p4.cppm Index: clang/test/CXX/module/basic/basic.def.odr/p4.cppm

[PATCH] D144188: Tighten up a modules test

probinson added a comment. I looked at this test only because it caused a merge conflict downstream. While it does work, it will not catch some kinds of mistakes; by being less specific in the "not" checks, it will catch more potential problems. Comment at: clang/test/CXX/mod

[PATCH] D144188: Tighten up a modules test

This revision was automatically updated to reflect the committed changes. Closed by commit rG17a90f1196c1: Tighten up a modules test (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144188/new/ ht

[PATCH] D144586: [PS4/PS5] Specify no or

probinson created this revision. probinson added a reviewer: aaron.ballman. Herald added a project: All. probinson requested review of this revision. We've never provided these headers so set the preprocessor toggles to reflect that. https://reviews.llvm.org/D144586 Files: clang/lib/Basic/Tar

[PATCH] D144586: [PS4/PS5] Specify no or

probinson added a comment. That's correct, I do see in our SDK. I don't see a need for a release note; we're not actually removing anything that we used to support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144586/new/ https://reviews.llvm.org/D144586 ___

[PATCH] D144586: [PS4/PS5] Specify no or

This revision was automatically updated to reflect the committed changes. Closed by commit rG32d441bfb4f3: [PS4/PS5] Specify no or (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D150278 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG642bd1123d05: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. Repository:

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0905c567f0c7: [Headers][doc] Add FMA intrinsic descriptions (authored by probinson). Herald added a project: clang. Changed prior to commit: https

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added a comment. I chose to leave the "for each element" cases as-is, but I will keep your comments in mind as I go through other intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148021/new/ https://reviews.llvm.org/D148021 ___

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D148653 Files: clang/lib/Headers/mwaitxintrin.h clang/lib/Headers/pmmintrin.h Index:

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ddcef2ad3db: [Headers][doc] Add/revise MONITOR/MWAIT descriptions (authored by probinson). Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson added inline comments. Comment at: clang/lib/Headers/pmmintrin.h:278 ///the monitor event pending state. Data stored in the monitored address ///range causes the processor to exit the pending state. /// goldstein.w.n wrote: > interrupts too.

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D149205 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

probinson marked 2 inline comments as done. probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:942 +/// +/// \code +/// FOR element := 0 to 1 pengfei wrote: > Use `\code{.operation}` please, the same below. Our internal tool will > recog

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. probinson marked an inline comment as done. Closed by commit rG039ae62405b6: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h (authored by probinson).

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I experimented with this. Looks like it emits info only for //defined// methods, and not //used// methods. That is, if you change the test to say `void t1::f1() { f2(); }` you get DWARF for f1 but not f2. The way Sony does it, you get DWARF for f1 and f2. (Neither case

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. In D152017#4397113 , @dblaikie wrote: > What's the particular goal/value in including called-but-not-defined > functions? Are your users generally building only parts of their program with > debug info & you want it to be comp

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. My debugger guy says "this shouldn't be a problem." Given that, my request is that `-gincomplete-types` should be default-true for `DebuggerTuning == SCE` if you want to commit this; otherwise I'll redo our downstream patch to match yours. Repository: rG LLVM Gith

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I have to say I'm not super excited about "-gincomplete-types" given that "incomplete type" means something different to a C++ user. "-gdefined-methods-only" ? reads awkwardly in the no- form. "-gsuppress-undefined-methods" ? which is similar to what we called it. "-gu

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. Oh, `-fstandalone-debug` should override this? In the Sony implementation, it does. (Sorry for not remembering that sooner.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017 ___

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. Could always go with `-gsuppress-undefined-methods` if you're not happy about default-on options. I don't have a strong opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson created this revision. probinson added reviewers: uweigand, Kai. Herald added a project: All. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Part of the project to eliminate special handling for triple

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. The changes in this patch assume that there aren't any possible suffixes after the `-zos` part of the triple (no version numbers, like you might find with darwin or macos, and nothing like `-elf` or `-eabi` like some targets have). If there are suffixes, I'll happily

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. LGTM. I agree with the commentary in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 ___ cfe-commits mailing list cfe-comm

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Oh, right, PS4 defaults to C99. It's okay with me if you make those two unsupported for PS4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 __

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson updated this revision to Diff 481421. probinson added a comment. Add trailing '{{.*}}' as requested. Have not changed the encoding.ll test, waiting on @uweigand about correct value to test in Python. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.ll

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. I suppose we could temporarily add a test that does ; REQUIRES: target={{.*}}-zos ; RUN: %python -c 'import platform; print(platform.system())' && false and see what gets printed. Searching the buildbot console page for 'zos' turns up nothing; 's390' turns up cla

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson updated this revision to Diff 482180. probinson added a comment. Herald added a subscriber: delcypher. Define 'system-zos' and use it in the one test that needs it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 Files: clang/test/

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. Thanks @Kai and @uweigand, good to know a z/OS bot is in the works. Hope this patch now meets your needs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 ___ cfe-commits m

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7793e676514b: [ZOS] Convert tests to check 'target={{.*}}-zos{{.*}}' (authored by probinson). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

probinson added a comment. See D139967 for why `UNSUPPORTED: powerpc` didn't work. That patch will put it back, and also update the lit config so the check will work now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > IIUC the labels have to match a line in the file uniquely, which the DW_TAGs > wouldn't CHECK-LABEL doesn't have to match a line in the file uniquely. What happens is that all the -LABEL directives are processed first, in order, subdividing the input text into regi

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > CHECK-LABEL doesn't have to match a line in the file uniquely. I mean, it's good practice if they do match uniquely; that way you don't get excessively confusing results when the output changes, and things start matching where you didn't expect. But it's not a requ

[PATCH] D138954: [PPC] Convert tests to check 'target='

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG948bb35d7474: [PPC] Convert tests to check 'target=' (authored by probinson). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D27794: Make some diagnostic tests C++11 clean

probinson created this revision. probinson added a reviewer: rsmith. probinson added subscribers: cfe-commits, tigerleapgorge. Another half-dozen test revisions in the ongoing campaign to make things ready for C++11 as Clangs's default dialect. Most of these are straightforward, but I am not ent

[PATCH] D27794: Make some diagnostic tests C++11 clean

probinson added a reviewer: ABataev. probinson added a comment. +abataev for OpenMP. https://reviews.llvm.org/D27794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27794: Make some diagnostic tests C++11 clean

probinson added a reviewer: rnk. probinson updated this revision to Diff 81977. probinson added a comment. Remove the OpenMP tests from this review (committed in r290128). +rnk who added test/Parser/backtrack-off-by-one.cpp originally. https://reviews.llvm.org/D27794 Files: test/FixIt/fixit.

[PATCH] D27936: C++11 test cleanup: nonthrowing destructors

probinson created this revision. probinson added a reviewer: rsmith. probinson added a subscriber: cfe-commits. If a dtor has no interesting members, then it ends up being nothrow, which affects the generated IR. Modify some tests to tolerate this difference between C++03 and C++11. In C++11, a

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

probinson created this revision. probinson added a reviewer: rjmccall. probinson added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. The test conjures up and returns a temp which has a struct type, and the struct has some empty/padding bytes in the middle. In C++03 the

[PATCH] D27956: Make CodeGenCXX/stack-reuse-miscompile.cpp tolerate C++11

probinson created this revision. probinson added a reviewer: lenykholodov. probinson added a subscriber: cfe-commits. In this test, the allocas for the temps come out in a different order depending on whether the dialect is C++03 or C++11. To avoid depending on the default dialect, I forced it

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

probinson updated this revision to Diff 82021. probinson added a comment. Force C++03 on this test, to make it insensitive to future changes in the default dialect. https://reviews.llvm.org/D27955 Files: test/CodeGenCXX/arm-swiftcall.cpp Index: test/CodeGenCXX/arm-swiftcall.cpp ===

[PATCH] D27955: Make CodeGenCXX/arm-swiftcall.cpp tolerate C++11

This revision was automatically updated to reflect the committed changes. Closed by commit rL290145: Make another test insensitive to the default C++ dialect. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27955?vs=82021&id=82028#toc Repository: rL LLVM https://

[PATCH] D27936: C++11 test cleanup: nonthrowing destructors

probinson added a reviewer: rjmccall. probinson added a comment. +rjmccall as IR Gen owner. https://reviews.llvm.org/D27936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27994: Make two vtable tests tolerate C++11

probinson created this revision. probinson added a reviewer: rjmccall. probinson added a subscriber: cfe-commits. In C++11, we don't emit vtables as eagerly as we do for C++03, so fiddle the tests to emit them when the test expects them. In the C++11 test cleanup project, we're commonly making t

[PATCH] D27994: Make two vtable tests tolerate C++11

This revision was automatically updated to reflect the committed changes. Closed by commit rL290205: Make two vtable tests tolerate C++11. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27994?vs=82126&id=82156#toc Repository: rL LLVM https://reviews.llvm.org/D27

[PATCH] D27936: C++11 test cleanup: nonthrowing destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rL290207: C++11 test cleanup: nonthrowing destructors (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27936?vs=81982&id=82157#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D27956: Make CodeGenCXX/stack-reuse-miscompile.cpp tolerate C++11

This revision was automatically updated to reflect the committed changes. Closed by commit rL290208: Make a test use a specific C++ dialect (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27956?vs=82020&id=82160#toc Repository: rL LLVM https://reviews.llvm.org/D2

[PATCH] D27794: Make some diagnostic tests C++11 clean

probinson marked an inline comment as done. probinson added a comment. FIXME added. https://reviews.llvm.org/D27794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27794: Make some diagnostic tests C++11 clean

This revision was automatically updated to reflect the committed changes. Closed by commit rL290262: Make some diagnostic tests C++11 clean. (authored by probinson). Changed prior to commit: https://reviews.llvm.org/D27794?vs=81977&id=82248#toc Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. Maybe instead, pass a flag to enable setting optnone on everything when the driver sees `-O0 -flto`? The patch as-is obviously has a massive testing cost, and it's easy to imagine people being tripped up by this in the future. https://reviews.llvm.org/D28404

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#638221, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#638217, @probinson wrote: > > > The patch as-is obviously has a massive testing cost, and it's easy to > > imagine people being tripped up by this in the future. > > > C

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#638350, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#638299, @probinson wrote: > > > In https://reviews.llvm.org/D28404#638221, @mehdi_amini wrote: > > > > > In https://reviews.llvm.org/D28404#638217, @probinson wrote: > >

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:962 + ShouldAddOptNone &= !D->hasAttr(); + ShouldAddOptNone &= !D->hasAttr(); + ShouldAddOptNone &= !F->hasFnAttribute(llvm::Attribute::AlwaysInline); chandlerc wrote: > why is op

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:896 + !CodeGenOpts.DisableO0ImplyOptNone && CodeGenOpts.OptimizationLevel == 0; + // We can't add optnone in the following cases, it won't pass the verifier + ShouldAddOptNone &= !D->hasAttr()

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:910-912 // OptimizeNone wins over OptimizeForSize and MinSize. F->removeFnAttr(llvm::Attribute::OptimizeForSize); F->removeFnAttr(llvm::Attribute::MinSize); mehdi_amin

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. Over the weekend I had a thought: Why is -O0 so special here? That is, after going to all this trouble to propagate -O0 to LTO, how does this generalize to propagating -O1 or any other specific -O option? (Maybe this question would be better dealt with on the dev l

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#639887, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#639874, @probinson wrote: > > > Over the weekend I had a thought: Why is -O0 so special here? That is, > > after going to all this trouble to propagate -O0 to LTO, how

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640046, @probinson wrote: > > > "I don't care" doesn't seem like much of a principle. > > > Long version is: "There is no use-case, no users, so I don't have much > moti

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640170, @probinson wrote: > In my experience, modifying source Note that the source modification consists of adding `#pragma clang optimize off` to the top of the file. It is not a complicated thing. https://reviews.llvm.org/D284

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640170, @probinson wrote: > > > In https://reviews.llvm.org/D28404#640090, @mehdi_amini wrote: > > > > > In https://reviews.llvm.org/D28404#640046, @probinson wrote: > >

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640182, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > > > Also, that's not practicable: what if I have an LTO static library for > > which I don't have the source, now if I build my own file wi

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > I don't follow: IMO if I generate a module with optnone and pipe it to `opt > -O3` I expect no function IR to be touched. If it is not the case it is a bug. Your opinion and expectation are not supporte

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > You just wrote above that " mixing -O0 and LTO " is wrong, *if* I were to > agree with you at some point, then I'd make it a hard error. Yes, I was not clear that I meant that `-O0 -flto` on the same cl

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640284, @probinson wrote: > > > Upfront, it seemed peculiar to handle only one optimization level. After > > more thought, the whole idea of mixing -O0 and LTO seems wr

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#640284, @probinson wrote: > > > In https://reviews.llvm.org/D28404#640178, @mehdi_amini wrote: > > > > > In https://reviews.llvm.org/D28404#640170, @probinson wrote: > >

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. Basically, I don't see why having clang always emit a real .o at -O0 would be a problem. I haven't gotten through the other-CFI documentation yet though. https://reviews.llvm.org/D28404 ___ cfe-commits mailing list cfe-co

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640362, @probinson wrote: > In https://reviews.llvm.org/D28404#640314, @mehdi_amini wrote: > > > I don't follow: IMO if I generate a module with optnone and pipe it to `opt > > -O3` I expect no function IR to be touched. If it is not

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640588, @mehdi_amini wrote: > Actually, as mentioned before, I could be fine with making `O0` incompatible > with LTO, however security features like CFI (or other sort of whole-program > analyses/instrumentations) requires LTO. We

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#640682, @mehdi_amini wrote: > > I'm now thinking along the lines of a `-foptimize-off` flag (bikesheds > > welcome) which would set the default for the pragma to 'off'. How is that > > different than what you wanted for `-O0`? It i

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

probinson added a comment. In https://reviews.llvm.org/D28404#641078, @chandlerc wrote: > For me, the arguments you're raising against -O0 and -flto don't hold up on > closer inspection: > > - O0 != optnone: correct. But this is only visible in LTO. And in LTO, Os != > optsize, and Oz != minsiz

<    1   2   3   4   5   6   >