probinson added inline comments.
================
Comment at: clang/lib/Headers/avx2intrin.h:156
+/// A 256-bit vector containing one of the source operands.
+/// \returns A 256-bit vector containing the sums.
static __inline__ __m256i __DEFAULT_FN_ATTRS256
----------------
craig.topper wrote:
> Why do some return descriptions include the type like [4 x i64] but some
> don't?
My policy has been to provide the type for element sizes other than byte. So, I
haven't been saying [32 x i8] but I do say [4 x i64] or whatever.
Although, I have also tended to say "integer vector" when it's a byte vector,
and I'll make that consistent here as well.
================
Comment at: clang/lib/Headers/avx2intrin.h:1043
+/// corresponding byte of the 256-bit integer vector result (overflow is
+/// ignored). For each byte, computes <c> result = __a - __b </c>.
+///
----------------
pengfei wrote:
> It better to move it to `\code{.operation}` for consistency. Same for the
> below.
Okay.
================
Comment at: clang/lib/Headers/avx2intrin.h:1050
+/// \param __a
+/// A 256-bit vector containing the subtrahends.
+/// \param __b
----------------
craig.topper wrote:
> I think minuend and subtrahend are swapped here.
Thanks for catching that!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150114/new/
https://reviews.llvm.org/D150114
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
