probinson added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:896 + !CodeGenOpts.DisableO0ImplyOptNone && CodeGenOpts.OptimizationLevel == 0; + // We can't add optnone in the following cases, it won't pass the verifier + ShouldAddOptNone &= !D->hasAttr<MinSizeAttr>(); ---------------- Period at the end of a comment. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:900 + ShouldAddOptNone &= !D->hasAttr<AlwaysInlineAttr>(); + if (ShouldAddOptNone) { + B.addAttribute(llvm::Attribute::OptimizeNone); ---------------- This block is redundant now? The same things are added in the next if block. https://reviews.llvm.org/D28404 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits